You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/06/24 14:39:03 UTC
[GitHub] [spark] HyukjinKwon commented on issue #24950: [MINOR][BUILD]
Exclude pyspark-coverage-site/ dir from RAT
HyukjinKwon commented on issue #24950: [MINOR][BUILD] Exclude pyspark-coverage-site/ dir from RAT
URL: https://github.com/apache/spark/pull/24950#issuecomment-505039116
This is fine too. Alternatively, maybe we should rather remove `pyspark-site-coverage/` entirely explicitly after each run. `pyspark-site-coverage/` was added in `spark-master-sbt-hadoop-2.7` specifically as of https://github.com/apache/spark/pull/23117.
In the job specifically, it runs PySpark tests with `coverage` and updates it to https://github.com/spark-test/pyspark-coverage-site.
I met this issue before .. it was here - https://github.com/apache/spark/pull/23729 `pyspark-coverage-site` should be removed after each run but somehow it wasn't.
RAT checks happens after PySpark tests. So it's likely the same thing being happening again.
@shaneknapp and @srowen, maybe I have to reopen https://github.com/apache/spark/pull/23729 and manually remove to make sure such things don't happen.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org