You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by packet23 <gi...@git.apache.org> on 2016/05/25 12:38:05 UTC
[GitHub] flink pull request: [FLINK-3937] Implemented -yid option to Flink ...
GitHub user packet23 opened a pull request:
https://github.com/apache/flink/pull/2034
[FLINK-3937] Implemented -yid option to Flink cli list, savepoint, cancel and stop subcommands
I created a PR from the patch I already attached to the JIRA issue.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/researchgate/flink FLINK-3937
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2034.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2034
----
commit 0599329c21e8dae0c36b69e04395016c1cb2f646
Author: Sebastian Klemke <se...@researchgate.net>
Date: 2016-05-25T12:28:59Z
Implemented -yid option to Flink cli list, savepoint, cancel and stop subcommands.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2034: [FLINK-3937] Implemented -yid option to Flink cli list, s...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2034
Merged. Thank you for your contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2034: [FLINK-3937] Implemented -yid option to Flink cli ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2034
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3937] Implemented -yid option to Flink ...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2034#discussion_r64572519
--- Diff: flink-clients/src/main/java/org/apache/flink/client/FlinkYarnSessionCli.java ---
@@ -91,6 +93,7 @@
public FlinkYarnSessionCli(String shortPrefix, String longPrefix) {
QUERY = new Option(shortPrefix + "q", longPrefix + "query", false, "Display available YARN resources (memory, cores)");
+ APPLICATION_ID = new Option(shortPrefix + "id", longPrefix + "applicationId", true, "Attach to running YARN session");
--- End diff --
The `APPLICATION_ID` option is integrated here but the `FlinkYarnSessionCli` doesn't support attaching to existing applications. I think it could be useful to check during instantiation of the YarnSessionCli in the `run(..)` method whether we want to start a new application or resume.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3937] Implemented -yid option to Flink ...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/2034#issuecomment-221577444
Thanks for the pull request! Looks good! Do you think we could integrate with the `FlinkYarnSessionCli` as well? Once we merge this I will port this to the client changes in #1978.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2034: [FLINK-3937] Implemented -yid option to Flink cli list, s...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2034
Thanks for the update!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---