You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2019/04/23 08:18:11 UTC

[GitHub] [incubator-openwhisk] markusthoemmes commented on a change in pull request #4450: Fix test cases to also work with nodejs:10 as default nodejs runtime.

markusthoemmes commented on a change in pull request #4450: Fix test cases to also work with nodejs:10 as default nodejs runtime.
URL: https://github.com/apache/incubator-openwhisk/pull/4450#discussion_r277563228
 
 

 ##########
 File path: tests/src/test/scala/invokerShoot/ShootInvokerTests.scala
 ##########
 @@ -188,13 +189,13 @@ class ShootInvokerTests extends TestHelpers with WskTestHelpers with JsHelpers w
         JsObject("key" -> JsString("copiedAnnot2"), "value" -> JsBoolean(false)),
         JsObject("key" -> JsString("copiedAnnot1"), "value" -> JsString("copiedAnnotValue1")),
         JsObject("key" -> JsString("origAnnot2"), "value" -> JsBoolean(true)),
-        JsObject("key" -> JsString("exec"), "value" -> JsString("nodejs:6")),
+//        JsObject("key" -> JsString("exec"), "value" -> JsString(runtime)),
 
 Review comment:
   Please drop this line.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services