You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by rob05c <gi...@git.apache.org> on 2017/02/09 21:02:44 UTC
[GitHub] incubator-trafficcontrol pull request #270: Fix Traffic Monitor 2.0 Duplicat...
GitHub user rob05c opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/270
Fix Traffic Monitor 2.0 Duplicate Events
Fixes duplicate events from the Peer and Stat manager both calling CombineCrStates with their own maps of whether the event had been generated.
Fixes the issue by creating a new StateCombiner goroutine, with a single map. This avoids a race condition with the other solution, a shared threadsafe map.
Divides stat combination into separate functions for Cache and Delivery Service state, for each cache being combined. This isn't simply for readability, but by having separate functions, it gives the Go scheduler a chance to schedule other goroutines, preventing this combiner goroutine (which takes ~100ms to run) from starving other tasks.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rob05c/incubator-trafficcontrol tm2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/270.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #270
----
commit 47a069c60ddc3e2cb1379834e1c7215ad401011b
Author: Robert Butts <ro...@gmail.com>
Date: 2017-02-09T16:51:15Z
Add Traffic Ops Client Login deprecated comment
commit 39d325ec727f04316d1f9301730dbf31e75b06c0
Author: Robert Butts <ro...@gmail.com>
Date: 2017-02-09T20:57:06Z
Fix TM2 duplicate events
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #270: Fix Traffic Monitor 2.0 Duplicat...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafficcontrol/pull/270
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---