You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Paul Field (JIRA)" <ji...@apache.org> on 2009/06/25 15:34:07 UTC
[jira] Created: (TAP5-758) Move TapestryTestConstants from
tapestry-test into tapestry-core, so that non-selenium test code does not
need to use tapestry-test
Move TapestryTestConstants from tapestry-test into tapestry-core, so that non-selenium test code does not need to use tapestry-test
-----------------------------------------------------------------------------------------------------------------------------------
Key: TAP5-758
URL: https://issues.apache.org/jira/browse/TAP5-758
Project: Tapestry 5
Issue Type: Improvement
Components: tapestry-core, tapestry-test
Affects Versions: 5.1.0.5
Reporter: Paul Field
The tapestry-test module is meant to be "just a couple of base classes to make it easier to build integration test suites around Selenium.".
However, org.apache.tapestry5.internal.test.PageTesterContext for tapestry-core uses TapestryTestConstants from tapestry-test. So it seems that anyone doing any kind of tests requires the tapestry-test module and so also imports all the selenium dependencies.
That dependency problem could be resolved by moving TapestryTestConstants into tapestry-core.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-758) Move TapestryTestConstants from
tapestry-test into tapestry-core, so that non-selenium test code does not
need to use tapestry-test
Posted by "Paul Field (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790278#action_12790278 ]
Paul Field commented on TAP5-758:
---------------------------------
It's possible that you need several modules to manage the dependencies properly.
For example:
tapestry-test contains EasyMock/TestNG code and general test code such as TapestryTestConstants
tapestry-selenium includes the selenium code (and depends on tapestry-test)
If you want to be really serious about dependencies and what you force clients to include (which is more important in the OSGi world), you could break the modules down further:
tapestry-test - generic test-related code for Tapestry
tapestry-easymock - adds easymock specific extensions for working with Tapestry
tapestry-testng - enhancements to TestNG to simplify testing Tapestry
tapestry-selenium - enhancements to Selenium to simplify testing in Tapestry
I'm not saying that module breakdown is correct, but I'm suggesting that having more modules at finer granularity is something to consider - remember some people prefer Mockito to EasyMock; some people prefer JUnit4 to TestNG; and finer-grain modules give more flexibility and choice.
> Move TapestryTestConstants from tapestry-test into tapestry-core, so that non-selenium test code does not need to use tapestry-test
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-758
> URL: https://issues.apache.org/jira/browse/TAP5-758
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core, tapestry-test
> Affects Versions: 5.1.0.5
> Reporter: Paul Field
>
> The tapestry-test module is meant to be "just a couple of base classes to make it easier to build integration test suites around Selenium.".
> However, org.apache.tapestry5.internal.test.PageTesterContext for tapestry-core uses TapestryTestConstants from tapestry-test. So it seems that anyone doing any kind of tests requires the tapestry-test module and so also imports all the selenium dependencies.
> That dependency problem could be resolved by moving TapestryTestConstants into tapestry-core.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-758) Move TapestryTestConstants from
tapestry-test into tapestry-core, so that non-selenium test code does not
need to use tapestry-test
Posted by "Paul Field (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790278#action_12790278 ]
Paul Field commented on TAP5-758:
---------------------------------
It's possible that you need several modules to manage the dependencies properly.
For example:
tapestry-test contains EasyMock/TestNG code and general test code such as TapestryTestConstants
tapestry-selenium includes the selenium code (and depends on tapestry-test)
If you want to be really serious about dependencies and what you force clients to include (which is more important in the OSGi world), you could break the modules down further:
tapestry-test - generic test-related code for Tapestry
tapestry-easymock - adds easymock specific extensions for working with Tapestry
tapestry-testng - enhancements to TestNG to simplify testing Tapestry
tapestry-selenium - enhancements to Selenium to simplify testing in Tapestry
I'm not saying that module breakdown is correct, but I'm suggesting that having more modules at finer granularity is something to consider - remember some people prefer Mockito to EasyMock; some people prefer JUnit4 to TestNG; and finer-grain modules give more flexibility and choice.
> Move TapestryTestConstants from tapestry-test into tapestry-core, so that non-selenium test code does not need to use tapestry-test
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-758
> URL: https://issues.apache.org/jira/browse/TAP5-758
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core, tapestry-test
> Affects Versions: 5.1.0.5
> Reporter: Paul Field
>
> The tapestry-test module is meant to be "just a couple of base classes to make it easier to build integration test suites around Selenium.".
> However, org.apache.tapestry5.internal.test.PageTesterContext for tapestry-core uses TapestryTestConstants from tapestry-test. So it seems that anyone doing any kind of tests requires the tapestry-test module and so also imports all the selenium dependencies.
> That dependency problem could be resolved by moving TapestryTestConstants into tapestry-core.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-758) Move TapestryTestConstants from
tapestry-test into tapestry-core, so that non-selenium test code does not
need to use tapestry-test
Posted by "Igor Drobiazko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790248#action_12790248 ]
Igor Drobiazko commented on TAP5-758:
-------------------------------------
This issue conflicts with TAP5-952
> Move TapestryTestConstants from tapestry-test into tapestry-core, so that non-selenium test code does not need to use tapestry-test
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-758
> URL: https://issues.apache.org/jira/browse/TAP5-758
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core, tapestry-test
> Affects Versions: 5.1.0.5
> Reporter: Paul Field
>
> The tapestry-test module is meant to be "just a couple of base classes to make it easier to build integration test suites around Selenium.".
> However, org.apache.tapestry5.internal.test.PageTesterContext for tapestry-core uses TapestryTestConstants from tapestry-test. So it seems that anyone doing any kind of tests requires the tapestry-test module and so also imports all the selenium dependencies.
> That dependency problem could be resolved by moving TapestryTestConstants into tapestry-core.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-758) Move TapestryTestConstants from
tapestry-test into tapestry-core, so that non-selenium test code does not
need to use tapestry-test
Posted by "Igor Drobiazko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Drobiazko reassigned TAP5-758:
-----------------------------------
Assignee: Igor Drobiazko
> Move TapestryTestConstants from tapestry-test into tapestry-core, so that non-selenium test code does not need to use tapestry-test
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-758
> URL: https://issues.apache.org/jira/browse/TAP5-758
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core, tapestry-test
> Affects Versions: 5.1.0.5
> Reporter: Paul Field
> Assignee: Igor Drobiazko
>
> The tapestry-test module is meant to be "just a couple of base classes to make it easier to build integration test suites around Selenium.".
> However, org.apache.tapestry5.internal.test.PageTesterContext for tapestry-core uses TapestryTestConstants from tapestry-test. So it seems that anyone doing any kind of tests requires the tapestry-test module and so also imports all the selenium dependencies.
> That dependency problem could be resolved by moving TapestryTestConstants into tapestry-core.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-758) Move TapestryTestConstants from
tapestry-test into tapestry-core, so that non-selenium test code does not
need to use tapestry-test
Posted by "Igor Drobiazko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790248#action_12790248 ]
Igor Drobiazko commented on TAP5-758:
-------------------------------------
This issue conflicts with TAP5-952
> Move TapestryTestConstants from tapestry-test into tapestry-core, so that non-selenium test code does not need to use tapestry-test
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-758
> URL: https://issues.apache.org/jira/browse/TAP5-758
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core, tapestry-test
> Affects Versions: 5.1.0.5
> Reporter: Paul Field
>
> The tapestry-test module is meant to be "just a couple of base classes to make it easier to build integration test suites around Selenium.".
> However, org.apache.tapestry5.internal.test.PageTesterContext for tapestry-core uses TapestryTestConstants from tapestry-test. So it seems that anyone doing any kind of tests requires the tapestry-test module and so also imports all the selenium dependencies.
> That dependency problem could be resolved by moving TapestryTestConstants into tapestry-core.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-758) Move TapestryTestConstants from
tapestry-test into tapestry-core, so that non-selenium test code does not
need to use tapestry-test
Posted by "Igor Drobiazko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Drobiazko reassigned TAP5-758:
-----------------------------------
Assignee: Igor Drobiazko
> Move TapestryTestConstants from tapestry-test into tapestry-core, so that non-selenium test code does not need to use tapestry-test
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-758
> URL: https://issues.apache.org/jira/browse/TAP5-758
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core, tapestry-test
> Affects Versions: 5.1.0.5
> Reporter: Paul Field
> Assignee: Igor Drobiazko
>
> The tapestry-test module is meant to be "just a couple of base classes to make it easier to build integration test suites around Selenium.".
> However, org.apache.tapestry5.internal.test.PageTesterContext for tapestry-core uses TapestryTestConstants from tapestry-test. So it seems that anyone doing any kind of tests requires the tapestry-test module and so also imports all the selenium dependencies.
> That dependency problem could be resolved by moving TapestryTestConstants into tapestry-core.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.