[jira] [Commented] (GEODE-4053) Create module for Protobuf messages

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281055#comment-16281055 ] 

ASF GitHub Bot commented on GEODE-4053:
---------------------------------------

PivotalSarge opened a new pull request #1133: GEODE-4053: Create module for Protobuf messages
URL: https://github.com/apache/geode/pull/1133
 
 
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   - [x] Does `gradlew build` run cleanly?
   
   - [n/a] Have you written or updated unit tests to verify your changes?
   
   - [n/a] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Create module for Protobuf messages
> -----------------------------------
>
>                 Key: GEODE-4053
>                 URL: https://issues.apache.org/jira/browse/GEODE-4053
>             Project: Geode
>          Issue Type: Improvement
>          Components: client/server
>            Reporter: Michael Dodge
>             Fix For: 1.4.0
>
>
> Currently, the Java classes generated from the Protobuf files for the new protocol are packages inside geode-protobuf. As this module also implements the client protocol using the Protobuf messages, it depends on geode-client-protocol and geode-core. This results in unnecessary dependencies for just using the Protobuf messages. Extract the Java classes generated from the Protobuf files into their own module, geode-protobuf-messages, on which geode-protobuf depends.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)