You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/11/19 22:13:57 UTC
[GitHub] [incubator-pinot] siddharthteotia commented on issue #4834: Replace
NettyTCPServer with QueryServer for server side query handling
siddharthteotia commented on issue #4834: Replace NettyTCPServer with QueryServer for server side query handling
URL: https://github.com/apache/incubator-pinot/pull/4834#issuecomment-555740802
A high level comment in addition to the ones I have on changes:
I am not sure if I follow the changes here completely. The PR indicates it replaces existing NettyTCPServer with QueryServer and I don't see that happening in the code. NettyTCPServer class is untouched. Do we intend to delete it? I see we have started using the QueryServer instead of NettyServer in ServerResponse.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org