You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2020/10/07 06:04:44 UTC
[GitHub] [carbondata] akashrn5 commented on a change in pull request #3961: [CARBONDATA-4019]Fix CDC merge failure join expression made of AND/OR expressions.
akashrn5 commented on a change in pull request #3961:
URL: https://github.com/apache/carbondata/pull/3961#discussion_r500756989
##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/mutation/merge/CarbonMergeDataSetCommand.scala
##########
@@ -106,18 +106,22 @@ case class CarbonMergeDataSetCommand(
// decide join type based on match conditions
val joinType = decideJoinType
- val joinColumn = mergeMatches.joinExpr.expr.asInstanceOf[EqualTo].left
- .asInstanceOf[UnresolvedAttribute].nameParts.tail.head
- // repartition the srsDs, if the target has bucketing and the bucketing column and join column
- // are same
+ val joinColumns = mergeMatches.joinExpr.expr.collect {
+ case unresolvedAttribute: UnresolvedAttribute if unresolvedAttribute.nameParts.nonEmpty =>
+ unresolvedAttribute.nameParts.tail.head
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org