You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "koarz (via GitHub)" <gi...@apache.org> on 2025/05/19 07:49:18 UTC
[PR] [Enhancement]add information_schema backend_configuration table [doris]
koarz opened a new pull request, #51024:
URL: https://github.com/apache/doris/pull/51024
### What problem does this PR solve?
complete: https://github.com/apache/doris/pull/49587
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2919119112
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "koarz (via GitHub)" <gi...@apache.org>.
koarz commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2918013441
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2915014234
<details>
<summary>ClickBench: <b>Total hot run time: 29.66 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 55a614327dd851a1d761d9f4e63865438c60e2f2, data reload: false
query1 0.03 0.03 0.03
query2 0.15 0.10 0.11
query3 0.34 0.20 0.20
query4 1.59 0.21 0.22
query5 0.47 0.46 0.46
query6 1.15 0.66 0.66
query7 0.02 0.01 0.01
query8 0.06 0.05 0.05
query9 0.62 0.54 0.52
query10 0.58 0.58 0.57
query11 0.26 0.13 0.13
query12 0.25 0.14 0.13
query13 0.64 0.62 0.62
query14 0.80 0.84 0.82
query15 0.97 0.87 0.86
query16 0.37 0.38 0.37
query17 1.05 1.03 1.05
query18 0.18 0.18 0.18
query19 1.98 1.79 1.87
query20 0.01 0.01 0.01
query21 15.40 0.95 0.67
query22 0.92 1.02 0.75
query23 14.72 1.57 0.76
query24 5.47 0.57 0.29
query25 0.17 0.09 0.08
query26 0.56 0.23 0.18
query27 0.08 0.08 0.08
query28 11.04 1.21 0.59
query29 12.54 4.13 3.38
query30 0.27 0.08 0.07
query31 2.80 0.65 0.44
query32 3.23 0.59 0.50
query33 3.00 3.11 3.07
query34 16.43 5.14 4.47
query35 4.42 4.51 4.45
query36 0.62 0.51 0.49
query37 0.20 0.16 0.16
query38 0.17 0.16 0.15
query39 0.04 0.04 0.05
query40 0.23 0.16 0.16
query41 0.11 0.06 0.05
query42 0.07 0.05 0.04
query43 0.05 0.05 0.04
Total cold run time: 104.06 s
Total hot run time: 29.66 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2908533311
<details>
<summary>ClickBench: <b>Total hot run time: 28.93 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2333609c75cbdf24c67a6e667a775c4796132a0d, data reload: false
query1 0.03 0.03 0.04
query2 0.12 0.10 0.11
query3 0.25 0.19 0.19
query4 1.61 0.20 0.18
query5 0.44 0.41 0.44
query6 1.17 0.69 0.65
query7 0.03 0.01 0.01
query8 0.04 0.03 0.04
query9 0.58 0.50 0.52
query10 0.59 0.56 0.57
query11 0.16 0.11 0.11
query12 0.15 0.12 0.11
query13 0.62 0.61 0.60
query14 0.79 0.80 0.81
query15 0.88 0.83 0.87
query16 0.37 0.39 0.37
query17 1.01 1.06 1.03
query18 0.23 0.21 0.22
query19 1.90 1.87 1.82
query20 0.02 0.01 0.02
query21 15.40 0.90 0.55
query22 0.76 1.06 0.62
query23 15.13 1.38 0.61
query24 7.07 1.78 0.59
query25 0.47 0.28 0.15
query26 0.54 0.16 0.15
query27 0.06 0.05 0.04
query28 9.97 0.87 0.46
query29 12.53 3.95 3.36
query30 0.26 0.10 0.07
query31 2.81 0.63 0.38
query32 3.23 0.56 0.47
query33 3.07 3.12 3.18
query34 15.80 5.15 4.49
query35 4.51 4.50 4.48
query36 0.67 0.50 0.49
query37 0.09 0.07 0.06
query38 0.04 0.04 0.04
query39 0.03 0.03 0.03
query40 0.16 0.14 0.14
query41 0.09 0.03 0.03
query42 0.04 0.03 0.03
query43 0.03 0.03 0.02
Total cold run time: 103.75 s
Total hot run time: 28.93 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](systable)add information_schema backend_configuration table [doris]
Posted by "koarz (via GitHub)" <gi...@apache.org>.
koarz commented on code in PR #51024:
URL: https://github.com/apache/doris/pull/51024#discussion_r2122559783
##########
be/src/exec/schema_scanner/schema_backend_configuration_scanner.cpp:
##########
@@ -0,0 +1,106 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "exec/schema_scanner/schema_backend_configuration_scanner.h"
+
+#include <gen_cpp/Descriptors_types.h>
+
+#include <string>
+
+#include "runtime/define_primitive_type.h"
+#include "runtime/exec_env.h"
+#include "runtime/runtime_state.h"
+#include "vec/common/string_ref.h"
+#include "vec/core/block.h"
+
+namespace doris {
+
+std::vector<SchemaScanner::ColumnDesc> SchemaBackendConfigurationScanner::_s_tbls_columns = {
+ // name, type, size, is_null
+ {"BE_ID", TYPE_BIGINT, sizeof(int64_t), true},
+ {"CONFIG_NAME", TYPE_STRING, sizeof(StringRef), true},
+ {"CONFIG_TYPE", TYPE_STRING, sizeof(StringRef), true},
+ {"CONFIG_VALUE", TYPE_STRING, sizeof(StringRef), true},
+ {"IS_MUTABLE", TYPE_BOOLEAN, sizeof(bool), true}};
+
+SchemaBackendConfigurationScanner::SchemaBackendConfigurationScanner()
+ : SchemaScanner(_s_tbls_columns, TSchemaTableType::SCH_BACKEND_CONFIGURATION),
+ _backend_id(ExecEnv::GetInstance()->cluster_info()->backend_id) {}
+
+SchemaBackendConfigurationScanner::~SchemaBackendConfigurationScanner() = default;
+
+Status SchemaBackendConfigurationScanner::start(doris::RuntimeState* state) {
+ _config_infos = config::get_config_info();
+ return Status::OK();
+}
+
+Status SchemaBackendConfigurationScanner::get_next_block_internal(vectorized::Block* block,
+ bool* eos) {
+ if (!_is_init) {
+ return Status::InternalError("Used before initialized.");
+ }
+
+ if (nullptr == block || nullptr == eos) {
+ return Status::InternalError("input pointer is nullptr.");
+ }
+
+ *eos = true;
+ if (_config_infos.empty()) {
+ return Status::OK();
+ }
+
+ for (size_t col_idx = 0; col_idx < _s_tbls_columns.size(); ++col_idx) {
+ size_t row_num = _config_infos.size();
+ std::vector<StringRef> str_refs(row_num);
+ std::vector<int64_t> bigint_vals(row_num);
+ std::vector<int8_t> bool_vals(row_num);
+ std::vector<void*> datas(row_num);
+ std::vector<std::string> column_values(row_num);
+
+ for (size_t row_idx = 0; row_idx < row_num; ++row_idx) {
+ // be_id
+ if (col_idx == 0) {
+ bigint_vals[row_idx] = _backend_id;
+ datas[row_idx] = &bigint_vals[row_idx];
+ } else {
+ // config
+ const auto& row = _config_infos[row_idx];
+ if (row.size() != _s_tbls_columns.size() - 1) {
+ return Status::InternalError(
+ "backend configs info meet invalid schema, schema_size={}, "
+ "input_data_size={}",
+ _config_infos.size(), row.size());
+ }
+
+ std::string& column_value =
+ column_values[row_idx]; // Reference to the actual string in the vector
+ column_value = row[col_idx - 1];
+ if (_s_tbls_columns[col_idx].type == TYPE_BOOLEAN) {
+ bool_vals[row_idx] = column_value == "true" ? 1 : 0;
+ datas[row_idx] = &bool_vals[row_idx];
+ } else {
+ str_refs[row_idx] =
+ StringRef(column_values[row_idx].data(), column_values[row_idx].size());
+ datas[row_idx] = &str_refs[row_idx];
Review Comment:
They are all members of line 66`for loop`, and line 102 is also in this `for`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2890879329
<details>
<summary>ClickBench: <b>Total hot run time: 29.6 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit df74043e94f345f42d2fee58907a53efc81dbf80, data reload: false
query1 0.04 0.04 0.03
query2 0.15 0.11 0.10
query3 0.34 0.20 0.20
query4 1.59 0.19 0.08
query5 0.42 0.40 0.40
query6 1.16 0.65 0.65
query7 0.02 0.02 0.02
query8 0.06 0.05 0.06
query9 0.62 0.53 0.51
query10 0.58 0.58 0.58
query11 0.25 0.13 0.12
query12 0.25 0.13 0.13
query13 0.63 0.62 0.61
query14 0.80 0.82 0.81
query15 0.95 0.87 0.88
query16 0.36 0.38 0.37
query17 1.06 1.06 1.01
query18 0.18 0.17 0.17
query19 2.02 1.85 1.84
query20 0.01 0.01 0.01
query21 15.40 0.99 0.69
query22 0.95 1.10 0.83
query23 14.69 1.46 0.75
query24 5.10 0.63 0.30
query25 0.17 0.09 0.09
query26 0.55 0.22 0.19
query27 0.08 0.08 0.08
query28 11.05 1.21 0.59
query29 12.58 4.14 3.44
query30 0.27 0.08 0.06
query31 2.83 0.63 0.43
query32 3.23 0.58 0.49
query33 3.13 3.08 3.13
query34 16.56 5.10 4.42
query35 4.51 4.49 4.46
query36 0.63 0.50 0.48
query37 0.19 0.17 0.17
query38 0.17 0.15 0.15
query39 0.05 0.04 0.04
query40 0.19 0.16 0.16
query41 0.10 0.06 0.05
query42 0.07 0.05 0.05
query43 0.05 0.04 0.04
Total cold run time: 104.04 s
Total hot run time: 29.6 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2901268193
<details>
<summary>ClickBench: <b>Total hot run time: 29.07 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0b8024bdbb8aa062fb22bfdd40feb9bf757b6dbe, data reload: false
query1 0.04 0.03 0.03
query2 0.12 0.10 0.12
query3 0.25 0.19 0.19
query4 1.59 0.20 0.11
query5 0.43 0.42 0.41
query6 1.17 0.68 0.66
query7 0.03 0.01 0.02
query8 0.04 0.03 0.04
query9 0.58 0.51 0.52
query10 0.57 0.59 0.56
query11 0.16 0.11 0.12
query12 0.14 0.12 0.12
query13 0.62 0.61 0.59
query14 0.78 0.80 0.83
query15 0.89 0.86 0.87
query16 0.38 0.40 0.38
query17 0.99 1.07 1.05
query18 0.22 0.21 0.20
query19 1.88 1.85 1.88
query20 0.01 0.01 0.01
query21 15.41 0.88 0.55
query22 0.78 1.11 0.71
query23 14.93 1.39 0.64
query24 6.83 1.25 0.71
query25 0.47 0.12 0.16
query26 0.58 0.16 0.13
query27 0.05 0.05 0.05
query28 9.96 0.97 0.47
query29 12.53 4.02 3.32
query30 0.25 0.09 0.07
query31 2.84 0.60 0.38
query32 3.22 0.55 0.47
query33 3.07 3.12 3.03
query34 15.82 5.14 4.52
query35 4.54 4.53 4.55
query36 0.68 0.50 0.48
query37 0.09 0.06 0.06
query38 0.05 0.03 0.04
query39 0.03 0.02 0.03
query40 0.16 0.14 0.13
query41 0.08 0.02 0.02
query42 0.03 0.02 0.03
query43 0.04 0.03 0.03
Total cold run time: 103.33 s
Total hot run time: 29.07 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2914786951
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/55a614327dd851a1d761d9f4e63865438c60e2f2_55a614327dd851a1d761d9f4e63865438c60e2f2_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/55a614327dd851a1d761d9f4e63865438c60e2f2_55a614327dd851a1d761d9f4e63865438c60e2f2_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.25% (1113/1337) |
| Line Coverage | 66.14% (18667/28224) |
| Region Coverage | 65.76% (9258/14079) |
| Branch Coverage | 55.58% (4983/8966) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "koarz (via GitHub)" <gi...@apache.org>.
koarz commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2902021489
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2918248739
<details>
<summary>TPC-DS: <b>Total hot run time: 185568 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 55a614327dd851a1d761d9f4e63865438c60e2f2, data reload: false
query1 1015 487 529 487
query2 6574 1927 1842 1842
query3 6746 227 224 224
query4 26306 23417 22990 22990
query5 4368 627 473 473
query6 290 213 193 193
query7 4626 492 300 300
query8 264 224 201 201
query9 8578 2624 2633 2624
query10 479 339 257 257
query11 15933 15054 14869 14869
query12 161 107 111 107
query13 1656 551 416 416
query14 8793 6207 6207 6207
query15 202 194 175 175
query16 7127 623 457 457
query17 916 708 608 608
query18 1966 396 281 281
query19 191 181 156 156
query20 119 115 118 115
query21 206 137 108 108
query22 4017 4067 3960 3960
query23 33695 33078 33063 33063
query24 8405 2360 2387 2360
query25 556 462 394 394
query26 1264 272 152 152
query27 2769 502 339 339
query28 4299 2133 2100 2100
query29 778 557 438 438
query30 281 206 187 187
query31 933 881 763 763
query32 76 65 68 65
query33 544 375 322 322
query34 783 855 536 536
query35 788 832 728 728
query36 950 972 885 885
query37 113 98 77 77
query38 4159 4070 4067 4067
query39 1487 1440 1419 1419
query40 215 116 114 114
query41 63 63 57 57
query42 133 116 111 111
query43 515 485 494 485
query44 1299 829 826 826
query45 181 173 165 165
query46 838 1019 634 634
query47 1745 1809 1730 1730
query48 396 424 315 315
query49 771 517 402 402
query50 650 686 395 395
query51 4067 4180 4129 4129
query52 126 111 109 109
query53 228 260 194 194
query54 590 580 516 516
query55 90 83 87 83
query56 323 340 301 301
query57 1132 1123 1057 1057
query58 283 266 271 266
query59 2664 2724 2617 2617
query60 336 337 308 308
query61 159 147 149 147
query62 789 746 676 676
query63 228 227 185 185
query64 4332 1000 674 674
query65 4302 4313 4235 4235
query66 1199 420 317 317
query67 15742 15531 15207 15207
query68 8623 881 527 527
query69 474 368 266 266
query70 1249 1110 1096 1096
query71 465 339 313 313
query72 5599 4681 4756 4681
query73 702 586 360 360
query74 8901 8870 8956 8870
query75 4074 3178 2685 2685
query76 3606 1200 757 757
query77 791 386 288 288
query78 10061 10268 9339 9339
query79 1848 814 617 617
query80 587 529 458 458
query81 463 249 221 221
query82 412 126 99 99
query83 249 248 235 235
query84 284 108 89 89
query85 773 346 315 315
query86 355 292 277 277
query87 4439 4387 4312 4312
query88 3347 2310 2301 2301
query89 390 318 276 276
query90 1861 201 204 201
query91 146 140 111 111
query92 73 59 58 58
query93 1167 909 580 580
query94 669 417 297 297
query95 362 326 292 292
query96 498 578 281 281
query97 2681 2733 2683 2683
query98 243 215 204 204
query99 1450 1410 1279 1279
Total cold run time: 272651 ms
Total hot run time: 185568 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](systable)add information_schema backend_configuration table [doris]
Posted by "wangbo (via GitHub)" <gi...@apache.org>.
wangbo commented on code in PR #51024:
URL: https://github.com/apache/doris/pull/51024#discussion_r2122540353
##########
be/src/exec/schema_scanner/schema_backend_configuration_scanner.cpp:
##########
@@ -0,0 +1,106 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "exec/schema_scanner/schema_backend_configuration_scanner.h"
+
+#include <gen_cpp/Descriptors_types.h>
+
+#include <string>
+
+#include "runtime/define_primitive_type.h"
+#include "runtime/exec_env.h"
+#include "runtime/runtime_state.h"
+#include "vec/common/string_ref.h"
+#include "vec/core/block.h"
+
+namespace doris {
+
+std::vector<SchemaScanner::ColumnDesc> SchemaBackendConfigurationScanner::_s_tbls_columns = {
+ // name, type, size, is_null
+ {"BE_ID", TYPE_BIGINT, sizeof(int64_t), true},
+ {"CONFIG_NAME", TYPE_STRING, sizeof(StringRef), true},
+ {"CONFIG_TYPE", TYPE_STRING, sizeof(StringRef), true},
+ {"CONFIG_VALUE", TYPE_STRING, sizeof(StringRef), true},
+ {"IS_MUTABLE", TYPE_BOOLEAN, sizeof(bool), true}};
+
+SchemaBackendConfigurationScanner::SchemaBackendConfigurationScanner()
+ : SchemaScanner(_s_tbls_columns, TSchemaTableType::SCH_BACKEND_CONFIGURATION),
+ _backend_id(ExecEnv::GetInstance()->cluster_info()->backend_id) {}
+
+SchemaBackendConfigurationScanner::~SchemaBackendConfigurationScanner() = default;
+
+Status SchemaBackendConfigurationScanner::start(doris::RuntimeState* state) {
+ _config_infos = config::get_config_info();
+ return Status::OK();
+}
+
+Status SchemaBackendConfigurationScanner::get_next_block_internal(vectorized::Block* block,
+ bool* eos) {
+ if (!_is_init) {
+ return Status::InternalError("Used before initialized.");
+ }
+
+ if (nullptr == block || nullptr == eos) {
+ return Status::InternalError("input pointer is nullptr.");
+ }
+
+ *eos = true;
+ if (_config_infos.empty()) {
+ return Status::OK();
+ }
+
+ for (size_t col_idx = 0; col_idx < _s_tbls_columns.size(); ++col_idx) {
+ size_t row_num = _config_infos.size();
+ std::vector<StringRef> str_refs(row_num);
+ std::vector<int64_t> bigint_vals(row_num);
+ std::vector<int8_t> bool_vals(row_num);
+ std::vector<void*> datas(row_num);
+ std::vector<std::string> column_values(row_num);
+
+ for (size_t row_idx = 0; row_idx < row_num; ++row_idx) {
+ // be_id
+ if (col_idx == 0) {
+ bigint_vals[row_idx] = _backend_id;
+ datas[row_idx] = &bigint_vals[row_idx];
Review Comment:
why not set ```datas[row_idx] = &_backend_id```, what's the meaning of bigint_vals
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](systable)add information_schema backend_configuration table [doris]
Posted by "koarz (via GitHub)" <gi...@apache.org>.
koarz commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2943316393
run feut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2902195787
<details>
<summary>TPC-H: <b>Total hot run time: 33694 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d9cf6412355168b952e51a963217135c71cf440b, data reload: false
------ Round 1 ----------------------------------
q1 26262 5157 4999 4999
q2 2070 285 184 184
q3 10531 1234 669 669
q4 10235 1011 520 520
q5 7673 2364 2296 2296
q6 180 163 131 131
q7 919 736 613 613
q8 9293 1276 1053 1053
q9 6729 5014 5028 5014
q10 6846 2337 1936 1936
q11 489 296 274 274
q12 350 348 210 210
q13 17808 3647 3084 3084
q14 234 236 212 212
q15 530 482 484 482
q16 445 440 370 370
q17 600 840 369 369
q18 7517 7182 7217 7182
q19 1744 950 550 550
q20 315 326 221 221
q21 3584 2615 2369 2369
q22 1039 1000 956 956
Total cold run time: 115393 ms
Total hot run time: 33694 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5199 5029 5072 5029
q2 242 327 234 234
q3 2160 2619 2341 2341
q4 1333 1761 1313 1313
q5 4433 4424 4407 4407
q6 215 165 131 131
q7 1994 1955 1768 1768
q8 2573 2513 2550 2513
q9 7256 7185 6998 6998
q10 3047 3211 2758 2758
q11 586 528 498 498
q12 667 806 625 625
q13 3515 3945 3337 3337
q14 276 328 292 292
q15 548 501 498 498
q16 441 466 433 433
q17 1150 1597 1356 1356
q18 7719 7625 7442 7442
q19 814 831 952 831
q20 1963 1958 1844 1844
q21 4864 4514 4398 4398
q22 1087 1042 1021 1021
Total cold run time: 52082 ms
Total hot run time: 50067 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2890009067
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/ccda11bc5acef592459b250cf4260da9b5e796da_ccda11bc5acef592459b250cf4260da9b5e796da_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/ccda11bc5acef592459b250cf4260da9b5e796da_ccda11bc5acef592459b250cf4260da9b5e796da_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.31% (1113/1336) |
| Line Coverage | 66.28% (18683/28187) |
| Region Coverage | 65.86% (9271/14076) |
| Branch Coverage | 55.63% (4987/8964) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2890829049
<details>
<summary>TPC-H: <b>Total hot run time: 33667 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit df74043e94f345f42d2fee58907a53efc81dbf80, data reload: false
------ Round 1 ----------------------------------
q1 26408 5049 4982 4982
q2 2067 277 182 182
q3 10562 1277 701 701
q4 10243 1025 512 512
q5 7792 2321 2323 2321
q6 174 164 130 130
q7 931 750 603 603
q8 9314 1288 991 991
q9 6767 5050 5112 5050
q10 6854 2310 1915 1915
q11 498 287 276 276
q12 352 349 218 218
q13 17791 3691 3074 3074
q14 225 226 217 217
q15 534 485 496 485
q16 427 433 368 368
q17 618 881 375 375
q18 7653 7272 7145 7145
q19 1560 953 567 567
q20 352 349 229 229
q21 4079 2601 2371 2371
q22 1036 1030 955 955
Total cold run time: 116237 ms
Total hot run time: 33667 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5116 5266 5093 5093
q2 241 324 227 227
q3 2170 2661 2291 2291
q4 1367 1826 1396 1396
q5 4473 4373 4368 4368
q6 218 174 125 125
q7 2048 1914 1748 1748
q8 2584 2465 2563 2465
q9 7307 7223 6875 6875
q10 2974 3202 2761 2761
q11 578 514 494 494
q12 678 774 590 590
q13 3470 3841 3287 3287
q14 283 292 268 268
q15 545 480 495 480
q16 435 480 460 460
q17 1185 1511 1389 1389
q18 7756 7606 7500 7500
q19 837 855 1018 855
q20 1986 2044 1921 1921
q21 4867 4541 4361 4361
q22 1080 1077 1026 1026
Total cold run time: 52198 ms
Total hot run time: 49980 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2910941671
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/2333609c75cbdf24c67a6e667a775c4796132a0d_2333609c75cbdf24c67a6e667a775c4796132a0d_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/2333609c75cbdf24c67a6e667a775c4796132a0d_2333609c75cbdf24c67a6e667a775c4796132a0d_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.25% (1113/1337) |
| Line Coverage | 66.12% (18662/28224) |
| Region Coverage | 65.74% (9256/14079) |
| Branch Coverage | 55.60% (4985/8966) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2911064119
<details>
<summary>ClickBench: <b>Total hot run time: 28.86 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2333609c75cbdf24c67a6e667a775c4796132a0d, data reload: false
query1 0.03 0.04 0.03
query2 0.13 0.12 0.11
query3 0.27 0.19 0.21
query4 1.59 0.20 0.10
query5 0.43 0.40 0.41
query6 1.14 0.65 0.68
query7 0.03 0.02 0.02
query8 0.04 0.04 0.03
query9 0.58 0.51 0.52
query10 0.56 0.58 0.57
query11 0.16 0.10 0.11
query12 0.16 0.12 0.12
query13 0.62 0.59 0.60
query14 0.80 0.80 0.80
query15 0.86 0.86 0.86
query16 0.41 0.40 0.40
query17 1.04 1.08 1.03
query18 0.23 0.22 0.21
query19 1.90 1.82 1.84
query20 0.01 0.01 0.01
query21 15.43 0.93 0.56
query22 0.74 1.15 0.63
query23 15.01 1.40 0.62
query24 7.38 1.89 0.59
query25 0.49 0.31 0.07
query26 0.50 0.17 0.15
query27 0.06 0.06 0.05
query28 8.92 0.86 0.44
query29 12.95 4.10 3.40
query30 0.27 0.09 0.07
query31 2.83 0.63 0.39
query32 3.22 0.55 0.47
query33 3.03 3.05 3.09
query34 15.85 5.17 4.52
query35 4.53 4.54 4.49
query36 0.67 0.50 0.48
query37 0.09 0.06 0.07
query38 0.06 0.04 0.04
query39 0.04 0.03 0.03
query40 0.17 0.13 0.13
query41 0.08 0.03 0.02
query42 0.03 0.03 0.02
query43 0.04 0.04 0.03
Total cold run time: 103.38 s
Total hot run time: 28.86 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "koarz (via GitHub)" <gi...@apache.org>.
koarz commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2903049100
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2901212264
<details>
<summary>TPC-H: <b>Total hot run time: 34660 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0b8024bdbb8aa062fb22bfdd40feb9bf757b6dbe, data reload: false
------ Round 1 ----------------------------------
q1 26100 5125 5089 5089
q2 2084 276 194 194
q3 10492 1271 720 720
q4 10249 1029 513 513
q5 7651 2433 2346 2346
q6 190 169 137 137
q7 927 744 609 609
q8 9343 1304 1122 1122
q9 6797 5068 5135 5068
q10 6855 2288 1882 1882
q11 493 302 285 285
q12 356 362 217 217
q13 17772 3708 3075 3075
q14 229 227 213 213
q15 564 503 504 503
q16 428 428 374 374
q17 620 875 369 369
q18 7743 7361 7133 7133
q19 1989 992 562 562
q20 351 337 225 225
q21 4270 3218 3068 3068
q22 1049 1020 956 956
Total cold run time: 116552 ms
Total hot run time: 34660 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5245 5250 5365 5250
q2 240 326 226 226
q3 2179 2733 2286 2286
q4 1366 1912 1499 1499
q5 4589 4458 4433 4433
q6 218 169 130 130
q7 2003 1957 1762 1762
q8 2671 2580 2528 2528
q9 7114 7228 7007 7007
q10 3012 3197 2733 2733
q11 580 526 502 502
q12 715 773 650 650
q13 3521 4004 3274 3274
q14 273 307 277 277
q15 548 493 484 484
q16 456 522 450 450
q17 1162 1603 1374 1374
q18 7701 7734 7443 7443
q19 825 818 855 818
q20 2009 2030 1844 1844
q21 4889 4383 4337 4337
q22 1067 1019 1000 1000
Total cold run time: 52383 ms
Total hot run time: 50307 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "koarz (via GitHub)" <gi...@apache.org>.
koarz commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2903732237
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2914981554
<details>
<summary>TPC-H: <b>Total hot run time: 33718 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 55a614327dd851a1d761d9f4e63865438c60e2f2, data reload: false
------ Round 1 ----------------------------------
q1 26111 5130 5045 5045
q2 2080 282 183 183
q3 10533 1256 674 674
q4 10226 980 529 529
q5 7650 2284 2393 2284
q6 181 169 132 132
q7 899 745 605 605
q8 9318 1301 1054 1054
q9 6843 5103 5041 5041
q10 6880 2288 1907 1907
q11 504 294 272 272
q12 347 356 210 210
q13 17807 3719 3056 3056
q14 231 232 221 221
q15 527 485 500 485
q16 432 434 378 378
q17 605 863 379 379
q18 7801 7163 7205 7163
q19 1780 969 565 565
q20 345 335 228 228
q21 3715 2571 2337 2337
q22 1036 1046 970 970
Total cold run time: 115851 ms
Total hot run time: 33718 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5154 5105 5075 5075
q2 237 329 235 235
q3 2212 2726 2336 2336
q4 1363 1756 1319 1319
q5 4456 4389 4449 4389
q6 225 170 128 128
q7 2022 1975 1776 1776
q8 2615 2561 2599 2561
q9 7235 7253 7056 7056
q10 3007 3220 2762 2762
q11 590 512 492 492
q12 682 785 656 656
q13 3525 3897 3305 3305
q14 302 317 262 262
q15 521 478 476 476
q16 440 497 469 469
q17 1172 1599 1373 1373
q18 7775 7657 7407 7407
q19 807 820 796 796
q20 1994 2018 1874 1874
q21 5021 4560 4508 4508
q22 1128 1042 1004 1004
Total cold run time: 52483 ms
Total hot run time: 50259 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "koarz (via GitHub)" <gi...@apache.org>.
koarz commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2890120839
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2890516140
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/df74043e94f345f42d2fee58907a53efc81dbf80_df74043e94f345f42d2fee58907a53efc81dbf80_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/df74043e94f345f42d2fee58907a53efc81dbf80_df74043e94f345f42d2fee58907a53efc81dbf80_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.31% (1113/1336) |
| Line Coverage | 66.26% (18677/28187) |
| Region Coverage | 65.81% (9264/14076) |
| Branch Coverage | 55.67% (4990/8964) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2900934628
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/0b8024bdbb8aa062fb22bfdd40feb9bf757b6dbe_0b8024bdbb8aa062fb22bfdd40feb9bf757b6dbe_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/0b8024bdbb8aa062fb22bfdd40feb9bf757b6dbe_0b8024bdbb8aa062fb22bfdd40feb9bf757b6dbe_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.25% (1113/1337) |
| Line Coverage | 66.15% (18669/28223) |
| Region Coverage | 65.82% (9265/14077) |
| Branch Coverage | 55.60% (4984/8964) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2902223756
<details>
<summary>TPC-DS: <b>Total hot run time: 190760 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d9cf6412355168b952e51a963217135c71cf440b, data reload: false
query1 1412 1091 1057 1057
query2 6299 1849 1883 1849
query3 11020 4548 4577 4548
query4 57095 25332 22928 22928
query5 5029 490 486 486
query6 352 208 206 206
query7 4974 516 296 296
query8 327 264 248 248
query9 6202 2659 2671 2659
query10 424 323 280 280
query11 15047 15049 14787 14787
query12 162 109 106 106
query13 1078 530 396 396
query14 10363 6433 6361 6361
query15 223 219 187 187
query16 7147 633 487 487
query17 1070 725 616 616
query18 1581 413 305 305
query19 204 191 175 175
query20 132 125 122 122
query21 208 133 111 111
query22 4271 4483 4330 4330
query23 34543 33522 33597 33522
query24 5985 2467 2497 2467
query25 480 481 422 422
query26 690 280 162 162
query27 2327 522 362 362
query28 2904 2194 2209 2194
query29 627 588 502 502
query30 286 233 200 200
query31 903 903 817 817
query32 83 68 66 66
query33 486 388 339 339
query34 805 863 563 563
query35 795 838 765 765
query36 981 1002 923 923
query37 119 111 79 79
query38 4207 4325 4274 4274
query39 1554 1452 1456 1452
query40 227 125 114 114
query41 70 61 62 61
query42 133 154 118 118
query43 516 514 493 493
query44 1341 841 850 841
query45 177 178 173 173
query46 866 1054 667 667
query47 1841 1883 1780 1780
query48 418 434 340 340
query49 705 537 437 437
query50 675 700 417 417
query51 4306 4346 4225 4225
query52 114 114 102 102
query53 253 276 193 193
query54 616 609 536 536
query55 87 86 88 86
query56 357 311 291 291
query57 1192 1194 1142 1142
query58 278 266 280 266
query59 2684 2831 2666 2666
query60 347 346 319 319
query61 125 126 123 123
query62 729 745 677 677
query63 243 201 192 192
query64 1508 1022 705 705
query65 4350 4265 4249 4249
query66 697 404 319 319
query67 15692 15689 15418 15418
query68 7848 898 522 522
query69 555 315 267 267
query70 1183 1114 1080 1080
query71 511 331 282 282
query72 5531 2418 5121 2418
query73 1383 779 357 357
query74 8977 8874 9068 8874
query75 3741 3215 2723 2723
query76 4240 1217 796 796
query77 611 386 296 296
query78 10202 10050 9316 9316
query79 4832 808 576 576
query80 816 510 529 510
query81 497 269 217 217
query82 660 132 94 94
query83 346 245 230 230
query84 292 108 83 83
query85 782 358 308 308
query86 414 309 287 287
query87 4408 4415 4312 4312
query88 3799 2338 2301 2301
query89 447 324 297 297
query90 1749 214 220 214
query91 142 191 119 119
query92 73 61 60 60
query93 3271 945 575 575
query94 666 411 307 307
query95 379 299 284 284
query96 496 578 285 285
query97 2700 2784 2636 2636
query98 233 218 211 211
query99 1445 1373 1324 1324
Total cold run time: 306171 ms
Total hot run time: 190760 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2908525535
<details>
<summary>TPC-DS: <b>Total hot run time: 186012 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2333609c75cbdf24c67a6e667a775c4796132a0d, data reload: false
query1 1014 482 507 482
query2 6571 1833 1823 1823
query3 6754 226 226 226
query4 26329 23891 23342 23342
query5 4350 622 471 471
query6 326 227 211 211
query7 4627 499 291 291
query8 306 271 247 247
query9 8626 2604 2637 2604
query10 500 340 270 270
query11 15439 15030 14836 14836
query12 161 107 104 104
query13 1661 539 419 419
query14 8917 6198 6230 6198
query15 209 191 188 188
query16 7260 630 456 456
query17 1227 734 595 595
query18 1991 415 298 298
query19 192 189 165 165
query20 141 119 112 112
query21 213 124 108 108
query22 4156 4486 4001 4001
query23 34055 33001 32986 32986
query24 8174 2432 2408 2408
query25 536 455 406 406
query26 1229 268 162 162
query27 2704 488 340 340
query28 4346 2106 2085 2085
query29 804 566 437 437
query30 291 220 179 179
query31 919 858 740 740
query32 69 62 60 60
query33 567 379 325 325
query34 790 850 511 511
query35 809 809 709 709
query36 954 983 892 892
query37 111 100 80 80
query38 4080 4160 4016 4016
query39 1499 1406 1420 1406
query40 213 120 106 106
query41 57 55 56 55
query42 130 107 117 107
query43 506 519 464 464
query44 1344 820 821 820
query45 178 174 165 165
query46 858 1030 639 639
query47 1766 1810 1691 1691
query48 384 431 306 306
query49 780 515 451 451
query50 643 679 400 400
query51 4126 4217 4102 4102
query52 112 106 97 97
query53 227 250 188 188
query54 589 578 502 502
query55 87 82 87 82
query56 311 305 293 293
query57 1141 1159 1112 1112
query58 270 259 263 259
query59 2619 2689 2654 2654
query60 343 323 319 319
query61 130 165 123 123
query62 829 757 654 654
query63 226 190 191 190
query64 4358 1009 719 719
query65 4379 4215 4233 4215
query66 1157 439 315 315
query67 15924 15545 15574 15545
query68 8093 903 521 521
query69 477 304 267 267
query70 1168 1126 1075 1075
query71 454 325 329 325
query72 5754 4747 4838 4747
query73 728 647 357 357
query74 9168 9091 8604 8604
query75 3834 3191 2696 2696
query76 3674 1192 759 759
query77 795 396 286 286
query78 10103 10231 9426 9426
query79 2106 817 572 572
query80 586 506 457 457
query81 476 259 288 259
query82 499 127 93 93
query83 255 258 236 236
query84 246 106 86 86
query85 779 360 312 312
query86 355 326 278 278
query87 4418 4491 4360 4360
query88 3266 2272 2272 2272
query89 391 321 284 284
query90 1925 221 203 203
query91 146 149 113 113
query92 74 65 58 58
query93 1451 949 574 574
query94 667 475 302 302
query95 372 292 304 292
query96 497 583 277 277
query97 2691 2750 2639 2639
query98 234 210 210 210
query99 1465 1389 1310 1310
Total cold run time: 273741 ms
Total hot run time: 186012 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "koarz (via GitHub)" <gi...@apache.org>.
koarz commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2890467857
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2911057926
<details>
<summary>TPC-DS: <b>Total hot run time: 186581 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2333609c75cbdf24c67a6e667a775c4796132a0d, data reload: false
query1 1011 515 522 515
query2 6555 1873 1858 1858
query3 6760 232 223 223
query4 26245 23910 23396 23396
query5 4391 646 470 470
query6 316 209 198 198
query7 4620 501 315 315
query8 298 249 245 245
query9 8635 2626 2629 2626
query10 459 328 277 277
query11 15768 15203 14872 14872
query12 176 107 107 107
query13 1655 541 408 408
query14 10509 6168 6191 6168
query15 251 195 173 173
query16 7636 625 488 488
query17 1172 695 564 564
query18 2000 391 292 292
query19 190 186 160 160
query20 123 123 132 123
query21 215 128 135 128
query22 4083 4095 3952 3952
query23 33987 33169 33134 33134
query24 7851 2389 2416 2389
query25 545 456 400 400
query26 1236 264 153 153
query27 2666 482 345 345
query28 4335 2135 2100 2100
query29 743 570 480 480
query30 287 223 187 187
query31 950 872 755 755
query32 74 63 62 62
query33 550 368 316 316
query34 820 840 549 549
query35 773 810 739 739
query36 942 986 897 897
query37 113 106 86 86
query38 4142 4056 4106 4056
query39 1484 1436 1396 1396
query40 214 120 106 106
query41 57 58 57 57
query42 133 112 105 105
query43 528 513 501 501
query44 1323 817 817 817
query45 176 185 168 168
query46 892 1039 641 641
query47 1739 1790 1697 1697
query48 393 419 314 314
query49 760 526 421 421
query50 648 676 394 394
query51 4186 4355 4186 4186
query52 123 116 99 99
query53 225 256 185 185
query54 572 594 520 520
query55 88 83 92 83
query56 313 330 310 310
query57 1145 1166 1063 1063
query58 264 264 253 253
query59 2622 2652 2644 2644
query60 342 323 331 323
query61 124 120 124 120
query62 783 704 670 670
query63 221 190 180 180
query64 4252 1029 660 660
query65 4317 4215 4278 4215
query66 1065 404 314 314
query67 15695 15607 15379 15379
query68 7531 876 527 527
query69 474 311 265 265
query70 1208 1128 1143 1128
query71 413 317 315 315
query72 5284 4699 4709 4699
query73 637 584 352 352
query74 9238 8825 8841 8825
query75 3194 3186 2711 2711
query76 3231 1188 758 758
query77 494 367 301 301
query78 9835 10151 9356 9356
query79 1467 809 584 584
query80 610 559 481 481
query81 504 329 218 218
query82 177 123 105 105
query83 261 261 233 233
query84 257 108 94 94
query85 773 351 311 311
query86 377 295 297 295
query87 4453 4511 4409 4409
query88 2997 2314 2312 2312
query89 389 320 282 282
query90 1863 218 204 204
query91 144 141 114 114
query92 73 64 59 59
query93 1121 937 593 593
query94 671 408 313 313
query95 459 295 283 283
query96 506 556 287 287
query97 2729 2775 2671 2671
query98 219 210 206 206
query99 1342 1393 1263 1263
Total cold run time: 270697 ms
Total hot run time: 186581 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2902235340
<details>
<summary>ClickBench: <b>Total hot run time: 29.78 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d9cf6412355168b952e51a963217135c71cf440b, data reload: false
query1 0.03 0.04 0.03
query2 0.15 0.11 0.10
query3 0.35 0.20 0.20
query4 1.60 0.20 0.20
query5 0.46 0.45 0.45
query6 1.16 0.66 0.66
query7 0.02 0.02 0.02
query8 0.06 0.05 0.04
query9 0.63 0.52 0.52
query10 0.57 0.58 0.56
query11 0.27 0.13 0.13
query12 0.25 0.13 0.14
query13 0.63 0.62 0.62
query14 0.81 0.81 0.83
query15 0.95 0.89 0.87
query16 0.37 0.36 0.36
query17 1.06 1.02 1.04
query18 0.18 0.18 0.18
query19 1.99 1.86 1.87
query20 0.01 0.02 0.02
query21 15.41 0.97 0.67
query22 0.93 1.05 0.83
query23 14.68 1.55 0.76
query24 5.34 0.61 0.30
query25 0.17 0.10 0.09
query26 0.55 0.23 0.18
query27 0.09 0.09 0.09
query28 11.03 1.14 0.57
query29 12.51 4.10 3.44
query30 0.28 0.08 0.07
query31 2.82 0.61 0.42
query32 3.22 0.60 0.50
query33 3.12 3.15 3.10
query34 16.53 5.18 4.41
query35 4.49 4.45 4.42
query36 0.64 0.50 0.49
query37 0.20 0.18 0.17
query38 0.16 0.17 0.15
query39 0.05 0.04 0.05
query40 0.20 0.16 0.17
query41 0.11 0.06 0.05
query42 0.08 0.05 0.04
query43 0.05 0.05 0.05
Total cold run time: 104.21 s
Total hot run time: 29.78 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2919119461
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2903242917
<details>
<summary>ClickBench: <b>Total hot run time: 29.6 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 991022d92b1c9a0ccddf71a4d1718dded758018e, data reload: false
query1 0.04 0.04 0.03
query2 0.14 0.11 0.10
query3 0.36 0.20 0.20
query4 1.60 0.21 0.08
query5 0.42 0.41 0.40
query6 1.17 0.65 0.66
query7 0.03 0.01 0.01
query8 0.06 0.05 0.05
query9 0.64 0.51 0.53
query10 0.58 0.58 0.57
query11 0.25 0.13 0.13
query12 0.24 0.13 0.13
query13 0.64 0.62 0.62
query14 0.81 0.83 0.82
query15 0.96 0.89 0.87
query16 0.39 0.37 0.37
query17 1.06 1.08 1.06
query18 0.20 0.18 0.18
query19 2.00 1.90 1.88
query20 0.01 0.02 0.01
query21 15.40 0.96 0.66
query22 0.94 1.05 0.79
query23 14.70 1.51 0.78
query24 5.34 0.57 0.29
query25 0.16 0.09 0.08
query26 0.56 0.22 0.18
query27 0.08 0.08 0.08
query28 11.05 1.22 0.60
query29 12.52 4.12 3.39
query30 0.29 0.09 0.06
query31 2.82 0.62 0.44
query32 3.24 0.59 0.51
query33 3.05 3.14 3.21
query34 16.50 5.13 4.38
query35 4.43 4.48 4.43
query36 0.64 0.50 0.49
query37 0.20 0.17 0.16
query38 0.17 0.15 0.14
query39 0.05 0.05 0.04
query40 0.20 0.16 0.14
query41 0.11 0.05 0.05
query42 0.06 0.05 0.05
query43 0.06 0.05 0.05
Total cold run time: 104.17 s
Total hot run time: 29.6 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](systable)add information_schema backend_configuration table [doris]
Posted by "wangbo (via GitHub)" <gi...@apache.org>.
wangbo commented on code in PR #51024:
URL: https://github.com/apache/doris/pull/51024#discussion_r2122542717
##########
be/src/exec/schema_scanner/schema_backend_configuration_scanner.cpp:
##########
@@ -0,0 +1,106 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "exec/schema_scanner/schema_backend_configuration_scanner.h"
+
+#include <gen_cpp/Descriptors_types.h>
+
+#include <string>
+
+#include "runtime/define_primitive_type.h"
+#include "runtime/exec_env.h"
+#include "runtime/runtime_state.h"
+#include "vec/common/string_ref.h"
+#include "vec/core/block.h"
+
+namespace doris {
+
+std::vector<SchemaScanner::ColumnDesc> SchemaBackendConfigurationScanner::_s_tbls_columns = {
+ // name, type, size, is_null
+ {"BE_ID", TYPE_BIGINT, sizeof(int64_t), true},
+ {"CONFIG_NAME", TYPE_STRING, sizeof(StringRef), true},
+ {"CONFIG_TYPE", TYPE_STRING, sizeof(StringRef), true},
+ {"CONFIG_VALUE", TYPE_STRING, sizeof(StringRef), true},
+ {"IS_MUTABLE", TYPE_BOOLEAN, sizeof(bool), true}};
+
+SchemaBackendConfigurationScanner::SchemaBackendConfigurationScanner()
+ : SchemaScanner(_s_tbls_columns, TSchemaTableType::SCH_BACKEND_CONFIGURATION),
+ _backend_id(ExecEnv::GetInstance()->cluster_info()->backend_id) {}
+
+SchemaBackendConfigurationScanner::~SchemaBackendConfigurationScanner() = default;
+
+Status SchemaBackendConfigurationScanner::start(doris::RuntimeState* state) {
+ _config_infos = config::get_config_info();
+ return Status::OK();
+}
+
+Status SchemaBackendConfigurationScanner::get_next_block_internal(vectorized::Block* block,
+ bool* eos) {
+ if (!_is_init) {
+ return Status::InternalError("Used before initialized.");
+ }
+
+ if (nullptr == block || nullptr == eos) {
+ return Status::InternalError("input pointer is nullptr.");
+ }
+
+ *eos = true;
+ if (_config_infos.empty()) {
+ return Status::OK();
+ }
+
+ for (size_t col_idx = 0; col_idx < _s_tbls_columns.size(); ++col_idx) {
+ size_t row_num = _config_infos.size();
+ std::vector<StringRef> str_refs(row_num);
+ std::vector<int64_t> bigint_vals(row_num);
+ std::vector<int8_t> bool_vals(row_num);
+ std::vector<void*> datas(row_num);
+ std::vector<std::string> column_values(row_num);
+
+ for (size_t row_idx = 0; row_idx < row_num; ++row_idx) {
+ // be_id
+ if (col_idx == 0) {
+ bigint_vals[row_idx] = _backend_id;
+ datas[row_idx] = &bigint_vals[row_idx];
+ } else {
+ // config
+ const auto& row = _config_infos[row_idx];
+ if (row.size() != _s_tbls_columns.size() - 1) {
+ return Status::InternalError(
+ "backend configs info meet invalid schema, schema_size={}, "
+ "input_data_size={}",
+ _config_infos.size(), row.size());
+ }
+
+ std::string& column_value =
+ column_values[row_idx]; // Reference to the actual string in the vector
+ column_value = row[col_idx - 1];
+ if (_s_tbls_columns[col_idx].type == TYPE_BOOLEAN) {
+ bool_vals[row_idx] = column_value == "true" ? 1 : 0;
+ datas[row_idx] = &bool_vals[row_idx];
+ } else {
+ str_refs[row_idx] =
+ StringRef(column_values[row_idx].data(), column_values[row_idx].size());
+ datas[row_idx] = &str_refs[row_idx];
Review Comment:
str_refs should be destructed after ```for loop``` ends, but datas holds str_refs's ptr and datas is vistited out of the ```for loop``` in line 102, why it not cores here, bool_vals has the same problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2902073720
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/d9cf6412355168b952e51a963217135c71cf440b_d9cf6412355168b952e51a963217135c71cf440b_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/d9cf6412355168b952e51a963217135c71cf440b_d9cf6412355168b952e51a963217135c71cf440b_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.25% (1113/1337) |
| Line Coverage | 66.17% (18675/28223) |
| Region Coverage | 65.84% (9268/14077) |
| Branch Coverage | 55.60% (4984/8964) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2901249408
<details>
<summary>TPC-DS: <b>Total hot run time: 186868 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0b8024bdbb8aa062fb22bfdd40feb9bf757b6dbe, data reload: false
query1 1013 500 530 500
query2 6553 1890 1887 1887
query3 6736 222 227 222
query4 26522 23952 23399 23399
query5 4313 625 473 473
query6 291 205 185 185
query7 4617 506 288 288
query8 292 255 246 246
query9 8603 2637 2619 2619
query10 448 345 282 282
query11 15562 14997 14896 14896
query12 161 118 113 113
query13 1653 539 397 397
query14 8719 6341 6281 6281
query15 218 200 177 177
query16 7127 680 494 494
query17 952 719 585 585
query18 1995 397 301 301
query19 187 184 159 159
query20 121 113 123 113
query21 213 120 106 106
query22 4237 4120 3992 3992
query23 34013 33082 33140 33082
query24 8415 2386 2437 2386
query25 534 453 403 403
query26 1250 270 150 150
query27 2760 498 335 335
query28 4373 2146 2122 2122
query29 814 550 432 432
query30 273 211 186 186
query31 908 867 791 791
query32 82 68 72 68
query33 562 371 314 314
query34 817 863 533 533
query35 789 816 727 727
query36 974 1007 908 908
query37 115 101 79 79
query38 4116 4114 4035 4035
query39 1499 1406 1409 1406
query40 218 132 112 112
query41 57 55 55 55
query42 126 109 117 109
query43 532 537 499 499
query44 1359 818 818 818
query45 178 175 183 175
query46 856 1056 641 641
query47 1760 1795 1693 1693
query48 388 440 322 322
query49 785 523 426 426
query50 667 674 409 409
query51 4146 4139 4079 4079
query52 116 109 104 104
query53 223 251 191 191
query54 588 583 514 514
query55 89 82 84 82
query56 322 297 283 283
query57 1127 1162 1136 1136
query58 271 254 249 249
query59 2678 2733 2616 2616
query60 349 331 304 304
query61 152 141 124 124
query62 774 734 672 672
query63 236 196 195 195
query64 4389 1013 678 678
query65 4342 4256 4261 4256
query66 1237 431 326 326
query67 15856 15571 15533 15533
query68 5269 910 528 528
query69 491 314 270 270
query70 1228 1148 1112 1112
query71 434 324 293 293
query72 5637 4768 4785 4768
query73 671 619 349 349
query74 9027 9209 9035 9035
query75 3188 3228 2692 2692
query76 3176 1204 753 753
query77 483 389 292 292
query78 9936 10085 9272 9272
query79 1868 833 589 589
query80 637 552 458 458
query81 498 264 226 226
query82 178 128 101 101
query83 283 259 247 247
query84 372 108 88 88
query85 755 357 309 309
query86 375 307 295 295
query87 4433 4444 4342 4342
query88 2919 2265 2302 2265
query89 386 318 292 292
query90 1825 220 218 218
query91 143 145 114 114
query92 66 61 56 56
query93 1134 949 592 592
query94 624 419 377 377
query95 371 297 287 287
query96 511 564 282 282
query97 2667 2739 2620 2620
query98 229 235 205 205
query99 1352 1400 1268 1268
Total cold run time: 267814 ms
Total hot run time: 186868 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "koarz (via GitHub)" <gi...@apache.org>.
koarz commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2908354826
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2908508586
<details>
<summary>TPC-H: <b>Total hot run time: 33750 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2333609c75cbdf24c67a6e667a775c4796132a0d, data reload: false
------ Round 1 ----------------------------------
q1 26389 5090 5008 5008
q2 2072 293 191 191
q3 10520 1260 702 702
q4 10229 988 524 524
q5 7732 2363 2364 2363
q6 180 161 131 131
q7 902 722 599 599
q8 9306 1314 1096 1096
q9 6818 5160 5189 5160
q10 6867 2288 1903 1903
q11 498 288 282 282
q12 349 353 209 209
q13 17802 3694 3058 3058
q14 233 242 218 218
q15 541 497 485 485
q16 421 440 379 379
q17 615 865 359 359
q18 7782 7332 7041 7041
q19 2102 953 537 537
q20 330 339 221 221
q21 3816 2544 2344 2344
q22 1064 1041 940 940
Total cold run time: 116568 ms
Total hot run time: 33750 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5210 5117 5109 5109
q2 245 321 234 234
q3 2176 2682 2319 2319
q4 1367 1787 1344 1344
q5 4573 4493 4383 4383
q6 256 167 125 125
q7 1925 1933 1760 1760
q8 2602 2605 2559 2559
q9 7222 7121 7258 7121
q10 3046 3168 2772 2772
q11 594 510 502 502
q12 685 755 629 629
q13 3481 3823 3221 3221
q14 284 299 278 278
q15 526 469 477 469
q16 451 503 450 450
q17 1168 1570 1403 1403
q18 7746 7475 7345 7345
q19 818 809 1034 809
q20 2003 2029 1878 1878
q21 4927 4411 4303 4303
q22 1067 1022 1004 1004
Total cold run time: 52372 ms
Total hot run time: 50017 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2915005521
<details>
<summary>TPC-DS: <b>Total hot run time: 194066 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 55a614327dd851a1d761d9f4e63865438c60e2f2, data reload: false
query1 1413 1102 1093 1093
query2 6248 1841 1790 1790
query3 11079 4671 4599 4599
query4 54627 24475 23689 23689
query5 5166 544 475 475
query6 351 211 189 189
query7 4992 521 289 289
query8 327 249 241 241
query9 6145 2642 2632 2632
query10 455 323 279 279
query11 15102 15085 14928 14928
query12 170 118 106 106
query13 1119 531 395 395
query14 10185 6511 6588 6511
query15 212 207 189 189
query16 7103 686 530 530
query17 1060 744 598 598
query18 1552 393 309 309
query19 202 193 169 169
query20 138 132 119 119
query21 206 137 114 114
query22 4267 4316 4402 4316
query23 34564 33779 33519 33519
query24 6562 2426 2453 2426
query25 463 467 411 411
query26 685 275 153 153
query27 2267 509 367 367
query28 3015 2163 2152 2152
query29 582 573 443 443
query30 273 223 192 192
query31 863 821 790 790
query32 101 69 70 69
query33 448 357 329 329
query34 790 909 558 558
query35 817 845 759 759
query36 989 1019 917 917
query37 115 107 79 79
query38 4220 4208 4262 4208
query39 1535 1481 1479 1479
query40 220 120 110 110
query41 61 60 55 55
query42 132 109 108 108
query43 516 498 493 493
query44 1357 850 866 850
query45 181 177 169 169
query46 871 1060 661 661
query47 1815 1865 1772 1772
query48 400 447 320 320
query49 705 514 447 447
query50 689 712 423 423
query51 4195 4273 4240 4240
query52 119 117 104 104
query53 229 281 194 194
query54 604 605 523 523
query55 90 89 84 84
query56 346 304 299 299
query57 1197 1193 1093 1093
query58 276 273 268 268
query59 2687 2782 2589 2589
query60 344 340 340 340
query61 150 150 152 150
query62 758 745 678 678
query63 239 205 206 205
query64 1588 1084 703 703
query65 4310 4227 4245 4227
query66 737 402 297 297
query67 15806 15718 15517 15517
query68 7034 899 516 516
query69 539 297 278 278
query70 1234 1154 1091 1091
query71 498 327 320 320
query72 5992 4851 4829 4829
query73 1361 621 356 356
query74 8953 9338 8945 8945
query75 3869 3213 2682 2682
query76 4244 1190 762 762
query77 628 383 307 307
query78 10174 10209 9427 9427
query79 2544 826 600 600
query80 667 531 454 454
query81 557 255 221 221
query82 432 134 103 103
query83 372 258 246 246
query84 296 103 83 83
query85 801 378 319 319
query86 388 301 259 259
query87 4420 4484 4364 4364
query88 3434 2306 2276 2276
query89 406 313 293 293
query90 1786 217 218 217
query91 141 148 112 112
query92 79 64 59 59
query93 2079 946 581 581
query94 681 409 304 304
query95 371 301 289 289
query96 498 640 293 293
query97 2750 2756 2660 2660
query98 249 212 196 196
query99 1444 1401 1294 1294
Total cold run time: 299951 ms
Total hot run time: 194066 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "koarz (via GitHub)" <gi...@apache.org>.
koarz commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2910906811
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](systable)add information_schema backend_configuration table [doris]
Posted by "koarz (via GitHub)" <gi...@apache.org>.
koarz commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2933266171
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](systable)add information_schema backend_configuration table [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #51024:
URL: https://github.com/apache/doris/pull/51024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "koarz (via GitHub)" <gi...@apache.org>.
koarz commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2900894509
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2903207321
<details>
<summary>TPC-H: <b>Total hot run time: 33545 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 991022d92b1c9a0ccddf71a4d1718dded758018e, data reload: false
------ Round 1 ----------------------------------
q1 26316 5056 4993 4993
q2 2075 285 193 193
q3 10482 1243 679 679
q4 10237 1005 516 516
q5 7648 2370 2362 2362
q6 179 160 130 130
q7 917 737 630 630
q8 9320 1286 1022 1022
q9 6770 5092 5022 5022
q10 6863 2317 1901 1901
q11 499 287 269 269
q12 347 346 213 213
q13 17774 3655 3048 3048
q14 228 238 211 211
q15 536 482 478 478
q16 436 430 381 381
q17 596 860 380 380
q18 7562 7150 7027 7027
q19 1669 974 549 549
q20 340 325 222 222
q21 3824 2577 2313 2313
q22 1028 1025 1006 1006
Total cold run time: 115646 ms
Total hot run time: 33545 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5185 5096 5089 5089
q2 234 323 224 224
q3 2162 2650 2295 2295
q4 1325 1786 1327 1327
q5 4407 4423 4437 4423
q6 214 177 133 133
q7 2011 1928 1804 1804
q8 2602 2545 2495 2495
q9 7228 7203 6892 6892
q10 3059 3192 2767 2767
q11 585 506 508 506
q12 686 757 597 597
q13 3517 3886 3345 3345
q14 308 287 272 272
q15 544 483 489 483
q16 456 490 440 440
q17 1137 1522 1394 1394
q18 7770 7556 7453 7453
q19 823 760 849 760
q20 1998 2084 1880 1880
q21 4684 4420 4395 4395
q22 1121 1038 1025 1025
Total cold run time: 52056 ms
Total hot run time: 49999 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](systable)add information_schema backend_configuration table [doris]
Posted by "wangbo (via GitHub)" <gi...@apache.org>.
wangbo commented on code in PR #51024:
URL: https://github.com/apache/doris/pull/51024#discussion_r2122542717
##########
be/src/exec/schema_scanner/schema_backend_configuration_scanner.cpp:
##########
@@ -0,0 +1,106 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "exec/schema_scanner/schema_backend_configuration_scanner.h"
+
+#include <gen_cpp/Descriptors_types.h>
+
+#include <string>
+
+#include "runtime/define_primitive_type.h"
+#include "runtime/exec_env.h"
+#include "runtime/runtime_state.h"
+#include "vec/common/string_ref.h"
+#include "vec/core/block.h"
+
+namespace doris {
+
+std::vector<SchemaScanner::ColumnDesc> SchemaBackendConfigurationScanner::_s_tbls_columns = {
+ // name, type, size, is_null
+ {"BE_ID", TYPE_BIGINT, sizeof(int64_t), true},
+ {"CONFIG_NAME", TYPE_STRING, sizeof(StringRef), true},
+ {"CONFIG_TYPE", TYPE_STRING, sizeof(StringRef), true},
+ {"CONFIG_VALUE", TYPE_STRING, sizeof(StringRef), true},
+ {"IS_MUTABLE", TYPE_BOOLEAN, sizeof(bool), true}};
+
+SchemaBackendConfigurationScanner::SchemaBackendConfigurationScanner()
+ : SchemaScanner(_s_tbls_columns, TSchemaTableType::SCH_BACKEND_CONFIGURATION),
+ _backend_id(ExecEnv::GetInstance()->cluster_info()->backend_id) {}
+
+SchemaBackendConfigurationScanner::~SchemaBackendConfigurationScanner() = default;
+
+Status SchemaBackendConfigurationScanner::start(doris::RuntimeState* state) {
+ _config_infos = config::get_config_info();
+ return Status::OK();
+}
+
+Status SchemaBackendConfigurationScanner::get_next_block_internal(vectorized::Block* block,
+ bool* eos) {
+ if (!_is_init) {
+ return Status::InternalError("Used before initialized.");
+ }
+
+ if (nullptr == block || nullptr == eos) {
+ return Status::InternalError("input pointer is nullptr.");
+ }
+
+ *eos = true;
+ if (_config_infos.empty()) {
+ return Status::OK();
+ }
+
+ for (size_t col_idx = 0; col_idx < _s_tbls_columns.size(); ++col_idx) {
+ size_t row_num = _config_infos.size();
+ std::vector<StringRef> str_refs(row_num);
+ std::vector<int64_t> bigint_vals(row_num);
+ std::vector<int8_t> bool_vals(row_num);
+ std::vector<void*> datas(row_num);
+ std::vector<std::string> column_values(row_num);
+
+ for (size_t row_idx = 0; row_idx < row_num; ++row_idx) {
+ // be_id
+ if (col_idx == 0) {
+ bigint_vals[row_idx] = _backend_id;
+ datas[row_idx] = &bigint_vals[row_idx];
+ } else {
+ // config
+ const auto& row = _config_infos[row_idx];
+ if (row.size() != _s_tbls_columns.size() - 1) {
+ return Status::InternalError(
+ "backend configs info meet invalid schema, schema_size={}, "
+ "input_data_size={}",
+ _config_infos.size(), row.size());
+ }
+
+ std::string& column_value =
+ column_values[row_idx]; // Reference to the actual string in the vector
+ column_value = row[col_idx - 1];
+ if (_s_tbls_columns[col_idx].type == TYPE_BOOLEAN) {
+ bool_vals[row_idx] = column_value == "true" ? 1 : 0;
+ datas[row_idx] = &bool_vals[row_idx];
+ } else {
+ str_refs[row_idx] =
+ StringRef(column_values[row_idx].data(), column_values[row_idx].size());
+ datas[row_idx] = &str_refs[row_idx];
Review Comment:
str_refs should be destructed after ```for loop``` ends, but datas holds str_refs's ptr and datas is vistited out of the ```for loop``` in line 102, why hasn't there been a coredump, bool_vals has the same problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](systable)add information_schema backend_configuration table [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2933542786
<details>
<summary>TPC-H: <b>Total hot run time: 34626 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 34bb4b35182870792f9a2f8e6434e41fea8a3389, data reload: false
------ Round 1 ----------------------------------
q1 26339 5027 4975 4975
q2 1955 294 181 181
q3 10438 1304 734 734
q4 10250 1015 540 540
q5 7816 2413 2322 2322
q6 184 167 134 134
q7 903 741 609 609
q8 9298 1310 1132 1132
q9 6842 5234 5105 5105
q10 6880 2331 1899 1899
q11 488 288 273 273
q12 346 355 208 208
q13 17786 3721 3105 3105
q14 237 225 210 210
q15 551 490 497 490
q16 441 427 374 374
q17 618 871 372 372
q18 7838 7229 7106 7106
q19 2213 972 588 588
q20 336 337 223 223
q21 3849 3200 3050 3050
q22 1064 996 996 996
Total cold run time: 116672 ms
Total hot run time: 34626 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5261 5059 5082 5059
q2 237 321 220 220
q3 2173 2661 2314 2314
q4 1341 1848 1518 1518
q5 4486 4437 4357 4357
q6 218 169 123 123
q7 1958 1863 1737 1737
q8 2563 2541 2429 2429
q9 7261 7201 7148 7148
q10 2961 3159 2712 2712
q11 581 537 481 481
q12 676 788 640 640
q13 3491 3904 3156 3156
q14 287 319 271 271
q15 511 479 470 470
q16 429 487 441 441
q17 1197 1516 1423 1423
q18 7703 7456 7342 7342
q19 808 799 906 799
q20 2000 2054 1923 1923
q21 4777 4371 4273 4273
q22 1075 1025 955 955
Total cold run time: 51994 ms
Total hot run time: 49791 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](systable)add information_schema backend_configuration table [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2933589235
<details>
<summary>ClickBench: <b>Total hot run time: 29.44 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 34bb4b35182870792f9a2f8e6434e41fea8a3389, data reload: false
query1 0.03 0.04 0.03
query2 0.12 0.10 0.10
query3 0.26 0.20 0.20
query4 1.60 0.20 0.19
query5 0.45 0.44 0.46
query6 1.51 0.65 0.67
query7 0.02 0.02 0.02
query8 0.05 0.03 0.04
query9 0.57 0.51 0.53
query10 0.58 0.59 0.55
query11 0.17 0.11 0.11
query12 0.15 0.12 0.12
query13 0.61 0.60 0.62
query14 0.80 0.80 0.80
query15 0.86 0.84 0.87
query16 0.39 0.39 0.40
query17 1.06 1.04 1.05
query18 0.22 0.21 0.22
query19 1.93 1.79 1.84
query20 0.01 0.01 0.02
query21 15.40 0.88 0.54
query22 0.78 1.25 0.79
query23 14.71 1.34 0.58
query24 7.38 0.91 1.12
query25 0.48 0.19 0.09
query26 0.66 0.17 0.15
query27 0.06 0.05 0.04
query28 9.22 0.90 0.45
query29 12.56 3.96 3.40
query30 0.25 0.09 0.08
query31 2.82 0.60 0.38
query32 3.23 0.57 0.48
query33 3.06 3.05 3.07
query34 15.68 5.18 4.54
query35 4.54 4.61 4.51
query36 0.68 0.50 0.49
query37 0.08 0.06 0.06
query38 0.05 0.04 0.03
query39 0.04 0.03 0.03
query40 0.16 0.14 0.14
query41 0.08 0.02 0.02
query42 0.03 0.02 0.02
query43 0.05 0.03 0.03
Total cold run time: 103.39 s
Total hot run time: 29.44 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on code in PR #51024:
URL: https://github.com/apache/doris/pull/51024#discussion_r2106406308
##########
be/src/exec/schema_scanner/schema_backend_configuration_scanner.cpp:
##########
@@ -0,0 +1,106 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "exec/schema_scanner/schema_backend_configuration_scanner.h"
+
+#include <gen_cpp/Descriptors_types.h>
+
+#include <string>
+
+#include "runtime/define_primitive_type.h"
+#include "runtime/exec_env.h"
+#include "runtime/runtime_state.h"
+#include "vec/common/string_ref.h"
+#include "vec/core/block.h"
+
+namespace doris {
+
+std::vector<SchemaScanner::ColumnDesc> SchemaBackendConfigurationScanner::_s_tbls_columns = {
+ // name, type, size, is_null
+ {"BE_ID", TYPE_BIGINT, sizeof(int64_t), true},
+ {"CONFIGURATION", TYPE_STRING, sizeof(StringRef), true},
Review Comment:
CONFIGURATION_NAME
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2911045028
<details>
<summary>TPC-H: <b>Total hot run time: 34128 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2333609c75cbdf24c67a6e667a775c4796132a0d, data reload: false
------ Round 1 ----------------------------------
q1 26433 5252 5125 5125
q2 2107 304 195 195
q3 10476 1265 725 725
q4 10223 986 520 520
q5 7675 2461 2297 2297
q6 194 166 135 135
q7 917 739 622 622
q8 9312 1302 1134 1134
q9 6712 5140 5122 5122
q10 6881 2347 1915 1915
q11 487 298 289 289
q12 343 350 215 215
q13 17797 3798 3121 3121
q14 237 244 214 214
q15 542 488 507 488
q16 439 431 380 380
q17 592 870 356 356
q18 7783 7144 7072 7072
q19 1773 954 571 571
q20 325 342 232 232
q21 3856 2573 2418 2418
q22 1026 1021 982 982
Total cold run time: 116130 ms
Total hot run time: 34128 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5209 5080 5115 5080
q2 241 340 228 228
q3 2168 2661 2256 2256
q4 1359 1860 1493 1493
q5 4503 4423 4402 4402
q6 219 170 129 129
q7 1989 1876 1733 1733
q8 2591 2719 2651 2651
q9 7092 7123 7135 7123
q10 2981 3227 2768 2768
q11 572 520 495 495
q12 662 744 576 576
q13 3581 4007 3391 3391
q14 277 289 270 270
q15 534 490 478 478
q16 450 502 436 436
q17 1180 1580 1417 1417
q18 7743 7553 7482 7482
q19 834 900 1101 900
q20 2049 2055 1863 1863
q21 4748 4444 4299 4299
q22 1062 1033 972 972
Total cold run time: 52044 ms
Total hot run time: 50442 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "koarz (via GitHub)" <gi...@apache.org>.
koarz commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2889982019
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2890864291
<details>
<summary>TPC-DS: <b>Total hot run time: 194142 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit df74043e94f345f42d2fee58907a53efc81dbf80, data reload: false
query1 1426 1085 1072 1072
query2 6413 1776 1833 1776
query3 11015 4480 4490 4480
query4 52144 25731 23510 23510
query5 5042 523 463 463
query6 336 213 195 195
query7 4867 522 304 304
query8 306 253 243 243
query9 5386 2669 2667 2667
query10 451 333 271 271
query11 15059 15173 15054 15054
query12 161 114 108 108
query13 1037 540 429 429
query14 10070 6635 6618 6618
query15 205 212 175 175
query16 7175 683 471 471
query17 1109 739 622 622
query18 1596 413 322 322
query19 212 205 180 180
query20 136 131 121 121
query21 215 127 115 115
query22 4278 4391 4254 4254
query23 34348 33492 33513 33492
query24 6641 2443 2420 2420
query25 457 482 408 408
query26 703 269 149 149
query27 2248 514 351 351
query28 3075 2197 2178 2178
query29 592 588 441 441
query30 273 224 203 203
query31 831 849 763 763
query32 77 63 64 63
query33 467 371 310 310
query34 922 899 546 546
query35 803 839 778 778
query36 917 1025 916 916
query37 102 94 72 72
query38 4229 4269 4289 4269
query39 1516 1489 1537 1489
query40 209 127 114 114
query41 56 54 58 54
query42 137 108 114 108
query43 509 518 487 487
query44 1407 889 884 884
query45 183 171 179 171
query46 861 1048 672 672
query47 1818 1899 1776 1776
query48 399 451 348 348
query49 686 514 443 443
query50 669 702 411 411
query51 4295 4286 4284 4284
query52 109 112 100 100
query53 227 262 195 195
query54 605 621 522 522
query55 92 86 88 86
query56 303 321 299 299
query57 1181 1223 1113 1113
query58 271 272 258 258
query59 2604 2790 2705 2705
query60 346 322 331 322
query61 128 127 129 127
query62 768 805 704 704
query63 228 186 190 186
query64 1738 1037 728 728
query65 4317 4218 4257 4218
query66 738 410 300 300
query67 15743 15790 15171 15171
query68 7321 891 540 540
query69 550 327 276 276
query70 1220 1102 1134 1102
query71 491 321 299 299
query72 5834 4938 4959 4938
query73 1511 707 364 364
query74 9057 9159 9123 9123
query75 3867 3216 2679 2679
query76 4231 1192 751 751
query77 679 400 291 291
query78 10150 10308 9441 9441
query79 1958 844 585 585
query80 624 530 443 443
query81 494 260 222 222
query82 410 125 91 91
query83 352 249 246 246
query84 347 103 86 86
query85 795 354 324 324
query86 341 308 301 301
query87 4407 4423 4365 4365
query88 3045 2379 2359 2359
query89 397 327 280 280
query90 1956 207 207 207
query91 147 152 112 112
query92 135 62 59 59
query93 1161 940 589 589
query94 685 411 305 305
query95 375 290 298 290
query96 494 558 283 283
query97 2749 2740 2618 2618
query98 231 210 200 200
query99 1468 1395 1289 1289
Total cold run time: 294949 ms
Total hot run time: 194142 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "koarz (via GitHub)" <gi...@apache.org>.
koarz commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2918526644
run external
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2918254380
<details>
<summary>ClickBench: <b>Total hot run time: 29 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 55a614327dd851a1d761d9f4e63865438c60e2f2, data reload: false
query1 0.04 0.04 0.03
query2 0.12 0.10 0.12
query3 0.26 0.18 0.20
query4 1.60 0.19 0.11
query5 0.43 0.42 0.43
query6 1.16 0.65 0.65
query7 0.02 0.02 0.01
query8 0.04 0.04 0.03
query9 0.57 0.51 0.53
query10 0.57 0.59 0.58
query11 0.15 0.10 0.11
query12 0.15 0.11 0.11
query13 0.62 0.62 0.59
query14 0.79 0.81 0.80
query15 0.87 0.86 0.86
query16 0.38 0.39 0.38
query17 1.05 1.05 1.01
query18 0.23 0.21 0.21
query19 1.93 1.91 1.83
query20 0.02 0.01 0.01
query21 15.41 0.88 0.52
query22 0.76 1.19 0.80
query23 14.79 1.35 0.62
query24 7.48 0.78 0.92
query25 0.53 0.18 0.06
query26 0.55 0.17 0.14
query27 0.05 0.06 0.05
query28 9.41 0.88 0.44
query29 12.57 3.99 3.33
query30 0.25 0.09 0.06
query31 2.82 0.61 0.40
query32 3.24 0.55 0.47
query33 3.10 3.05 3.01
query34 15.88 5.12 4.48
query35 4.52 4.53 4.55
query36 0.67 0.49 0.47
query37 0.09 0.06 0.07
query38 0.05 0.04 0.04
query39 0.03 0.02 0.02
query40 0.16 0.12 0.13
query41 0.08 0.03 0.03
query42 0.04 0.03 0.02
query43 0.04 0.03 0.03
Total cold run time: 103.52 s
Total hot run time: 29 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](systable)add information_schema backend_configuration table [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2937980800
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](systable)add information_schema backend_configuration table [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2943669264
# FE UT Coverage Report
Increment line coverage ` 100.00% (10/10)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/51024_34bb4b35182870792f9a2f8e6434e41fea8a3389/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/51024_34bb4b35182870792f9a2f8e6434e41fea8a3389/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2903077072
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/991022d92b1c9a0ccddf71a4d1718dded758018e_991022d92b1c9a0ccddf71a4d1718dded758018e_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/991022d92b1c9a0ccddf71a4d1718dded758018e_991022d92b1c9a0ccddf71a4d1718dded758018e_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.25% (1113/1337) |
| Line Coverage | 66.12% (18662/28223) |
| Region Coverage | 65.72% (9252/14077) |
| Branch Coverage | 55.54% (4979/8964) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on code in PR #51024:
URL: https://github.com/apache/doris/pull/51024#discussion_r2106406474
##########
be/src/exec/schema_scanner/schema_backend_configuration_scanner.cpp:
##########
@@ -0,0 +1,106 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "exec/schema_scanner/schema_backend_configuration_scanner.h"
+
+#include <gen_cpp/Descriptors_types.h>
+
+#include <string>
+
+#include "runtime/define_primitive_type.h"
+#include "runtime/exec_env.h"
+#include "runtime/runtime_state.h"
+#include "vec/common/string_ref.h"
+#include "vec/core/block.h"
+
+namespace doris {
+
+std::vector<SchemaScanner::ColumnDesc> SchemaBackendConfigurationScanner::_s_tbls_columns = {
+ // name, type, size, is_null
+ {"BE_ID", TYPE_BIGINT, sizeof(int64_t), true},
+ {"CONFIGURATION", TYPE_STRING, sizeof(StringRef), true},
Review Comment:
CONFIG_XXX is enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2908378445
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/2333609c75cbdf24c67a6e667a775c4796132a0d_2333609c75cbdf24c67a6e667a775c4796132a0d_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/2333609c75cbdf24c67a6e667a775c4796132a0d_2333609c75cbdf24c67a6e667a775c4796132a0d_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.25% (1113/1337) |
| Line Coverage | 66.26% (18701/28224) |
| Region Coverage | 65.84% (9270/14079) |
| Branch Coverage | 55.59% (4984/8966) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2918042852
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/55a614327dd851a1d761d9f4e63865438c60e2f2_55a614327dd851a1d761d9f4e63865438c60e2f2_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/55a614327dd851a1d761d9f4e63865438c60e2f2_55a614327dd851a1d761d9f4e63865438c60e2f2_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.26% (1114/1338) |
| Line Coverage | 66.49% (18808/28287) |
| Region Coverage | 66.17% (9329/14098) |
| Branch Coverage | 56.06% (5032/8976) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2918234207
<details>
<summary>TPC-H: <b>Total hot run time: 33821 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 55a614327dd851a1d761d9f4e63865438c60e2f2, data reload: false
------ Round 1 ----------------------------------
q1 26213 5023 5005 5005
q2 2089 278 189 189
q3 10521 1273 691 691
q4 10239 979 524 524
q5 7778 2362 2377 2362
q6 182 167 133 133
q7 907 746 600 600
q8 9318 1277 1059 1059
q9 6799 5132 5135 5132
q10 6831 2329 1890 1890
q11 487 282 267 267
q12 350 360 214 214
q13 17805 3704 3098 3098
q14 235 232 207 207
q15 526 482 504 482
q16 454 432 377 377
q17 595 855 387 387
q18 7595 7172 7052 7052
q19 1740 966 565 565
q20 336 336 222 222
q21 3868 2559 2385 2385
q22 1050 1029 980 980
Total cold run time: 115918 ms
Total hot run time: 33821 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5153 5077 5060 5060
q2 237 329 227 227
q3 2184 2661 2296 2296
q4 1336 1769 1376 1376
q5 4577 4483 4380 4380
q6 212 166 125 125
q7 2002 1935 1752 1752
q8 2603 2604 2483 2483
q9 7126 7072 7171 7072
q10 3008 3208 2761 2761
q11 572 513 483 483
q12 671 797 605 605
q13 3479 3837 3318 3318
q14 280 313 268 268
q15 530 480 478 478
q16 443 485 448 448
q17 1115 1559 1384 1384
q18 7677 7551 7377 7377
q19 775 819 878 819
q20 1962 2055 1882 1882
q21 4877 4312 4236 4236
q22 1065 1056 952 952
Total cold run time: 51884 ms
Total hot run time: 49782 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "koarz (via GitHub)" <gi...@apache.org>.
koarz commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2914760012
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](systable)add information_schema backend_configuration table [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2933309535
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/34bb4b35182870792f9a2f8e6434e41fea8a3389_34bb4b35182870792f9a2f8e6434e41fea8a3389_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/34bb4b35182870792f9a2f8e6434e41fea8a3389_34bb4b35182870792f9a2f8e6434e41fea8a3389_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.31% (1118/1342) |
| Line Coverage | 66.80% (19146/28663) |
| Region Coverage | 66.38% (9466/14261) |
| Branch Coverage | 56.38% (5134/9106) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](systable)add information_schema backend_configuration table [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2933578359
<details>
<summary>TPC-DS: <b>Total hot run time: 185588 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 34bb4b35182870792f9a2f8e6434e41fea8a3389, data reload: false
query1 1029 479 489 479
query2 6566 1873 1802 1802
query3 6760 232 231 231
query4 25789 23290 23128 23128
query5 4343 645 458 458
query6 300 198 191 191
query7 4644 497 281 281
query8 269 217 206 206
query9 8619 2632 2628 2628
query10 487 332 282 282
query11 15432 15059 14847 14847
query12 153 109 105 105
query13 1650 535 411 411
query14 8944 6098 5947 5947
query15 195 189 172 172
query16 7133 636 504 504
query17 1185 727 560 560
query18 1965 389 293 293
query19 224 188 170 170
query20 121 117 124 117
query21 215 127 112 112
query22 4120 4323 3884 3884
query23 33975 33145 33227 33145
query24 8454 2402 2403 2402
query25 530 466 383 383
query26 1255 277 150 150
query27 2746 504 341 341
query28 4313 2130 2111 2111
query29 791 551 445 445
query30 290 221 191 191
query31 913 884 737 737
query32 82 69 73 69
query33 562 386 325 325
query34 799 855 535 535
query35 767 823 751 751
query36 939 951 854 854
query37 112 100 77 77
query38 4107 4179 4038 4038
query39 1458 1416 1446 1416
query40 211 120 106 106
query41 65 59 58 58
query42 127 111 105 105
query43 489 502 477 477
query44 1344 825 823 823
query45 176 184 170 170
query46 845 1024 632 632
query47 1798 1809 1740 1740
query48 394 447 310 310
query49 752 501 402 402
query50 654 689 427 427
query51 4097 4154 4131 4131
query52 120 109 103 103
query53 228 262 186 186
query54 582 582 510 510
query55 91 85 84 84
query56 300 312 278 278
query57 1159 1165 1066 1066
query58 273 254 259 254
query59 2597 2712 2593 2593
query60 327 340 315 315
query61 130 125 154 125
query62 827 737 664 664
query63 227 211 192 192
query64 4459 1141 781 781
query65 4251 4192 4138 4138
query66 1179 434 328 328
query67 15706 15678 15447 15447
query68 7968 892 529 529
query69 488 326 285 285
query70 1187 1103 1156 1103
query71 463 315 290 290
query72 5602 4770 4919 4770
query73 689 655 358 358
query74 9124 9198 8650 8650
query75 3773 3267 2701 2701
query76 3640 1191 773 773
query77 782 372 284 284
query78 9957 10110 9335 9335
query79 2813 827 577 577
query80 616 556 510 510
query81 470 255 217 217
query82 461 129 102 102
query83 291 252 238 238
query84 295 107 88 88
query85 785 373 327 327
query86 327 299 277 277
query87 4455 4367 4346 4346
query88 3258 2278 2271 2271
query89 393 309 292 292
query90 1945 218 216 216
query91 142 139 112 112
query92 79 61 62 61
query93 1800 947 588 588
query94 686 413 309 309
query95 378 300 291 291
query96 505 572 281 281
query97 2696 2780 2698 2698
query98 243 207 215 207
query99 1423 1407 1279 1279
Total cold run time: 273378 ms
Total hot run time: 185588 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](systable)add information_schema backend_configuration table [doris]
Posted by "koarz (via GitHub)" <gi...@apache.org>.
koarz commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2939014287
run feut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2903221756
<details>
<summary>TPC-DS: <b>Total hot run time: 192920 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 991022d92b1c9a0ccddf71a4d1718dded758018e, data reload: false
query1 1422 1071 1071 1071
query2 6409 1860 1846 1846
query3 11001 4407 4398 4398
query4 54010 25158 23401 23401
query5 4956 524 464 464
query6 354 211 202 202
query7 4877 508 285 285
query8 319 268 244 244
query9 5462 2718 2675 2675
query10 445 347 270 270
query11 15264 15031 14773 14773
query12 159 110 108 108
query13 1049 543 400 400
query14 10169 6276 6131 6131
query15 210 204 181 181
query16 7144 629 487 487
query17 1082 729 576 576
query18 1706 408 311 311
query19 198 188 169 169
query20 129 128 129 128
query21 205 123 111 111
query22 4274 4531 4259 4259
query23 34298 33516 33554 33516
query24 7059 2402 2429 2402
query25 474 472 416 416
query26 693 265 155 155
query27 2282 518 341 341
query28 2869 2169 2194 2169
query29 581 568 429 429
query30 275 226 182 182
query31 876 868 793 793
query32 69 66 67 66
query33 443 383 311 311
query34 796 856 528 528
query35 809 828 767 767
query36 945 1015 901 901
query37 106 102 78 78
query38 4252 4246 4240 4240
query39 1493 1450 1460 1450
query40 223 124 108 108
query41 59 55 55 55
query42 130 113 120 113
query43 500 519 501 501
query44 1368 875 874 874
query45 181 174 172 172
query46 844 1039 665 665
query47 1881 1870 1829 1829
query48 403 457 327 327
query49 672 514 467 467
query50 651 691 404 404
query51 4300 4175 4234 4175
query52 107 109 99 99
query53 225 255 185 185
query54 580 568 528 528
query55 91 87 83 83
query56 309 315 306 306
query57 1203 1239 1180 1180
query58 266 260 261 260
query59 2769 2780 2672 2672
query60 350 330 311 311
query61 130 144 124 124
query62 770 736 683 683
query63 222 193 192 192
query64 1714 1027 686 686
query65 4297 4214 4279 4214
query66 713 396 310 310
query67 16019 15877 15595 15595
query68 5533 845 530 530
query69 533 314 280 280
query70 1211 1112 1110 1110
query71 465 327 305 305
query72 6135 4969 4766 4766
query73 1339 619 345 345
query74 8875 9261 9009 9009
query75 3273 3215 2698 2698
query76 3800 1183 733 733
query77 537 374 293 293
query78 10180 10146 9342 9342
query79 2607 826 556 556
query80 706 513 529 513
query81 497 245 221 221
query82 538 131 98 98
query83 249 249 234 234
query84 302 108 84 84
query85 797 358 319 319
query86 374 290 257 257
query87 4388 4416 4381 4381
query88 3647 2324 2297 2297
query89 405 312 281 281
query90 1764 209 211 209
query91 140 146 118 118
query92 76 66 59 59
query93 2276 933 575 575
query94 715 405 297 297
query95 376 296 287 287
query96 496 561 281 281
query97 2764 2732 2613 2613
query98 233 212 208 208
query99 1701 1419 1269 1269
Total cold run time: 297073 ms
Total hot run time: 192920 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2890193507
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/866b8e34e862566509ee10212802039787432272_866b8e34e862566509ee10212802039787432272_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/866b8e34e862566509ee10212802039787432272_866b8e34e862566509ee10212802039787432272_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.31% (1113/1336) |
| Line Coverage | 66.21% (18662/28187) |
| Region Coverage | 65.81% (9264/14076) |
| Branch Coverage | 55.63% (4987/8964) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement]add information_schema backend_configuration table [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #51024:
URL: https://github.com/apache/doris/pull/51024#issuecomment-2889980825
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org