You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2016/02/08 22:58:42 UTC

svn commit: r1729277 [7/7] - in /commons/proper/dbcp/trunk/src: main/java/org/apache/commons/dbcp2/ main/java/org/apache/commons/dbcp2/cpdsadapter/ main/java/org/apache/commons/dbcp2/datasources/ main/java/org/apache/commons/dbcp2/managed/ test/java/or...

Modified: commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterResultSet.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterResultSet.java?rev=1729277&r1=1729276&r2=1729277&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterResultSet.java (original)
+++ commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterResultSet.java Mon Feb  8 21:58:41 2016
@@ -44,16 +44,16 @@ import java.sql.SQLXML;
  * @version $Id$
  */
 public class TesterResultSet implements ResultSet {
-    public TesterResultSet(Statement stmt) {
+    public TesterResultSet(final Statement stmt) {
         _statement = stmt;
     }
 
-    public TesterResultSet(Statement stmt, Object[][] data) {
+    public TesterResultSet(final Statement stmt, final Object[][] data) {
         _statement = stmt;
         _data = data;
     }
 
-    public TesterResultSet(Statement stmt, int type, int concurrency) {
+    public TesterResultSet(final Statement stmt, final int type, final int concurrency) {
         _statement = stmt;
         _data = null;
         _type = type;
@@ -107,7 +107,7 @@ public class TesterResultSet implements
     }
 
     @Override
-    public String getString(int columnIndex) throws SQLException {
+    public String getString(final int columnIndex) throws SQLException {
         checkOpen();
         if (columnIndex == -1) {
             throw new SQLException("broken connection");
@@ -119,43 +119,43 @@ public class TesterResultSet implements
     }
 
     @Override
-    public boolean getBoolean(int columnIndex) throws SQLException {
+    public boolean getBoolean(final int columnIndex) throws SQLException {
         checkOpen();
         return true;
     }
 
     @Override
-    public byte getByte(int columnIndex) throws SQLException {
+    public byte getByte(final int columnIndex) throws SQLException {
         checkOpen();
         return (byte)columnIndex;
     }
 
     @Override
-    public short getShort(int columnIndex) throws SQLException {
+    public short getShort(final int columnIndex) throws SQLException {
         checkOpen();
         return (short)columnIndex;
     }
 
     @Override
-    public int getInt(int columnIndex) throws SQLException {
+    public int getInt(final int columnIndex) throws SQLException {
         checkOpen();
         return (short)columnIndex;
     }
 
     @Override
-    public long getLong(int columnIndex) throws SQLException {
+    public long getLong(final int columnIndex) throws SQLException {
         checkOpen();
         return columnIndex;
     }
 
     @Override
-    public float getFloat(int columnIndex) throws SQLException {
+    public float getFloat(final int columnIndex) throws SQLException {
         checkOpen();
         return columnIndex;
     }
 
     @Override
-    public double getDouble(int columnIndex) throws SQLException {
+    public double getDouble(final int columnIndex) throws SQLException {
         checkOpen();
         return columnIndex;
     }
@@ -163,37 +163,37 @@ public class TesterResultSet implements
     /** @deprecated */
     @Deprecated
     @Override
-    public BigDecimal getBigDecimal(int columnIndex, int scale) throws SQLException {
+    public BigDecimal getBigDecimal(final int columnIndex, final int scale) throws SQLException {
         checkOpen();
         return new BigDecimal(columnIndex);
     }
 
     @Override
-    public byte[] getBytes(int columnIndex) throws SQLException {
+    public byte[] getBytes(final int columnIndex) throws SQLException {
         checkOpen();
         return new byte[] { (byte)columnIndex };
     }
 
     @Override
-    public java.sql.Date getDate(int columnIndex) throws SQLException {
+    public java.sql.Date getDate(final int columnIndex) throws SQLException {
         checkOpen();
         return null;
     }
 
     @Override
-    public java.sql.Time getTime(int columnIndex) throws SQLException {
+    public java.sql.Time getTime(final int columnIndex) throws SQLException {
         checkOpen();
         return null;
     }
 
     @Override
-    public java.sql.Timestamp getTimestamp(int columnIndex) throws SQLException {
+    public java.sql.Timestamp getTimestamp(final int columnIndex) throws SQLException {
         checkOpen();
         return null;
     }
 
     @Override
-    public java.io.InputStream getAsciiStream(int columnIndex) throws SQLException {
+    public java.io.InputStream getAsciiStream(final int columnIndex) throws SQLException {
         checkOpen();
         return null;
     }
@@ -201,61 +201,61 @@ public class TesterResultSet implements
     /** @deprecated */
     @Deprecated
     @Override
-    public java.io.InputStream getUnicodeStream(int columnIndex) throws SQLException {
+    public java.io.InputStream getUnicodeStream(final int columnIndex) throws SQLException {
         checkOpen();
         return null;
     }
 
     @Override
-    public java.io.InputStream getBinaryStream(int columnIndex) throws SQLException {
+    public java.io.InputStream getBinaryStream(final int columnIndex) throws SQLException {
         checkOpen();
         return null;
     }
 
     @Override
-    public String getString(String columnName) throws SQLException {
+    public String getString(final String columnName) throws SQLException {
         checkOpen();
         return columnName;
     }
 
     @Override
-    public boolean getBoolean(String columnName) throws SQLException {
+    public boolean getBoolean(final String columnName) throws SQLException {
         checkOpen();
         return true;
     }
 
     @Override
-    public byte getByte(String columnName) throws SQLException {
+    public byte getByte(final String columnName) throws SQLException {
         checkOpen();
         return (byte)columnName.hashCode();
     }
 
     @Override
-    public short getShort(String columnName) throws SQLException {
+    public short getShort(final String columnName) throws SQLException {
         checkOpen();
         return (short)columnName.hashCode();
     }
 
     @Override
-    public int getInt(String columnName) throws SQLException {
+    public int getInt(final String columnName) throws SQLException {
         checkOpen();
         return columnName.hashCode();
     }
 
     @Override
-    public long getLong(String columnName) throws SQLException {
+    public long getLong(final String columnName) throws SQLException {
         checkOpen();
         return columnName.hashCode();
     }
 
     @Override
-    public float getFloat(String columnName) throws SQLException {
+    public float getFloat(final String columnName) throws SQLException {
         checkOpen();
         return columnName.hashCode();
     }
 
     @Override
-    public double getDouble(String columnName) throws SQLException {
+    public double getDouble(final String columnName) throws SQLException {
         checkOpen();
         return columnName.hashCode();
     }
@@ -263,13 +263,13 @@ public class TesterResultSet implements
     /** @deprecated */
     @Deprecated
     @Override
-    public BigDecimal getBigDecimal(String columnName, int scale) throws SQLException {
+    public BigDecimal getBigDecimal(final String columnName, final int scale) throws SQLException {
         checkOpen();
         return new BigDecimal(columnName.hashCode());
     }
 
     @Override
-    public byte[] getBytes(String columnName) throws SQLException {
+    public byte[] getBytes(final String columnName) throws SQLException {
         checkOpen();
         try {
             return columnName.getBytes("UTF-8");
@@ -280,25 +280,25 @@ public class TesterResultSet implements
     }
 
     @Override
-    public java.sql.Date getDate(String columnName) throws SQLException {
+    public java.sql.Date getDate(final String columnName) throws SQLException {
         checkOpen();
         return null;
     }
 
     @Override
-    public java.sql.Time getTime(String columnName) throws SQLException {
+    public java.sql.Time getTime(final String columnName) throws SQLException {
         checkOpen();
         return null;
     }
 
     @Override
-    public java.sql.Timestamp getTimestamp(String columnName) throws SQLException {
+    public java.sql.Timestamp getTimestamp(final String columnName) throws SQLException {
         checkOpen();
         return null;
     }
 
     @Override
-    public java.io.InputStream getAsciiStream(String columnName) throws SQLException {
+    public java.io.InputStream getAsciiStream(final String columnName) throws SQLException {
         checkOpen();
         return null;
     }
@@ -306,13 +306,13 @@ public class TesterResultSet implements
     /** @deprecated */
     @Deprecated
     @Override
-    public java.io.InputStream getUnicodeStream(String columnName) throws SQLException {
+    public java.io.InputStream getUnicodeStream(final String columnName) throws SQLException {
         checkOpen();
         return null;
     }
 
     @Override
-    public java.io.InputStream getBinaryStream(String columnName) throws SQLException {
+    public java.io.InputStream getBinaryStream(final String columnName) throws SQLException {
         checkOpen();
         return null;
     }
@@ -341,7 +341,7 @@ public SQLWarning getWarnings() throws S
     }
 
     @Override
-    public Object getObject(int columnIndex) throws SQLException {
+    public Object getObject(final int columnIndex) throws SQLException {
         checkOpen();
         if (_data != null) {
             return _data[_currentRow][columnIndex-1];
@@ -350,38 +350,38 @@ public SQLWarning getWarnings() throws S
     }
 
     @Override
-    public Object getObject(String columnName) throws SQLException {
+    public Object getObject(final String columnName) throws SQLException {
         checkOpen();
         return columnName;
     }
 
     @Override
-    public int findColumn(String columnName) throws SQLException {
+    public int findColumn(final String columnName) throws SQLException {
         checkOpen();
         return 1;
     }
 
 
     @Override
-    public java.io.Reader getCharacterStream(int columnIndex) throws SQLException {
+    public java.io.Reader getCharacterStream(final int columnIndex) throws SQLException {
         checkOpen();
         return null;
     }
 
     @Override
-    public java.io.Reader getCharacterStream(String columnName) throws SQLException {
+    public java.io.Reader getCharacterStream(final String columnName) throws SQLException {
         checkOpen();
         return null;
     }
 
     @Override
-    public BigDecimal getBigDecimal(int columnIndex) throws SQLException {
+    public BigDecimal getBigDecimal(final int columnIndex) throws SQLException {
         checkOpen();
         return new BigDecimal(columnIndex);
     }
 
     @Override
-    public BigDecimal getBigDecimal(String columnName) throws SQLException {
+    public BigDecimal getBigDecimal(final String columnName) throws SQLException {
         checkOpen();
         return new BigDecimal(columnName.hashCode());
     }
@@ -439,13 +439,13 @@ public SQLWarning getWarnings() throws S
     }
 
     @Override
-    public boolean absolute( int row ) throws SQLException {
+    public boolean absolute( final int row ) throws SQLException {
         checkOpen();
         return false;
     }
 
     @Override
-    public boolean relative( int rows ) throws SQLException {
+    public boolean relative( final int rows ) throws SQLException {
         checkOpen();
         return false;
     }
@@ -457,7 +457,7 @@ public SQLWarning getWarnings() throws S
     }
 
     @Override
-    public void setFetchDirection(int direction) throws SQLException {
+    public void setFetchDirection(final int direction) throws SQLException {
         checkOpen();
     }
 
@@ -468,7 +468,7 @@ public SQLWarning getWarnings() throws S
     }
 
     @Override
-    public void setFetchSize(int rows) throws SQLException {
+    public void setFetchSize(final int rows) throws SQLException {
         checkOpen();
     }
 
@@ -507,208 +507,208 @@ public SQLWarning getWarnings() throws S
     }
 
     @Override
-    public void updateNull(int columnIndex) throws SQLException {
+    public void updateNull(final int columnIndex) throws SQLException {
         checkOpen();
     }
 
     @Override
-    public void updateBoolean(int columnIndex, boolean x) throws SQLException {
+    public void updateBoolean(final int columnIndex, final boolean x) throws SQLException {
         checkOpen();
     }
 
     @Override
-    public void updateByte(int columnIndex, byte x) throws SQLException {
+    public void updateByte(final int columnIndex, final byte x) throws SQLException {
         checkOpen();
     }
 
     @Override
-    public void updateShort(int columnIndex, short x) throws SQLException {
+    public void updateShort(final int columnIndex, final short x) throws SQLException {
         checkOpen();
     }
 
     @Override
-    public void updateInt(int columnIndex, int x) throws SQLException {
+    public void updateInt(final int columnIndex, final int x) throws SQLException {
         checkOpen();
     }
 
     @Override
-    public void updateLong(int columnIndex, long x) throws SQLException {
+    public void updateLong(final int columnIndex, final long x) throws SQLException {
         checkOpen();
     }
 
     @Override
-    public void updateFloat(int columnIndex, float x) throws SQLException {
+    public void updateFloat(final int columnIndex, final float x) throws SQLException {
         checkOpen();
     }
 
     @Override
-    public void updateDouble(int columnIndex, double x) throws SQLException {
+    public void updateDouble(final int columnIndex, final double x) throws SQLException {
         checkOpen();
     }
 
     @Override
-    public void updateBigDecimal(int columnIndex, BigDecimal x) throws SQLException {
+    public void updateBigDecimal(final int columnIndex, final BigDecimal x) throws SQLException {
         checkOpen();
     }
 
     @Override
-    public void updateString(int columnIndex, String x) throws SQLException {
+    public void updateString(final int columnIndex, final String x) throws SQLException {
         checkOpen();
     }
 
     @Override
-    public void updateBytes(int columnIndex, byte x[]) throws SQLException {
+    public void updateBytes(final int columnIndex, final byte x[]) throws SQLException {
         checkOpen();
     }
 
     @Override
-    public void updateDate(int columnIndex, java.sql.Date x) throws SQLException {
+    public void updateDate(final int columnIndex, final java.sql.Date x) throws SQLException {
         checkOpen();
     }
 
     @Override
-    public void updateTime(int columnIndex, java.sql.Time x) throws SQLException {
+    public void updateTime(final int columnIndex, final java.sql.Time x) throws SQLException {
         checkOpen();
     }
 
     @Override
-    public void updateTimestamp(int columnIndex, java.sql.Timestamp x) throws SQLException {
+    public void updateTimestamp(final int columnIndex, final java.sql.Timestamp x) throws SQLException {
         checkOpen();
     }
 
 
     @Override
-    public void updateAsciiStream(int columnIndex,
-               java.io.InputStream x,
-               int length) throws SQLException {
+    public void updateAsciiStream(final int columnIndex,
+               final java.io.InputStream x,
+               final int length) throws SQLException {
         checkOpen();
     }
 
     @Override
-    public void updateBinaryStream(int columnIndex,
-                java.io.InputStream x,
-                int length) throws SQLException {
+    public void updateBinaryStream(final int columnIndex,
+                final java.io.InputStream x,
+                final int length) throws SQLException {
         checkOpen();
     }
 
     @Override
-    public void updateCharacterStream(int columnIndex,
-                 java.io.Reader x,
-                 int length) throws SQLException {
+    public void updateCharacterStream(final int columnIndex,
+                 final java.io.Reader x,
+                 final int length) throws SQLException {
         checkOpen();
     }
 
     @Override
-    public void updateObject(int columnIndex, Object x, int scale)
+    public void updateObject(final int columnIndex, final Object x, final int scale)
       throws SQLException {
         checkOpen();
     }
 
     @Override
-    public void updateObject(int columnIndex, Object x) throws SQLException {
+    public void updateObject(final int columnIndex, final Object x) throws SQLException {
         checkOpen();
     }
 
     @Override
-    public void updateNull(String columnName) throws SQLException {
+    public void updateNull(final String columnName) throws SQLException {
         checkOpen();
     }
 
     @Override
-    public void updateBoolean(String columnName, boolean x) throws SQLException {
+    public void updateBoolean(final String columnName, final boolean x) throws SQLException {
         checkOpen();
     }
 
     @Override
-    public void updateByte(String columnName, byte x) throws SQLException {
+    public void updateByte(final String columnName, final byte x) throws SQLException {
         checkOpen();
     }
 
     @Override
-    public void updateShort(String columnName, short x) throws SQLException {
+    public void updateShort(final String columnName, final short x) throws SQLException {
         checkOpen();
     }
 
     @Override
-    public void updateInt(String columnName, int x) throws SQLException {
+    public void updateInt(final String columnName, final int x) throws SQLException {
         checkOpen();
     }
 
     @Override
-    public void updateLong(String columnName, long x) throws SQLException {
+    public void updateLong(final String columnName, final long x) throws SQLException {
         checkOpen();
     }
 
     @Override
-    public void updateFloat(String columnName, float x) throws SQLException {
+    public void updateFloat(final String columnName, final float x) throws SQLException {
         checkOpen();
     }
 
     @Override
-    public void updateDouble(String columnName, double x) throws SQLException {
+    public void updateDouble(final String columnName, final double x) throws SQLException {
         checkOpen();
     }
 
     @Override
-    public void updateBigDecimal(String columnName, BigDecimal x) throws SQLException {
+    public void updateBigDecimal(final String columnName, final BigDecimal x) throws SQLException {
         checkOpen();
     }
 
     @Override
-    public void updateString(String columnName, String x) throws SQLException {
+    public void updateString(final String columnName, final String x) throws SQLException {
         checkOpen();
     }
 
     @Override
-    public void updateBytes(String columnName, byte x[]) throws SQLException {
+    public void updateBytes(final String columnName, final byte x[]) throws SQLException {
         checkOpen();
     }
 
     @Override
-    public void updateDate(String columnName, java.sql.Date x) throws SQLException {
+    public void updateDate(final String columnName, final java.sql.Date x) throws SQLException {
         checkOpen();
     }
 
     @Override
-    public void updateTime(String columnName, java.sql.Time x) throws SQLException {
+    public void updateTime(final String columnName, final java.sql.Time x) throws SQLException {
         checkOpen();
     }
 
     @Override
-    public void updateTimestamp(String columnName, java.sql.Timestamp x)
+    public void updateTimestamp(final String columnName, final java.sql.Timestamp x)
       throws SQLException {
         checkOpen();
     }
 
     @Override
-    public void updateAsciiStream(String columnName,
-               java.io.InputStream x,
-               int length) throws SQLException {
+    public void updateAsciiStream(final String columnName,
+               final java.io.InputStream x,
+               final int length) throws SQLException {
         checkOpen();
     }
 
     @Override
-    public void updateBinaryStream(String columnName,
-                java.io.InputStream x,
-                int length) throws SQLException {
+    public void updateBinaryStream(final String columnName,
+                final java.io.InputStream x,
+                final int length) throws SQLException {
         checkOpen();
     }
 
     @Override
-    public void updateCharacterStream(String columnName,
-                 java.io.Reader reader,
-                 int length) throws SQLException {
+    public void updateCharacterStream(final String columnName,
+                 final java.io.Reader reader,
+                 final int length) throws SQLException {
         checkOpen();
     }
 
     @Override
-    public void updateObject(String columnName, Object x, int scale)
+    public void updateObject(final String columnName, final Object x, final int scale)
       throws SQLException {
         checkOpen();
     }
 
     @Override
-    public void updateObject(String columnName, Object x) throws SQLException {
+    public void updateObject(final String columnName, final Object x) throws SQLException {
         checkOpen();
     }
 
@@ -755,97 +755,97 @@ public SQLWarning getWarnings() throws S
 
 
     @Override
-    public Object getObject(int i, Map<String,Class<?>> map) throws SQLException {
+    public Object getObject(final int i, final Map<String,Class<?>> map) throws SQLException {
         checkOpen();
         return new Object();
     }
 
     @Override
-    public Ref getRef(int i) throws SQLException {
+    public Ref getRef(final int i) throws SQLException {
         checkOpen();
         return null;
     }
 
     @Override
-    public Blob getBlob(int i) throws SQLException {
+    public Blob getBlob(final int i) throws SQLException {
         checkOpen();
         return null;
     }
 
     @Override
-    public Clob getClob(int i) throws SQLException {
+    public Clob getClob(final int i) throws SQLException {
         checkOpen();
         return null;
     }
 
     @Override
-    public Array getArray(int i) throws SQLException {
+    public Array getArray(final int i) throws SQLException {
         checkOpen();
         return null;
     }
 
     @Override
-    public Object getObject(String colName, Map<String,Class<?>> map) throws SQLException {
+    public Object getObject(final String colName, final Map<String,Class<?>> map) throws SQLException {
         checkOpen();
         return colName;
     }
 
     @Override
-    public Ref getRef(String colName) throws SQLException {
+    public Ref getRef(final String colName) throws SQLException {
         checkOpen();
         return null;
     }
 
     @Override
-    public Blob getBlob(String colName) throws SQLException {
+    public Blob getBlob(final String colName) throws SQLException {
         checkOpen();
         return null;
     }
 
     @Override
-    public Clob getClob(String colName) throws SQLException {
+    public Clob getClob(final String colName) throws SQLException {
         checkOpen();
         return null;
     }
 
     @Override
-    public Array getArray(String colName) throws SQLException {
+    public Array getArray(final String colName) throws SQLException {
         checkOpen();
         return null;
     }
 
     @Override
-    public java.sql.Date getDate(int columnIndex, Calendar cal) throws SQLException {
+    public java.sql.Date getDate(final int columnIndex, final Calendar cal) throws SQLException {
         checkOpen();
         return null;
     }
 
     @Override
-    public java.sql.Date getDate(String columnName, Calendar cal) throws SQLException {
+    public java.sql.Date getDate(final String columnName, final Calendar cal) throws SQLException {
         checkOpen();
         return null;
     }
 
     @Override
-    public java.sql.Time getTime(int columnIndex, Calendar cal) throws SQLException {
+    public java.sql.Time getTime(final int columnIndex, final Calendar cal) throws SQLException {
         checkOpen();
         return null;
     }
 
     @Override
-    public java.sql.Time getTime(String columnName, Calendar cal) throws SQLException {
+    public java.sql.Time getTime(final String columnName, final Calendar cal) throws SQLException {
         checkOpen();
         return null;
     }
 
     @Override
-    public java.sql.Timestamp getTimestamp(int columnIndex, Calendar cal) throws SQLException {
+    public java.sql.Timestamp getTimestamp(final int columnIndex, final Calendar cal) throws SQLException {
         checkOpen();
         return null;
     }
 
     @Override
-    public java.sql.Timestamp getTimestamp(String columnName, Calendar cal)
+    public java.sql.Timestamp getTimestamp(final String columnName, final Calendar cal)
       throws SQLException {
         checkOpen();
         return null;
@@ -858,91 +858,91 @@ public SQLWarning getWarnings() throws S
     }
 
     @Override
-    public java.net.URL getURL(int columnIndex) throws SQLException {
+    public java.net.URL getURL(final int columnIndex) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public java.net.URL getURL(String columnName) throws SQLException {
+    public java.net.URL getURL(final String columnName) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateRef(int columnIndex, java.sql.Ref x)
+    public void updateRef(final int columnIndex, final java.sql.Ref x)
         throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateRef(String columnName, java.sql.Ref x)
+    public void updateRef(final String columnName, final java.sql.Ref x)
         throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateBlob(int columnIndex, java.sql.Blob x)
+    public void updateBlob(final int columnIndex, final java.sql.Blob x)
         throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateBlob(String columnName, java.sql.Blob x)
+    public void updateBlob(final String columnName, final java.sql.Blob x)
         throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateClob(int columnIndex, java.sql.Clob x)
+    public void updateClob(final int columnIndex, final java.sql.Clob x)
         throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateClob(String columnName, java.sql.Clob x)
+    public void updateClob(final String columnName, final java.sql.Clob x)
         throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateArray(int columnIndex, java.sql.Array x)
+    public void updateArray(final int columnIndex, final java.sql.Array x)
         throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateArray(String columnName, java.sql.Array x)
+    public void updateArray(final String columnName, final java.sql.Array x)
         throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
 
     @Override
-    public boolean isWrapperFor(Class<?> iface) throws SQLException {
+    public boolean isWrapperFor(final Class<?> iface) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public <T> T unwrap(Class<T> iface) throws SQLException {
+    public <T> T unwrap(final Class<T> iface) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public RowId getRowId(int columnIndex) throws SQLException {
+    public RowId getRowId(final int columnIndex) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public RowId getRowId(String columnLabel) throws SQLException {
+    public RowId getRowId(final String columnLabel) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateRowId(int columnIndex, RowId value) throws SQLException {
+    public void updateRowId(final int columnIndex, final RowId value) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateRowId(String columnLabel, RowId value) throws SQLException {
+    public void updateRowId(final String columnLabel, final RowId value) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
@@ -957,222 +957,222 @@ public SQLWarning getWarnings() throws S
     }
 
     @Override
-    public void updateNString(int columnIndex, String value) throws SQLException {
+    public void updateNString(final int columnIndex, final String value) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateNString(String columnLabel, String value) throws SQLException {
+    public void updateNString(final String columnLabel, final String value) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateNClob(int columnIndex, NClob value) throws SQLException {
+    public void updateNClob(final int columnIndex, final NClob value) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateNClob(String columnLabel, NClob value) throws SQLException {
+    public void updateNClob(final String columnLabel, final NClob value) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public NClob getNClob(int columnIndex) throws SQLException {
+    public NClob getNClob(final int columnIndex) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public NClob getNClob(String columnLabel) throws SQLException {
+    public NClob getNClob(final String columnLabel) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public SQLXML getSQLXML(int columnIndex) throws SQLException {
+    public SQLXML getSQLXML(final int columnIndex) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public SQLXML getSQLXML(String columnLabel) throws SQLException {
+    public SQLXML getSQLXML(final String columnLabel) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateSQLXML(int columnIndex, SQLXML value) throws SQLException {
+    public void updateSQLXML(final int columnIndex, final SQLXML value) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateSQLXML(String columnLabel, SQLXML value) throws SQLException {
+    public void updateSQLXML(final String columnLabel, final SQLXML value) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public String getNString(int columnIndex) throws SQLException {
+    public String getNString(final int columnIndex) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public String getNString(String columnLabel) throws SQLException {
+    public String getNString(final String columnLabel) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public Reader getNCharacterStream(int columnIndex) throws SQLException {
+    public Reader getNCharacterStream(final int columnIndex) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public Reader getNCharacterStream(String columnLabel) throws SQLException {
+    public Reader getNCharacterStream(final String columnLabel) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateNCharacterStream(int columnIndex, Reader reader, long length) throws SQLException {
+    public void updateNCharacterStream(final int columnIndex, final Reader reader, final long length) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateNCharacterStream(String columnLabel, Reader reader, long length) throws SQLException {
+    public void updateNCharacterStream(final String columnLabel, final Reader reader, final long length) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateAsciiStream(int columnIndex, InputStream inputStream, long length) throws SQLException {
+    public void updateAsciiStream(final int columnIndex, final InputStream inputStream, final long length) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateBinaryStream(int columnIndex, InputStream inputStream, long length) throws SQLException {
+    public void updateBinaryStream(final int columnIndex, final InputStream inputStream, final long length) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateCharacterStream(int columnIndex, Reader reader, long length) throws SQLException {
+    public void updateCharacterStream(final int columnIndex, final Reader reader, final long length) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateAsciiStream(String columnLabel, InputStream inputStream, long length) throws SQLException {
+    public void updateAsciiStream(final String columnLabel, final InputStream inputStream, final long length) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateBinaryStream(String columnLabel, InputStream inputStream, long length) throws SQLException {
+    public void updateBinaryStream(final String columnLabel, final InputStream inputStream, final long length) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateCharacterStream(String columnLabel, Reader reader, long length) throws SQLException {
+    public void updateCharacterStream(final String columnLabel, final Reader reader, final long length) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateBlob(int columnIndex, InputStream inputStream, long length) throws SQLException {
+    public void updateBlob(final int columnIndex, final InputStream inputStream, final long length) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateBlob(String columnLabel, InputStream inputStream, long length) throws SQLException {
+    public void updateBlob(final String columnLabel, final InputStream inputStream, final long length) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateClob(int columnIndex, Reader reader, long length) throws SQLException {
+    public void updateClob(final int columnIndex, final Reader reader, final long length) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateClob(String columnLabel, Reader reader, long length) throws SQLException {
+    public void updateClob(final String columnLabel, final Reader reader, final long length) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateNClob(int columnIndex, Reader reader, long length) throws SQLException {
+    public void updateNClob(final int columnIndex, final Reader reader, final long length) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateNClob(String columnLabel, Reader reader, long length) throws SQLException {
+    public void updateNClob(final String columnLabel, final Reader reader, final long length) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateNCharacterStream(int columnIndex, Reader reader) throws SQLException {
+    public void updateNCharacterStream(final int columnIndex, final Reader reader) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateNCharacterStream(String columnLabel, Reader reader) throws SQLException {
+    public void updateNCharacterStream(final String columnLabel, final Reader reader) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateAsciiStream(int columnIndex, InputStream inputStream) throws SQLException {
+    public void updateAsciiStream(final int columnIndex, final InputStream inputStream) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateBinaryStream(int columnIndex, InputStream inputStream) throws SQLException {
+    public void updateBinaryStream(final int columnIndex, final InputStream inputStream) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateCharacterStream(int columnIndex, Reader reader) throws SQLException {
+    public void updateCharacterStream(final int columnIndex, final Reader reader) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateAsciiStream(String columnLabel, InputStream inputStream) throws SQLException {
+    public void updateAsciiStream(final String columnLabel, final InputStream inputStream) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateBinaryStream(String columnLabel, InputStream inputStream) throws SQLException {
+    public void updateBinaryStream(final String columnLabel, final InputStream inputStream) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateCharacterStream(String columnLabel, Reader reader) throws SQLException {
+    public void updateCharacterStream(final String columnLabel, final Reader reader) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateBlob(int columnIndex, InputStream inputStream) throws SQLException {
+    public void updateBlob(final int columnIndex, final InputStream inputStream) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateBlob(String columnLabel, InputStream inputStream) throws SQLException {
+    public void updateBlob(final String columnLabel, final InputStream inputStream) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateClob(int columnIndex, Reader reader) throws SQLException {
+    public void updateClob(final int columnIndex, final Reader reader) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateClob(String columnLabel, Reader reader) throws SQLException {
+    public void updateClob(final String columnLabel, final Reader reader) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateNClob(int columnIndex, Reader reader) throws SQLException {
+    public void updateNClob(final int columnIndex, final Reader reader) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public void updateNClob(String columnLabel, Reader reader) throws SQLException {
+    public void updateNClob(final String columnLabel, final Reader reader) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public <T> T getObject(int columnIndex, Class<T> type) throws SQLException {
+    public <T> T getObject(final int columnIndex, final Class<T> type) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public <T> T getObject(String columnLabel, Class<T> type)
+    public <T> T getObject(final String columnLabel, final Class<T> type)
             throws SQLException {
         throw new SQLException("Not implemented.");
     }

Modified: commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterStatement.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterStatement.java?rev=1729277&r1=1729276&r2=1729277&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterStatement.java (original)
+++ commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterStatement.java Mon Feb  8 21:58:41 2016
@@ -31,11 +31,11 @@ import java.sql.Statement;
  * @version $Id$
  */
 public class TesterStatement implements Statement {
-    public TesterStatement(Connection conn) {
+    public TesterStatement(final Connection conn) {
         _connection = conn;
     }
 
-    public TesterStatement(Connection conn, int resultSetType, int resultSetConcurrency) {
+    public TesterStatement(final Connection conn, final int resultSetType, final int resultSetConcurrency) {
         _connection = conn;
         _resultSetType = resultSetType;
         _resultSetConcurrency = resultSetConcurrency;
@@ -57,7 +57,7 @@ public class TesterStatement implements
     protected ResultSet _resultSet = null;
 
     @Override
-    public ResultSet executeQuery(String sql) throws SQLException {
+    public ResultSet executeQuery(final String sql) throws SQLException {
         checkOpen();
         if("null".equals(sql)) {
             return null;
@@ -82,7 +82,7 @@ public class TesterStatement implements
     }
 
     @Override
-    public int executeUpdate(String sql) throws SQLException {
+    public int executeUpdate(final String sql) throws SQLException {
         checkOpen();
         return _rowsUpdated;
     }
@@ -108,7 +108,7 @@ public class TesterStatement implements
     }
 
     @Override
-    public void setMaxFieldSize(int max) throws SQLException {
+    public void setMaxFieldSize(final int max) throws SQLException {
         checkOpen();
         _maxFieldSize = max;
     }
@@ -120,13 +120,13 @@ public class TesterStatement implements
     }
 
     @Override
-    public void setMaxRows(int max) throws SQLException {
+    public void setMaxRows(final int max) throws SQLException {
         checkOpen();
         _maxRows = max;
     }
 
     @Override
-    public void setEscapeProcessing(boolean enable) throws SQLException {
+    public void setEscapeProcessing(final boolean enable) throws SQLException {
         checkOpen();
         _escapeProcessing = enable;
     }
@@ -138,7 +138,7 @@ public class TesterStatement implements
     }
 
     @Override
-    public void setQueryTimeout(int seconds) throws SQLException {
+    public void setQueryTimeout(final int seconds) throws SQLException {
         checkOpen();
         _queryTimeout = seconds;
     }
@@ -160,13 +160,13 @@ public class TesterStatement implements
     }
 
     @Override
-    public void setCursorName(String name) throws SQLException {
+    public void setCursorName(final String name) throws SQLException {
         checkOpen();
         _cursorName = name;
     }
 
     @Override
-    public boolean execute(String sql) throws SQLException {
+    public boolean execute(final String sql) throws SQLException {
         checkOpen();
         if("invalid".equals(sql)) {
             throw new SQLException("invalid query");
@@ -196,7 +196,7 @@ public class TesterStatement implements
     }
 
     @Override
-    public void setFetchDirection(int direction) throws SQLException {
+    public void setFetchDirection(final int direction) throws SQLException {
         checkOpen();
         _fetchDirection = direction;
     }
@@ -208,7 +208,7 @@ public class TesterStatement implements
     }
 
     @Override
-    public void setFetchSize(int rows) throws SQLException {
+    public void setFetchSize(final int rows) throws SQLException {
         checkOpen();
         _fetchSize = rows;
     }
@@ -232,7 +232,7 @@ public class TesterStatement implements
     }
 
     @Override
-    public void addBatch(String sql) throws SQLException {
+    public void addBatch(final String sql) throws SQLException {
         checkOpen();
     }
 
@@ -260,7 +260,7 @@ public class TesterStatement implements
     }
 
     @Override
-    public boolean getMoreResults(int current) throws SQLException {
+    public boolean getMoreResults(final int current) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
@@ -270,37 +270,37 @@ public class TesterStatement implements
     }
 
     @Override
-    public int executeUpdate(String sql, int autoGeneratedKeys)
+    public int executeUpdate(final String sql, final int autoGeneratedKeys)
         throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public int executeUpdate(String sql, int columnIndexes[])
+    public int executeUpdate(final String sql, final int columnIndexes[])
         throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public int executeUpdate(String sql, String columnNames[])
+    public int executeUpdate(final String sql, final String columnNames[])
         throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public boolean execute(String sql, int autoGeneratedKeys)
+    public boolean execute(final String sql, final int autoGeneratedKeys)
         throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public boolean execute(String sql, int columnIndexes[])
+    public boolean execute(final String sql, final int columnIndexes[])
         throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public boolean execute(String sql, String columnNames[])
+    public boolean execute(final String sql, final String columnNames[])
         throws SQLException {
         throw new SQLException("Not implemented.");
     }
@@ -313,12 +313,12 @@ public class TesterStatement implements
 
 
     @Override
-    public boolean isWrapperFor(Class<?> iface) throws SQLException {
+    public boolean isWrapperFor(final Class<?> iface) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
     @Override
-    public <T> T unwrap(Class<T> iface) throws SQLException {
+    public <T> T unwrap(final Class<T> iface) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 
@@ -328,7 +328,7 @@ public class TesterStatement implements
     }
 
     @Override
-    public void setPoolable(boolean poolable) throws SQLException {
+    public void setPoolable(final boolean poolable) throws SQLException {
         throw new SQLException("Not implemented.");
     }
 

Modified: commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterUtils.java?rev=1729277&r1=1729276&r2=1729277&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterUtils.java (original)
+++ commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterUtils.java Mon Feb  8 21:58:41 2016
@@ -28,7 +28,7 @@ public class TesterUtils {
      * Access a private field. Do it this way rather than increasing the
      * visibility of the field in the public API.
      */
-    public static Object getField(Object target, String fieldName)
+    public static Object getField(final Object target, final String fieldName)
             throws Exception {
         final Class<?> clazz = target.getClass();
         final Field f = clazz.getDeclaredField(fieldName);

Modified: commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/cpdsadapter/TestDriverAdapterCPDS.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/cpdsadapter/TestDriverAdapterCPDS.java?rev=1729277&r1=1729276&r2=1729277&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/cpdsadapter/TestDriverAdapterCPDS.java (original)
+++ commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/cpdsadapter/TestDriverAdapterCPDS.java Mon Feb  8 21:58:41 2016
@@ -216,7 +216,7 @@ public class TestDriverAdapterCPDS {
 
         private volatile boolean failed = false;
 
-        public ThreadDbcp367(DataSource ds) {
+        public ThreadDbcp367(final DataSource ds) {
             this.ds = ds;
         }
 

Modified: commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/ConnectionPoolDataSourceProxy.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/ConnectionPoolDataSourceProxy.java?rev=1729277&r1=1729276&r2=1729277&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/ConnectionPoolDataSourceProxy.java (original)
+++ commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/ConnectionPoolDataSourceProxy.java Mon Feb  8 21:58:41 2016
@@ -35,7 +35,7 @@ public class ConnectionPoolDataSourcePro
 
     protected ConnectionPoolDataSource delegate = null;
     
-    public ConnectionPoolDataSourceProxy(ConnectionPoolDataSource cpds) {
+    public ConnectionPoolDataSourceProxy(final ConnectionPoolDataSource cpds) {
         this.delegate = cpds;
     }
     
@@ -65,18 +65,18 @@ public class ConnectionPoolDataSourcePro
      * Return a TesterPooledConnection with notifyOnClose turned on
      */
     @Override
-    public PooledConnection getPooledConnection(String user, String password)
+    public PooledConnection getPooledConnection(final String user, final String password)
             throws SQLException {
         return wrapPooledConnection(delegate.getPooledConnection(user, password));
     }
 
     @Override
-    public void setLoginTimeout(int seconds) throws SQLException {
+    public void setLoginTimeout(final int seconds) throws SQLException {
         delegate.setLoginTimeout(seconds);     
     }
 
     @Override
-    public void setLogWriter(PrintWriter out) throws SQLException {
+    public void setLogWriter(final PrintWriter out) throws SQLException {
         delegate.setLogWriter(out);     
     }
     
@@ -88,7 +88,7 @@ public class ConnectionPoolDataSourcePro
     /**
      * Create a TesterPooledConnection with notifyOnClose turned on
      */
-    protected PooledConnection wrapPooledConnection(PooledConnection pc) {
+    protected PooledConnection wrapPooledConnection(final PooledConnection pc) {
         final PooledConnectionProxy tpc = new PooledConnectionProxy(pc);
         tpc.setNotifyOnClose(true);
         return tpc; 

Modified: commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/PooledConnectionProxy.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/PooledConnectionProxy.java?rev=1729277&r1=1729276&r2=1729277&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/PooledConnectionProxy.java (original)
+++ commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/PooledConnectionProxy.java Mon Feb  8 21:58:41 2016
@@ -52,7 +52,7 @@ public class PooledConnectionProxy imple
      */
     private boolean notifyOnClose = false;
     
-    public PooledConnectionProxy(PooledConnection pooledConnection) {
+    public PooledConnectionProxy(final PooledConnection pooledConnection) {
         this.delegate = pooledConnection;
         pooledConnection.addConnectionEventListener(this);
     }
@@ -77,13 +77,13 @@ public class PooledConnectionProxy imple
      * Remove event listeners.
      */
     @Override
-    public void removeConnectionEventListener(ConnectionEventListener listener) {
+    public void removeConnectionEventListener(final ConnectionEventListener listener) {
         eventListeners.remove(listener);
     }
 
     /* JDBC_4_ANT_KEY_BEGIN */
     @Override
-    public void removeStatementEventListener(StatementEventListener listener) {
+    public void removeStatementEventListener(final StatementEventListener listener) {
         eventListeners.remove(listener);
     }
     /* JDBC_4_ANT_KEY_END */
@@ -92,7 +92,7 @@ public class PooledConnectionProxy imple
         return notifyOnClose;
     }
 
-    public void setNotifyOnClose(boolean notifyOnClose) {
+    public void setNotifyOnClose(final boolean notifyOnClose) {
         this.notifyOnClose = notifyOnClose;
     }
     
@@ -111,7 +111,7 @@ public class PooledConnectionProxy imple
      * Add event listeners.
      */
     @Override
-    public void addConnectionEventListener(ConnectionEventListener listener) {
+    public void addConnectionEventListener(final ConnectionEventListener listener) {
         if (!eventListeners.contains(listener)) {
             eventListeners.add(listener);
         }
@@ -119,7 +119,7 @@ public class PooledConnectionProxy imple
 
     /* JDBC_4_ANT_KEY_BEGIN */
     @Override
-    public void addStatementEventListener(StatementEventListener listener) {
+    public void addStatementEventListener(final StatementEventListener listener) {
         if (!eventListeners.contains(listener)) {
             eventListeners.add(listener);
         }
@@ -130,7 +130,7 @@ public class PooledConnectionProxy imple
      * Pass closed events on to listeners
      */
     @Override
-    public void connectionClosed(ConnectionEvent event) {
+    public void connectionClosed(final ConnectionEvent event) {
         notifyListeners();    
     }
 
@@ -138,7 +138,7 @@ public class PooledConnectionProxy imple
      * Pass error events on to listeners
      */ 
     @Override
-    public void connectionErrorOccurred(ConnectionEvent event) {
+    public void connectionErrorOccurred(final ConnectionEvent event) {
         final Object[] listeners = eventListeners.toArray();
         for (final Object listener : listeners) {
             ((ConnectionEventListener) listener).connectionErrorOccurred(event);

Modified: commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/TestInstanceKeyDataSource.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/TestInstanceKeyDataSource.java?rev=1729277&r1=1729276&r2=1729277&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/TestInstanceKeyDataSource.java (original)
+++ commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/TestInstanceKeyDataSource.java Mon Feb  8 21:58:41 2016
@@ -66,7 +66,7 @@ public class TestInstanceKeyDataSource {
             super();
         }
         @Override
-        protected void setupDefaults(Connection con, String username)
+        protected void setupDefaults(final Connection con, final String username)
         throws  SQLException {
             throw new SQLException("bang!");
         }

Modified: commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/TestSharedPoolDataSource.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/TestSharedPoolDataSource.java?rev=1729277&r1=1729276&r2=1729277&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/TestSharedPoolDataSource.java (original)
+++ commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/TestSharedPoolDataSource.java Mon Feb  8 21:58:41 2016
@@ -418,7 +418,7 @@ public class TestSharedPoolDataSource ex
     // complexity to reduce what would otherwise be lots of copy and paste
     private static abstract class PrepareStatementCallback {
         protected Connection conn;
-        void setConnection(Connection conn) {
+        void setConnection(final Connection conn) {
             this.conn = conn;
         }
         abstract PreparedStatement getPreparedStatement() throws SQLException;
@@ -459,7 +459,7 @@ public class TestSharedPoolDataSource ex
             return conn.prepareStatement("select * from dual",0,0,0);
         }
     }
-    private void doTestPoolPreparedStatements(PrepareStatementCallback callBack)
+    private void doTestPoolPreparedStatements(final PrepareStatementCallback callBack)
     throws Exception {
         final DriverAdapterCPDS mypcds = new DriverAdapterCPDS();
         DataSource myds = null;

Modified: commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/managed/TestDataSourceXAConnectionFactory.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/managed/TestDataSourceXAConnectionFactory.java?rev=1729277&r1=1729276&r2=1729277&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/managed/TestDataSourceXAConnectionFactory.java (original)
+++ commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/managed/TestDataSourceXAConnectionFactory.java Mon Feb  8 21:58:41 2016
@@ -66,7 +66,7 @@ public class TestDataSourceXAConnectionF
     public class XADataSourceHandle implements InvocationHandler {
 
         @Override
-        public Object invoke(Object proxy, Method method, Object[] args)
+        public Object invoke(final Object proxy, final Method method, final Object[] args)
                 throws Throwable {
             final String methodName = method.getName();
             if (methodName.equals("hashCode")) {

Modified: commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/managed/TestManagedConnection.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/managed/TestManagedConnection.java?rev=1729277&r1=1729276&r2=1729277&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/managed/TestManagedConnection.java (original)
+++ commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/managed/TestManagedConnection.java Mon Feb  8 21:58:41 2016
@@ -122,7 +122,7 @@ public class TestManagedConnection {
     private class UncooperativeLocalXAConnectionFactory
         extends LocalXAConnectionFactory {
 
-        public UncooperativeLocalXAConnectionFactory(TransactionManager transactionManager, ConnectionFactory connectionFactory) {
+        public UncooperativeLocalXAConnectionFactory(final TransactionManager transactionManager, final ConnectionFactory connectionFactory) {
             super(transactionManager, connectionFactory);
 
             try {
@@ -139,7 +139,7 @@ public class TestManagedConnection {
     private class UncooperativeTransactionRegistry
         extends TransactionRegistry {
 
-        public UncooperativeTransactionRegistry(TransactionManager transactionManager) {
+        public UncooperativeTransactionRegistry(final TransactionManager transactionManager) {
             super(transactionManager);
         }
 
@@ -163,7 +163,7 @@ public class TestManagedConnection {
 
         private final Transaction wrappedTransaction;
 
-        public UncooperativeTransaction(Transaction transaction) {
+        public UncooperativeTransaction(final Transaction transaction) {
             this.wrappedTransaction = transaction;
         }
 
@@ -175,7 +175,7 @@ public class TestManagedConnection {
         }
 
         @Override
-        public boolean delistResource(XAResource arg0, int arg1)
+        public boolean delistResource(final XAResource arg0, final int arg1)
             throws IllegalStateException, SystemException {
             return wrappedTransaction.delistResource(arg0, arg1);
         }
@@ -187,7 +187,7 @@ public class TestManagedConnection {
         }
 
         @Override
-        public void registerSynchronization(Synchronization arg0)
+        public void registerSynchronization(final Synchronization arg0)
             throws IllegalStateException, RollbackException, SystemException {
             wrappedTransaction.registerSynchronization(arg0);
         }
@@ -205,7 +205,7 @@ public class TestManagedConnection {
         }
 
         @Override
-        public synchronized boolean enlistResource(XAResource xaRes) {
+        public synchronized boolean enlistResource(final XAResource xaRes) {
             return false;
         }
     }

Modified: commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/managed/TestManagedDataSourceInTx.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/managed/TestManagedDataSourceInTx.java?rev=1729277&r1=1729276&r2=1729277&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/managed/TestManagedDataSourceInTx.java (original)
+++ commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/managed/TestManagedDataSourceInTx.java Mon Feb  8 21:58:41 2016
@@ -333,7 +333,7 @@ public class TestManagedDataSourceInTx e
 
     // can't actually test close in a transaction
     @Override
-    protected void assertBackPointers(Connection conn, Statement statement) throws SQLException {
+    protected void assertBackPointers(final Connection conn, final Statement statement) throws SQLException {
         assertFalse(conn.isClosed());
         assertFalse(isClosed(statement));
 

Modified: commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/managed/TestTransactionContext.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/managed/TestTransactionContext.java?rev=1729277&r1=1729276&r2=1729277&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/managed/TestTransactionContext.java (original)
+++ commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/managed/TestTransactionContext.java Mon Feb  8 21:58:41 2016
@@ -57,7 +57,7 @@ public class TestTransactionContext {
             super(null, null);
         }
         @Override
-        public synchronized boolean enlistResource(XAResource xaRes) {
+        public synchronized boolean enlistResource(final XAResource xaRes) {
             return false;
         }
     }

Modified: commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/managed/TesterBasicXAConnection.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/managed/TesterBasicXAConnection.java?rev=1729277&r1=1729276&r2=1729277&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/managed/TesterBasicXAConnection.java (original)
+++ commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/managed/TesterBasicXAConnection.java Mon Feb  8 21:58:41 2016
@@ -50,12 +50,12 @@ public class TesterBasicXAConnection imp
 
     public AtomicInteger closeCounter;
 
-    public TesterBasicXAConnection(Connection conn, AtomicInteger closeCounter) {
+    public TesterBasicXAConnection(final Connection conn, final AtomicInteger closeCounter) {
         this.conn = conn;
         this.closeCounter = closeCounter;
     }
 
-    public TesterBasicXAConnection(Connection conn) {
+    public TesterBasicXAConnection(final Connection conn) {
         this(conn, null);
     }
 
@@ -117,23 +117,23 @@ public class TesterBasicXAConnection imp
 
     @Override
     public void addConnectionEventListener(
-            ConnectionEventListener connectionEventListener) {
+            final ConnectionEventListener connectionEventListener) {
         listeners.add(connectionEventListener);
     }
 
     @Override
     public void removeConnectionEventListener(
-            ConnectionEventListener connectionEventListener) {
+            final ConnectionEventListener connectionEventListener) {
         listeners.remove(connectionEventListener);
     }
 
     @Override
-    public void addStatementEventListener(StatementEventListener listener) {
+    public void addStatementEventListener(final StatementEventListener listener) {
         throw new UnsupportedOperationException();
     }
 
     @Override
-    public void removeStatementEventListener(StatementEventListener listener) {
+    public void removeStatementEventListener(final StatementEventListener listener) {
         throw new UnsupportedOperationException();
     }
 
@@ -146,7 +146,7 @@ public class TesterBasicXAConnection imp
         }
     }
 
-    protected void notifyConnectionErrorOccurred(SQLException e) {
+    protected void notifyConnectionErrorOccurred(final SQLException e) {
         final ConnectionEvent event = new ConnectionEvent(this, e);
         final List<ConnectionEventListener> copy = new ArrayList<>(
                 listeners);
@@ -165,13 +165,13 @@ public class TesterBasicXAConnection imp
 
         public TesterBasicXAConnection xaconn;
 
-        public ConnectionHandle(Connection conn, TesterBasicXAConnection xaconn) {
+        public ConnectionHandle(final Connection conn, final TesterBasicXAConnection xaconn) {
             this.conn = conn;
             this.xaconn = xaconn;
         }
 
         @Override
-        public Object invoke(Object proxy, Method method, Object[] args)
+        public Object invoke(final Object proxy, final Method method, final Object[] args)
                 throws Throwable {
             final String methodName = method.getName();
             if (methodName.equals("hashCode")) {