[GitHub] [kyuubi] iodone commented on a diff in pull request #4232: [KYUUBI #3935] Support use Trino client to submit SQL

["iodone (via GitHub)" <gi...@apache.org>]

iodone commented on code in PR #4232:
URL: https://github.com/apache/kyuubi/pull/4232#discussion_r1099620386


##########
kyuubi-common/src/main/scala/org/apache/kyuubi/service/BackendService.scala:
##########
@@ -91,7 +91,7 @@ trait BackendService {
       foreignTable: String): OperationHandle
   def getQueryId(operationHandle: OperationHandle): String
 
-  def getOperationStatus(operationHandle: OperationHandle): OperationStatus
+  def getOperationStatus(operationHandle: OperationHandle, maxWait: Long = 0): OperationStatus

Review Comment:
   `Backendservice` mixed with `BackendServiceMetric`, using multiple inheritance to implement the metric getting wrapper, must have the same parent class. Adding a method will cause a `BackenServiceMetric` compilation error



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org