You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "DL1231 (via GitHub)" <gi...@apache.org> on 2024/08/29 13:55:27 UTC
[PR] KAFKA-14772: Add ConsumerGroupHeartbeat and ConsumerGroupDescribe API to AuthorizerIntegrationTest [kafka]
DL1231 opened a new pull request, #17044:
URL: https://github.com/apache/kafka/pull/17044
The patch adds `ConsumerGroupHeartbeat` and `ConsumerGroupDescribe` API to `AuthorizerIntegrationTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-14772: Add ConsumerGroupHeartbeat and ConsumerGroupDescribe API to AuthorizerIntegrationTest [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on PR #17044:
URL: https://github.com/apache/kafka/pull/17044#issuecomment-2335169052
@DL1231 Thanks for the patch. Could you please rebase to include https://github.com/apache/kafka/commit/9abb8d3b3cbc2bc862d894726cb0aca0b11fe518 and adapt your patch accordingly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-14772: Add ConsumerGroupHeartbeat and ConsumerGroupDescribe API to AuthorizerIntegrationTest [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on code in PR #17044:
URL: https://github.com/apache/kafka/pull/17044#discussion_r1749891577
##########
core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala:
##########
@@ -203,7 +203,10 @@ class AuthorizerIntegrationTest extends AbstractAuthorizerIntegrationTest {
.transactionStates.asScala.find(_.transactionalId == transactionalId).get
.errorCode
)
- })
+ }),
+ ApiKeys.CONSUMER_GROUP_HEARTBEAT -> ((resp: ConsumerGroupHeartbeatResponse) => Errors.forCode(resp.data.errorCode)),
+ ApiKeys.CONSUMER_GROUP_DESCRIBE -> ((resp: ConsumerGroupDescribeResponse) => Errors.forCode(
+ resp.data.groups.get(0).errorCode))
Review Comment:
For DescribeGroup API, we use the following:
```
ApiKeys.DESCRIBE_GROUPS -> ((resp: DescribeGroupsResponse) => {
Errors.forCode(resp.data.groups.asScala.find(g => group == g.groupId).head.errorCode)
}),
```
Do we need to do the same instead of always getting from index 0?
##########
core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala:
##########
@@ -741,6 +756,10 @@ class AuthorizerIntegrationTest extends AbstractAuthorizerIntegrationTest {
requestKeyToRequest += ApiKeys.STOP_REPLICA -> stopReplicaRequest
requestKeyToRequest += ApiKeys.CONTROLLED_SHUTDOWN -> controlledShutdownRequest
}
+ if (isKRaftTest()) {
Review Comment:
nit: Could we combine with the previous if?
```
if (isKRaftTest()) {
...
} else {
...
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-14772: Add ConsumerGroupHeartbeat and ConsumerGroupDescribe API to AuthorizerIntegrationTest [kafka]
Posted by "DL1231 (via GitHub)" <gi...@apache.org>.
DL1231 commented on PR #17044:
URL: https://github.com/apache/kafka/pull/17044#issuecomment-2323619774
@dajac PTAL when you get a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-14772: Add ConsumerGroupHeartbeat and ConsumerGroupDescribe API to AuthorizerIntegrationTest [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac merged PR #17044:
URL: https://github.com/apache/kafka/pull/17044
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org