You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@parquet.apache.org by ga...@apache.org on 2018/06/26 07:38:27 UTC

[parquet-mr] branch master updated: PARQUET-1336: PrimitiveComparator should implements Serializable (#497)

This is an automated email from the ASF dual-hosted git repository.

gabor pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/parquet-mr.git


The following commit(s) were added to refs/heads/master by this push:
     new dc61e51  PARQUET-1336: PrimitiveComparator should implements Serializable (#497)
dc61e51 is described below

commit dc61e510126aaa1a95a46fe39bf1529f394147e9
Author: Yuming Wang <wg...@gmail.com>
AuthorDate: Tue Jun 26 15:38:23 2018 +0800

    PARQUET-1336: PrimitiveComparator should implements Serializable (#497)
---
 .../src/main/java/org/apache/parquet/schema/PrimitiveComparator.java  | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/parquet-column/src/main/java/org/apache/parquet/schema/PrimitiveComparator.java b/parquet-column/src/main/java/org/apache/parquet/schema/PrimitiveComparator.java
index 085a67a..5e9adbc 100644
--- a/parquet-column/src/main/java/org/apache/parquet/schema/PrimitiveComparator.java
+++ b/parquet-column/src/main/java/org/apache/parquet/schema/PrimitiveComparator.java
@@ -20,6 +20,7 @@ package org.apache.parquet.schema;
 
 import org.apache.parquet.io.api.Binary;
 
+import java.io.Serializable;
 import java.nio.ByteBuffer;
 import java.util.Comparator;
 
@@ -27,8 +28,9 @@ import java.util.Comparator;
  * {@link Comparator} implementation that also supports the comparison of the related primitive type to avoid the
  * performance penalty of boxing/unboxing. The {@code compare} methods for the not supported primitive types throw
  * {@link UnsupportedOperationException}.
+ * {@link Serializable} implementation that may be a UserDefinedPredicate defined this Comparator is their member variable.
  */
-public abstract class PrimitiveComparator<T> implements Comparator<T> {
+public abstract class PrimitiveComparator<T> implements Comparator<T>, Serializable {
 
   public int compare(boolean b1, boolean b2) {
     throw new UnsupportedOperationException(