You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ant.apache.org by bu...@apache.org on 2012/12/14 21:41:42 UTC
[Bug 54299] New: more efficient (and shorter) method calls in
FTP.makeRemoteDir
https://issues.apache.org/bugzilla/show_bug.cgi?id=54299
Bug ID: 54299
Summary: more efficient (and shorter) method calls in
FTP.makeRemoteDir
Product: Ant
Version: 1.8.4
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
Priority: P2
Component: Core
Assignee: notifications@ant.apache.org
Reporter: nistor1@illinois.edu
Classification: Unclassified
Created attachment 29759
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29759&action=edit
firstCall.diff
The problem appears in version 1.8.4 and in revision 1421898. I
attached a one-line patch (firstCall.diff) that fixes it.
In method "FTP.makeRemoteDir", there are two calls to
"dir.indexOf("/") == 0". These calls should be "dir.startsWith("/")".
The intent of the call is more explicit with "startsWith" than with
"indexOf(..) == 0". "startsWith" is also more efficient than
"indexOf", because "startsWith" tries to match only the start of the
string, while "indexOf" searches until the first occurrence.
There are many calls to "String.startsWith" in Ant (just like in the
proposed patch), for example, in methods "AntlibDefinition.setURI",
"AntClassLoader.isParentFirst", "ComponentHelper.checkNamespace",
"Execute.getVMSLogicals", "ExecTask.isPath", "Jar.writeIndexLikeList",
"Definer.makeResourceFromURI", "PathTokenizer.nextToken", etc.
I attached a second one-line patch (secondCall.diff) for the second
call.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 54299] more efficient (and shorter) method calls in
FTP.makeRemoteDir
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54299
Jesse Glick <jg...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |PatchAvailable
CC| |jglick@apache.org
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 54299] more efficient (and shorter) method calls in
FTP.makeRemoteDir
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54299
Antoine Levy-Lambert <an...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|1.9.0 |1.9.1
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 54299] more efficient (and shorter) method calls in
FTP.makeRemoteDir
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54299
--- Comment #1 from Adrian Nistor <ni...@illinois.edu> ---
Created attachment 29760
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29760&action=edit
secondCall.diff
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 54299] more efficient (and shorter) method calls in
FTP.makeRemoteDir
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54299
Antoine Levy-Lambert <an...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|1.8.4 |1.9.0
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 54299] more efficient (and shorter) method calls in
FTP.makeRemoteDir
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54299
Adrian Nistor <ni...@illinois.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nistor1@illinois.edu
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 54299] more efficient (and shorter) method calls in
FTP.makeRemoteDir
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54299
Stefan Bodewig <bo...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
Target Milestone|--- |1.9.4
--- Comment #2 from Stefan Bodewig <bo...@apache.org> ---
svn revision 1554813
--
You are receiving this mail because:
You are the assignee for the bug.