You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/07 20:15:54 UTC
[GitHub] [airflow] Taragolis opened a new pull request, #28204: Migrate remaining core sensors tests to `pytest`
Taragolis opened a new pull request, #28204:
URL: https://github.com/apache/airflow/pull/28204
Second attempt (first: #28177, which reverted by #28196) migration core sensors unittests TestCases in core to pytest
which also include fix for task_runners tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #28204: Migrate remaining core sensors tests to `pytest`
Posted by GitBox <gi...@apache.org>.
uranusjr commented on code in PR #28204:
URL: https://github.com/apache/airflow/pull/28204#discussion_r1042953033
##########
tests/sensors/test_external_task_sensor.py:
##########
@@ -242,20 +242,16 @@ def test_external_task_sensor_failed_states_as_success(self):
failed_states=["success"],
dag=self.dag,
)
- with self.assertLogs(op.log, level=logging.INFO) as cm:
- with pytest.raises(AirflowException) as ctx:
+ error_message = rf"Some of the external tasks \['{TEST_TASK_ID}'\] in DAG {TEST_DAG_ID} failed\."
+ with pytest.raises(AirflowException, match=error_message):
+ with caplog.at_level(logging.INFO, logger=op.log.name):
+ caplog.clear()
op.run(start_date=DEFAULT_DATE, end_date=DEFAULT_DATE, ignore_ti_state=True)
- assert (
- f"INFO:airflow.task.operators:Poking for tasks ['time_sensor_check'] "
- f"in dag unit_test_dag on {DEFAULT_DATE.isoformat()} ... " in cm.output
- )
- assert (
- str(ctx.value) == "Some of the external tasks "
- "['time_sensor_check'] in DAG "
- "unit_test_dag failed."
- )
+ assert (
+ f"Poking for tasks ['{TEST_TASK_ID}'] in dag {TEST_DAG_ID} on {DEFAULT_DATE.isoformat()} ... "
+ ) in caplog.messages
Review Comment:
This is missing the original exception check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on a diff in pull request #28204: Migrate remaining core sensors tests to `pytest`
Posted by GitBox <gi...@apache.org>.
Taragolis commented on code in PR #28204:
URL: https://github.com/apache/airflow/pull/28204#discussion_r1043019095
##########
tests/sensors/test_external_task_sensor.py:
##########
@@ -242,20 +242,16 @@ def test_external_task_sensor_failed_states_as_success(self):
failed_states=["success"],
dag=self.dag,
)
- with self.assertLogs(op.log, level=logging.INFO) as cm:
- with pytest.raises(AirflowException) as ctx:
+ error_message = rf"Some of the external tasks \['{TEST_TASK_ID}'\] in DAG {TEST_DAG_ID} failed\."
+ with pytest.raises(AirflowException, match=error_message):
+ with caplog.at_level(logging.INFO, logger=op.log.name):
+ caplog.clear()
op.run(start_date=DEFAULT_DATE, end_date=DEFAULT_DATE, ignore_ti_state=True)
- assert (
- f"INFO:airflow.task.operators:Poking for tasks ['time_sensor_check'] "
- f"in dag unit_test_dag on {DEFAULT_DATE.isoformat()} ... " in cm.output
- )
- assert (
- str(ctx.value) == "Some of the external tasks "
- "['time_sensor_check'] in DAG "
- "unit_test_dag failed."
- )
+ assert (
+ f"Poking for tasks ['{TEST_TASK_ID}'] in dag {TEST_DAG_ID} on {DEFAULT_DATE.isoformat()} ... "
+ ) in caplog.messages
Review Comment:
I've moved this check to the `match` argument of `pytest.raises` this is not 1-to-1 replacement because previously we use equal comparison.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #28204: Migrate remaining core sensors tests to `pytest`
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #28204:
URL: https://github.com/apache/airflow/pull/28204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #28204: Migrate remaining core sensors tests to `pytest`
Posted by GitBox <gi...@apache.org>.
uranusjr commented on code in PR #28204:
URL: https://github.com/apache/airflow/pull/28204#discussion_r1043025431
##########
tests/sensors/test_external_task_sensor.py:
##########
@@ -242,20 +242,16 @@ def test_external_task_sensor_failed_states_as_success(self):
failed_states=["success"],
dag=self.dag,
)
- with self.assertLogs(op.log, level=logging.INFO) as cm:
- with pytest.raises(AirflowException) as ctx:
+ error_message = rf"Some of the external tasks \['{TEST_TASK_ID}'\] in DAG {TEST_DAG_ID} failed\."
+ with pytest.raises(AirflowException, match=error_message):
+ with caplog.at_level(logging.INFO, logger=op.log.name):
+ caplog.clear()
op.run(start_date=DEFAULT_DATE, end_date=DEFAULT_DATE, ignore_ti_state=True)
- assert (
- f"INFO:airflow.task.operators:Poking for tasks ['time_sensor_check'] "
- f"in dag unit_test_dag on {DEFAULT_DATE.isoformat()} ... " in cm.output
- )
- assert (
- str(ctx.value) == "Some of the external tasks "
- "['time_sensor_check'] in DAG "
- "unit_test_dag failed."
- )
+ assert (
+ f"Poking for tasks ['{TEST_TASK_ID}'] in dag {TEST_DAG_ID} on {DEFAULT_DATE.isoformat()} ... "
+ ) in caplog.messages
Review Comment:
Ah OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #28204: Migrate remaining core sensors tests to `pytest`
Posted by GitBox <gi...@apache.org>.
uranusjr commented on code in PR #28204:
URL: https://github.com/apache/airflow/pull/28204#discussion_r1042953163
##########
tests/sensors/test_external_task_sensor.py:
##########
@@ -324,19 +322,18 @@ def test_external_task_sensor_failed_states_as_success_mulitple_task_ids(self):
failed_states=["success"],
dag=self.dag,
)
- with self.assertLogs(op.log, level=logging.INFO) as cm:
- with pytest.raises(AirflowException) as ctx:
+ error_message = (
+ rf"Some of the external tasks \['{TEST_TASK_ID}'\, \'{TEST_TASK_ID_ALTERNATE}\'] "
+ rf"in DAG {TEST_DAG_ID} failed\."
+ )
+ with pytest.raises(AirflowException, match=error_message):
+ with caplog.at_level(logging.INFO, logger=op.log.name):
+ caplog.clear()
op.run(start_date=DEFAULT_DATE, end_date=DEFAULT_DATE, ignore_ti_state=True)
- assert (
- f"INFO:airflow.task.operators:Poking for tasks "
- f"['time_sensor_check', 'time_sensor_check_alternate'] "
- f"in dag unit_test_dag on {DEFAULT_DATE.isoformat()} ... " in cm.output
- )
- assert (
- str(ctx.value) == "Some of the external tasks "
- "['time_sensor_check', 'time_sensor_check_alternate'] in DAG "
- "unit_test_dag failed."
- )
+ assert (
+ f"Poking for tasks ['{TEST_TASK_ID}', '{TEST_TASK_ID_ALTERNATE}'] "
+ f"in dag unit_test_dag on {DEFAULT_DATE.isoformat()} ... "
+ ) in caplog.messages
Review Comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28204: Migrate remaining core sensors tests to `pytest`
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28204:
URL: https://github.com/apache/airflow/pull/28204#issuecomment-1342690448
Now we are cooking with gas :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on pull request #28204: Migrate remaining core sensors tests to `pytest`
Posted by GitBox <gi...@apache.org>.
Taragolis commented on PR #28204:
URL: https://github.com/apache/airflow/pull/28204#issuecomment-1341537596
Locally it run successfully lets see how it deal in CI
```bash
root@60f341ac219e:/opt/airflow# pytest tests/task/task_runner tests/sensors/
...
================================ 130 passed, 2 skipped, 202 warnings in 65.90s (0:01:05) ================================
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org