[GitHub] [hadoop] xkrogen commented on a diff in pull request #5099: HDFS-16832. [SBN READ] Fix NPE when check the block location of empty…

[GitBox <gi...@apache.org>]

xkrogen commented on code in PR #5099:
URL: https://github.com/apache/hadoop/pull/5099#discussion_r1026650818


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java:
##########
@@ -9034,9 +9038,12 @@ private boolean isObserver() {
 
   private void checkBlockLocationsWhenObserver(LocatedBlocks blocks, String src)
       throws ObserverRetryOnActiveException {
-    for (LocatedBlock b : blocks.getLocatedBlocks()) {
-      if (b.getLocations() == null || b.getLocations().length == 0) {
-        throw new ObserverRetryOnActiveException("Zero blocklocations for " + src);
+    List<LocatedBlock> locatedBlockList = blocks.getLocatedBlocks();

Review Comment:
   minor nit (non-blocking): can we move the null-check for `blocks` inside of this method? Then we only need it one place instead of duplicated three times



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org