[GitHub] [maven] Marcono1234 commented on a change in pull request #641: [MNG-7374] Mutating RelocatedArtifact does not retain type

[GitBox <gi...@apache.org>]

Marcono1234 commented on a change in pull request #641:
URL: https://github.com/apache/maven/pull/641#discussion_r775184928



##########
File path: maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/RelocatedArtifact.java
##########
@@ -86,6 +86,39 @@ public String getVersion()
         }
     }
 
+    @Override
+    public Artifact setVersion( String version )
+    {
+         String current = getVersion();
+         if ( current.equals( version ) || ( version == null && current.length() <= 0 ) )

Review comment:
       Could this be simplified?
   ```suggestion
            if ( current.equals( version ) || ( version == null && current.isEmpty() ) )
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org