Re: [PR] [SPARK-48040][CONNECT]Spark connect supports scheduler pool [spark]

["HyukjinKwon (via GitHub)" <gi...@apache.org>]

HyukjinKwon commented on code in PR #46278:
URL: https://github.com/apache/spark/pull/46278#discussion_r1582812044


##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/execution/ExecuteThreadRunner.scala:
##########
@@ -177,6 +177,10 @@ private[connect] class ExecuteThreadRunner(executeHolder: ExecuteHolder) extends
         s"Spark Connect - ${StringUtils.abbreviate(debugString, 128)}")
       session.sparkContext.setInterruptOnCancel(true)
 
+      executeHolder.schedulerPool.foreach { pool =>
+        session.sparkContext.setLocalProperty(SparkContext.SPARK_SCHEDULER_POOL, pool)

Review Comment:
   This is a core conf so can't b set runtime. This has to be set when users run the Spark Connect server.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org