You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "Michal Mocny (JIRA)" <ji...@apache.org> on 2013/04/19 22:51:19 UTC

[jira] [Commented] (CB-3189) Reenable Android "should remove directory" uninstall tests after uninstall and prepare are sorted

    [ https://issues.apache.org/jira/browse/CB-3189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13636871#comment-13636871 ] 

Michal Mocny commented on CB-3189:
----------------------------------

There was discussion on the list, that it would be better to modify platform files as little as possible during install/uninstall and instead make sure the platforms are in a valid state after prepare.  E.g. its hard to know which permissions to remove during uninstall.

That particular example is solvable in other ways, but there are other reasons to do less (no?) modification of platform files on install/uninstall and just do it all in prepare, such as in-place plugin upgradeability.
                
> Reenable Android "should remove directory" uninstall tests after uninstall and prepare are sorted
> -------------------------------------------------------------------------------------------------
>
>                 Key: CB-3189
>                 URL: https://issues.apache.org/jira/browse/CB-3189
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugman
>            Reporter: Braden Shepherdson
>            Assignee: Braden Shepherdson
>
> These tests are currently disabled, because they were failing. This was due to prepare being run after uninstall. We need to figure out the right answer to this problem and then reenable the tests.
> I think the right answer is to only run prepare after installation, and make sure uninstall is removing assets and JS modules.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira