You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2014/05/10 04:49:56 UTC

Review Request 21300: AMBARI-5726. Adding Oozie failed at service check

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21300/
-----------------------------------------------------------

Review request for Ambari, Srimanth Gunturi and Yusaku Sako.


Bugs: AMBARI-5726
    https://issues.apache.org/jira/browse/AMBARI-5726


Repository: ambari


Description
-------

This happens because HDFS and YARN/MapReduce requires to be restarted for Oozie smoke test to pass successfully
As a fix to this issue:
1)Don't run smoke test on "Install, Start and Test" page of the add service wizard.
2) Review page should ask user to restart all stale services.

Apart from the above mentioned fixes, the patch also makes sure that Add service wizard just starts services that are selected in the "Add service wizard" instead of starting all services in INSTALLED state. Earlier I discovered that if we have stopped services in the cluster and try to add a new service then along with the new added services other stopped service are also started by the wizard.


Diffs
-----


Diff: https://reviews.apache.org/r/21300/diff/


Testing
-------

Tested the patch on a cluster with ambari-1.6.0 branch bits.


Thanks,

Jaimin Jetly


Re: Review Request 21300: AMBARI-5726. Adding Oozie failed at service check

Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21300/#review42630
-----------------------------------------------------------

Ship it!


Ship It!

- Yusaku Sako


On May 10, 2014, 3:05 a.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21300/
> -----------------------------------------------------------
> 
> (Updated May 10, 2014, 3:05 a.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
> 
> 
> Bugs: AMBARI-5726
>     https://issues.apache.org/jira/browse/AMBARI-5726
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This happens because HDFS and YARN/MapReduce requires to be restarted for Oozie smoke test to pass successfully
> As a fix to this issue:
> 1)Don't run smoke test on "Install, Start and Test" page of the add service wizard.
> 2) Review page should ask user to restart all stale services.
> 
> Apart from the above mentioned fixes, the patch also makes sure that Add service wizard just starts services that are selected in the "Add service wizard" instead of starting all services in INSTALLED state. Earlier I discovered that if we have stopped services in the cluster and try to add a new service then along with the new added services other stopped service are also started by the wizard.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/messages.js bf1cab9 
> 
> Diff: https://reviews.apache.org/r/21300/diff/
> 
> 
> Testing
> -------
> 
> Tested the patch on a cluster with ambari-1.6.0 branch bits.
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>


Re: Review Request 21300: AMBARI-5726. Adding Oozie failed at service check

Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21300/
-----------------------------------------------------------

(Updated May 10, 2014, 3:05 a.m.)


Review request for Ambari, Srimanth Gunturi and Yusaku Sako.


Changes
-------

message change corrected "needs to be" to "need to be"


Bugs: AMBARI-5726
    https://issues.apache.org/jira/browse/AMBARI-5726


Repository: ambari


Description
-------

This happens because HDFS and YARN/MapReduce requires to be restarted for Oozie smoke test to pass successfully
As a fix to this issue:
1)Don't run smoke test on "Install, Start and Test" page of the add service wizard.
2) Review page should ask user to restart all stale services.

Apart from the above mentioned fixes, the patch also makes sure that Add service wizard just starts services that are selected in the "Add service wizard" instead of starting all services in INSTALLED state. Earlier I discovered that if we have stopped services in the cluster and try to add a new service then along with the new added services other stopped service are also started by the wizard.


Diffs (updated)
-----

  ambari-web/app/messages.js bf1cab9 

Diff: https://reviews.apache.org/r/21300/diff/


Testing
-------

Tested the patch on a cluster with ambari-1.6.0 branch bits.


Thanks,

Jaimin Jetly


Re: Review Request 21300: AMBARI-5726. Adding Oozie failed at service check

Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21300/#review42629
-----------------------------------------------------------



ambari-web/app/messages.js
<https://reviews.apache.org/r/21300/#comment76457>

    "needs to beed" should be "need to be"


- Yusaku Sako


On May 10, 2014, 2:50 a.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21300/
> -----------------------------------------------------------
> 
> (Updated May 10, 2014, 2:50 a.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
> 
> 
> Bugs: AMBARI-5726
>     https://issues.apache.org/jira/browse/AMBARI-5726
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This happens because HDFS and YARN/MapReduce requires to be restarted for Oozie smoke test to pass successfully
> As a fix to this issue:
> 1)Don't run smoke test on "Install, Start and Test" page of the add service wizard.
> 2) Review page should ask user to restart all stale services.
> 
> Apart from the above mentioned fixes, the patch also makes sure that Add service wizard just starts services that are selected in the "Add service wizard" instead of starting all services in INSTALLED state. Earlier I discovered that if we have stopped services in the cluster and try to add a new service then along with the new added services other stopped service are also started by the wizard.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/wizard/step10_controller.js c73f403 
>   ambari-web/app/controllers/wizard/step9_controller.js 8494a87 
>   ambari-web/app/messages.js bf1cab9 
>   ambari-web/app/styles/application.less 7599c7f 
>   ambari-web/app/templates/main/host/details/doDeleteHostPopup.hbs 124409e 
>   ambari-web/app/templates/wizard/step10.hbs 80afa5c 
>   ambari-web/app/utils/ajax/ajax.js 54777da 
>   ambari-web/app/views/wizard/step10_view.js a48353b 
> 
> Diff: https://reviews.apache.org/r/21300/diff/
> 
> 
> Testing
> -------
> 
> Tested the patch on a cluster with ambari-1.6.0 branch bits.
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>


Re: Review Request 21300: AMBARI-5726. Adding Oozie failed at service check

Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21300/
-----------------------------------------------------------

(Updated May 10, 2014, 2:50 a.m.)


Review request for Ambari, Srimanth Gunturi and Yusaku Sako.


Bugs: AMBARI-5726
    https://issues.apache.org/jira/browse/AMBARI-5726


Repository: ambari


Description
-------

This happens because HDFS and YARN/MapReduce requires to be restarted for Oozie smoke test to pass successfully
As a fix to this issue:
1)Don't run smoke test on "Install, Start and Test" page of the add service wizard.
2) Review page should ask user to restart all stale services.

Apart from the above mentioned fixes, the patch also makes sure that Add service wizard just starts services that are selected in the "Add service wizard" instead of starting all services in INSTALLED state. Earlier I discovered that if we have stopped services in the cluster and try to add a new service then along with the new added services other stopped service are also started by the wizard.


Diffs (updated)
-----

  ambari-web/app/controllers/wizard/step10_controller.js c73f403 
  ambari-web/app/controllers/wizard/step9_controller.js 8494a87 
  ambari-web/app/messages.js bf1cab9 
  ambari-web/app/styles/application.less 7599c7f 
  ambari-web/app/templates/main/host/details/doDeleteHostPopup.hbs 124409e 
  ambari-web/app/templates/wizard/step10.hbs 80afa5c 
  ambari-web/app/utils/ajax/ajax.js 54777da 
  ambari-web/app/views/wizard/step10_view.js a48353b 

Diff: https://reviews.apache.org/r/21300/diff/


Testing
-------

Tested the patch on a cluster with ambari-1.6.0 branch bits.


Thanks,

Jaimin Jetly