[GitHub] [beam] damccorm commented on a diff in pull request #17476: [BEAM-11105] Add timestamp observing watermark estimation

[GitBox <gi...@apache.org>]

damccorm commented on code in PR #17476:
URL: https://github.com/apache/beam/pull/17476#discussion_r862211506


##########
sdks/go/pkg/beam/core/sdf/sdf.go:
##########
@@ -96,3 +98,12 @@ type WatermarkEstimator interface {
 	// splits or checkpoints to advance the output watermark of the restriction's stage.
 	CurrentWatermark() time.Time
 }
+
+// ToWatermarkEstimator is an interface used to represent a user defined watermark estimator that
+// has the ability to observe timestamps of elements outputted from a ParDo's emit function.
+type ToWatermarkEstimator interface {

Review Comment:
   I ended up going with TimestampObservingEstimator



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org