[GitHub] mistercrunch commented on a change in pull request #5206: [adhoc-filters] Adding adhoc-filters to all viz types

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #5206: [adhoc-filters] Adding adhoc-filters to all viz types
URL: https://github.com/apache/incubator-superset/pull/5206#discussion_r196229473
 
 

 ##########
 File path: superset/assets/backendSync.json
 ##########
 @@ -1683,18 +1683,6 @@
       "renderTrigger": true,
       "default": ""
     },
-    "where": {
 
 Review comment:
   That represents the old TextControl where people would write their WHERE clause. Did we even run a db migration to convert the old filters (where & having) to new ones?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org