You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "frankvicky (via GitHub)" <gi...@apache.org> on 2025/05/19 08:10:28 UTC
[PR] MINOR: Update 3.9.1 site [kafka-site]
frankvicky opened a new pull request, #687:
URL: https://github.com/apache/kafka-site/pull/687
The vote for the 3.9.1 release has been accepted. Hence, we should update the respective site content.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Update 3.9.1 site [kafka-site]
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon merged PR #687:
URL: https://github.com/apache/kafka-site/pull/687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Update 3.9.1 site [kafka-site]
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on code in PR #687:
URL: https://github.com/apache/kafka-site/pull/687#discussion_r2095279625
##########
39/streams/developer-guide/config-streams.html:
##########
@@ -1387,7 +1387,7 @@ <h3><a class="toc-backref" href="#id38">client.id</a><a class="headerlink" href=
<div class="content documentation">
<!--#include virtual="../../../includes/_nav.htm" -->
<div class="right">
- <!--#include virtual="../../../includes/_docs_banner.htm" -->
+ <!--//#include virtual="../../../includes/_docs_banner.htm" -->
Review Comment:
Same here, and below.
##########
39/documentation.html:
##########
@@ -30,7 +30,7 @@
<!--#include virtual="toc.html" -->
</div>
<div class="right">
- <!--#include virtual="../includes/_docs_banner.htm" -->
+ <!--//#include virtual="../includes/_docs_banner.htm" -->
Review Comment:
What's this change for?
##########
39/javadoc/allclasses-index.html:
##########
@@ -11,7 +11,7 @@
<link rel="stylesheet" type="text/css" href="script-dir/jquery-ui.min.css" title="Style">
<link rel="stylesheet" type="text/css" href="jquery-ui.overrides.css" title="Style">
<script type="text/javascript" src="script.js"></script>
-<script type="text/javascript" src="script-dir/jquery-3.7.1.min.js"></script>
+<script type="text/javascript" src="script-dir/jquery-3.6.1.min.js"></script>
Review Comment:
I guess it's generated, not changed by us, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Update 3.9.1 site [kafka-site]
Posted by "frankvicky (via GitHub)" <gi...@apache.org>.
frankvicky commented on code in PR #687:
URL: https://github.com/apache/kafka-site/pull/687#discussion_r2095284021
##########
39/javadoc/allclasses-index.html:
##########
@@ -11,7 +11,7 @@
<link rel="stylesheet" type="text/css" href="script-dir/jquery-ui.min.css" title="Style">
<link rel="stylesheet" type="text/css" href="jquery-ui.overrides.css" title="Style">
<script type="text/javascript" src="script.js"></script>
-<script type="text/javascript" src="script-dir/jquery-3.7.1.min.js"></script>
+<script type="text/javascript" src="script-dir/jquery-3.6.1.min.js"></script>
Review Comment:
Exactly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Update 3.9.1 site [kafka-site]
Posted by "frankvicky (via GitHub)" <gi...@apache.org>.
frankvicky commented on code in PR #687:
URL: https://github.com/apache/kafka-site/pull/687#discussion_r2095285699
##########
39/documentation.html:
##########
@@ -30,7 +30,7 @@
<!--#include virtual="toc.html" -->
</div>
<div class="right">
- <!--#include virtual="../includes/_docs_banner.htm" -->
+ <!--//#include virtual="../includes/_docs_banner.htm" -->
Review Comment:
Interesting...
I don't change these manually. 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Update 3.9.1 site [kafka-site]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #687:
URL: https://github.com/apache/kafka-site/pull/687#issuecomment-2969501516
@frankvicky Did you copy the content from `kafka` repo to `kafka-site`? If so, that could overwrite the PRs which are NOT committed to `kafak` 3.9 branch. For example: https://github.com/apache/kafka-site/pull/667 was pushed to `kafka` 3.9 branch so the changes were overwriten by this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Update 3.9.1 site [kafka-site]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #687:
URL: https://github.com/apache/kafka-site/pull/687#issuecomment-2963811266
This overwrote a bunch of updates we had made to `39/ops.html`: https://github.com/apache/kafka-site/commit/dfe950b0d833ca440ea886c88b7ad31a5972a7c4#diff-2935bbc848956768b4752c6bc57df93712a46d23721109e92762903cf988184b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Update 3.9.1 site [kafka-site]
Posted by "frankvicky (via GitHub)" <gi...@apache.org>.
frankvicky commented on PR #687:
URL: https://github.com/apache/kafka-site/pull/687#issuecomment-2964859249
I will take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org