You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/19 14:30:05 UTC
[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #2346: Fix comments on armv7-a smp
masayuki2009 opened a new pull request #2346:
URL: https://github.com/apache/incubator-nuttx/pull/2346
## Summary
- This PR consists of 2 commits
- commit 1: armv7-a: Fix comments on Cortex-A SGI
- I noticed that Cortex-A SGI can be masked
- We thought the SGI is not maskable
- Although I can not remember how I tested it before
- It actually works as expected now
- commit 2: boards: sabre-6quad: Fix README.txt
- Remove comments on up_idle() which is old information
- Add L2CC info with QEMU
## Impact
- No impact
## Testing
- Tested with sabre-6quad:smp (QEMU and dev board)
- Add the following code in up_idle() before calling asm("WFI");
```
+ if (0 != up_cpu_index())
+ {
+ up_irq_save();
+ }
```
- Run the hello app, you can see "Hello, World!!"
- But nsh will freeze soon because arm_pause_handler is not called.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #2346: Fix comments on armv7-a smp
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #2346:
URL: https://github.com/apache/incubator-nuttx/pull/2346#issuecomment-730804910
@btashton
I added the backport/10.0.0 label to this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #2346: Fix comments on armv7-a smp
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on a change in pull request #2346:
URL: https://github.com/apache/incubator-nuttx/pull/2346#discussion_r527239707
##########
File path: TODO
##########
@@ -468,37 +468,6 @@ o SMP
Priority: Medium for SMP system. Not critical to single CPU systems.
NOTE: There are no known bugs from this potential problem.
- Title: CORTEX-A GIC SGI INTERRUPT MASKING
Review comment:
> need update line 1 and 13 too
@xiaoxiang781216
Thanks!
I forgot to update the lines in https://github.com/apache/incubator-nuttx/pull/2299
So I fixed the number in this PR (also added a comment)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #2346: Fix comments on armv7-a smp
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #2346:
URL: https://github.com/apache/incubator-nuttx/pull/2346#issuecomment-730414345
@patacongo
I confirmed that Cortex-A SGI is maskable.
Though I did not change anything regarding Cortex-A SGI, perhaps I did some mistakes to confirm it before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #2346: Fix comments on armv7-a smp
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on a change in pull request #2346:
URL: https://github.com/apache/incubator-nuttx/pull/2346#discussion_r527239707
##########
File path: TODO
##########
@@ -468,37 +468,6 @@ o SMP
Priority: Medium for SMP system. Not critical to single CPU systems.
NOTE: There are no known bugs from this potential problem.
- Title: CORTEX-A GIC SGI INTERRUPT MASKING
Review comment:
> need update line 1 and 13 too
@xiaoxiang781216
Thanks!
Actually, I forgot to update the lines in https://github.com/apache/incubator-nuttx/pull/2299
So I fixed the number in this PR (also added a comment)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2346: Fix comments on armv7-a smp
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2346:
URL: https://github.com/apache/incubator-nuttx/pull/2346
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2346: Fix comments on armv7-a smp
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2346:
URL: https://github.com/apache/incubator-nuttx/pull/2346#discussion_r526992049
##########
File path: TODO
##########
@@ -468,37 +468,6 @@ o SMP
Priority: Medium for SMP system. Not critical to single CPU systems.
NOTE: There are no known bugs from this potential problem.
- Title: CORTEX-A GIC SGI INTERRUPT MASKING
Review comment:
need update line 1 and 13 too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org