You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Cheolsoo Park <ch...@cloudera.com> on 2012/03/09 02:46:36 UTC
Review Request: SQOOP-459 Remove redundant steps in compatibility tests:
verifyReadback() method
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4266/
-----------------------------------------------------------
Review request for Sqoop and Bilung Lee.
Summary
-------
Several tests including ManagerCompatTest do the following:
1) Tests insert data
2) Compare output from the db against inserted values
3) Run Sqoop import jobs
4) Compare output read from seq files against inserted values
Tthe step 2 is redundant since the step 4 also verifies output. In addition, these tests are fragile since output formats vary depending on versions/vendors of the DB/JDBC driver.
Since there is little value to gain from these tests while they cause compatibility problems, it would be better to remove them.
This addresses bug SQOOP-459.
https://issues.apache.org/jira/browse/SQOOP-459
Diffs
-----
./src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 1298661
./src/test/com/cloudera/sqoop/testutil/ManagerCompatTestCase.java 1298661
./src/test/com/cloudera/sqoop/manager/MySQLCompatTest.java 1298661
./src/test/com/cloudera/sqoop/manager/OracleCompatTest.java 1298661
./src/test/com/cloudera/sqoop/TestMultiCols.java 1298661
./src/test/com/cloudera/sqoop/TestColumnTypes.java 1298661
Diff: https://reviews.apache.org/r/4266/diff
Testing
-------
Thanks,
Cheolsoo
Re: Review Request: SQOOP-459 Remove redundant steps in compatibility tests:
verifyReadback() method
Posted by Bilung Lee <bl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4266/#review5800
-----------------------------------------------------------
Ship it!
Thanks for the patch!
- Bilung
On 2012-03-09 19:38:14, Cheolsoo Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4266/
> -----------------------------------------------------------
>
> (Updated 2012-03-09 19:38:14)
>
>
> Review request for Sqoop and Bilung Lee.
>
>
> Summary
> -------
>
> Several tests including ManagerCompatTest do the following:
>
> 1) Tests insert data
> 2) Compare output from the db against inserted values
> 3) Run Sqoop import jobs
> 4) Compare output read from seq files against inserted values
>
> Tthe step 2 is redundant since the step 4 also verifies output. In addition, these tests are fragile since output formats vary depending on versions/vendors of the DB/JDBC driver.
>
> Since there is little value to gain from these tests while they cause compatibility problems, it would be better to remove them.
>
>
> This addresses bug SQOOP-459.
> https://issues.apache.org/jira/browse/SQOOP-459
>
>
> Diffs
> -----
>
> ./src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 1298661
> ./src/test/com/cloudera/sqoop/testutil/ManagerCompatTestCase.java 1298661
> ./src/test/com/cloudera/sqoop/manager/MySQLCompatTest.java 1298661
> ./src/test/com/cloudera/sqoop/manager/OracleCompatTest.java 1298661
> ./src/test/com/cloudera/sqoop/TestMultiCols.java 1298661
> ./src/test/com/cloudera/sqoop/TestColumnTypes.java 1298661
>
> Diff: https://reviews.apache.org/r/4266/diff
>
>
> Testing
> -------
>
> Ran
> ant test
> ant test -Dthirdparty
> ant checkstyle
>
>
> Thanks,
>
> Cheolsoo
>
>
Re: Review Request: SQOOP-459 Remove redundant steps in compatibility tests:
verifyReadback() method
Posted by Cheolsoo Park <ch...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4266/
-----------------------------------------------------------
(Updated 2012-03-09 19:38:14.027866)
Review request for Sqoop and Bilung Lee.
Summary
-------
Several tests including ManagerCompatTest do the following:
1) Tests insert data
2) Compare output from the db against inserted values
3) Run Sqoop import jobs
4) Compare output read from seq files against inserted values
Tthe step 2 is redundant since the step 4 also verifies output. In addition, these tests are fragile since output formats vary depending on versions/vendors of the DB/JDBC driver.
Since there is little value to gain from these tests while they cause compatibility problems, it would be better to remove them.
This addresses bug SQOOP-459.
https://issues.apache.org/jira/browse/SQOOP-459
Diffs
-----
./src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 1298661
./src/test/com/cloudera/sqoop/testutil/ManagerCompatTestCase.java 1298661
./src/test/com/cloudera/sqoop/manager/MySQLCompatTest.java 1298661
./src/test/com/cloudera/sqoop/manager/OracleCompatTest.java 1298661
./src/test/com/cloudera/sqoop/TestMultiCols.java 1298661
./src/test/com/cloudera/sqoop/TestColumnTypes.java 1298661
Diff: https://reviews.apache.org/r/4266/diff
Testing (updated)
-------
Ran
ant test
ant test -Dthirdparty
ant checkstyle
Thanks,
Cheolsoo