You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Philip Zeyliger (JIRA)" <ji...@apache.org> on 2009/12/30 21:42:29 UTC
[jira] Created: (AVRO-272) Extend RPCContext to include protocol
Methods.
Extend RPCContext to include protocol Methods.
----------------------------------------------
Key: AVRO-272
URL: https://issues.apache.org/jira/browse/AVRO-272
Project: Avro
Issue Type: New Feature
Components: java
Reporter: Philip Zeyliger
Assignee: Philip Zeyliger
Since the RPCContext is used to send listeners/plugins handshake and call metadata, it makes sense to include the RPC method in it as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-272) Extend RPCContext to include protocol
Methods.
Posted by "Philip Zeyliger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philip Zeyliger updated AVRO-272:
---------------------------------
Attachment: AVRO-272.patch.txt
Attaching a patch. There's not much here. The two test lines do get invoked (I've set a breakpoint).
It's possible I'm subverting AVRO-76 a bit. The plugin system seems to have been motivated in passing out of AVRO-band information between client and server. I'm using it to expose AVRO metadata to the client and server.
(One possible way of exposing client host/port information to the server would be to write a plugin that sticks that information into thread locals, say. We'd still need to share the information between RPCContext and Transceiver, but that doesn't seem too bad.)
> Extend RPCContext to include protocol Methods.
> ----------------------------------------------
>
> Key: AVRO-272
> URL: https://issues.apache.org/jira/browse/AVRO-272
> Project: Avro
> Issue Type: New Feature
> Components: java
> Reporter: Philip Zeyliger
> Assignee: Philip Zeyliger
> Attachments: AVRO-272.patch.txt
>
>
> Since the RPCContext is used to send listeners/plugins handshake and call metadata, it makes sense to include the RPC method in it as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-272) Extend RPCContext to include protocol
Methods.
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated AVRO-272:
------------------------------
Resolution: Fixed
Fix Version/s: 1.3.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
> Extend RPCContext to include protocol Methods.
> ----------------------------------------------
>
> Key: AVRO-272
> URL: https://issues.apache.org/jira/browse/AVRO-272
> Project: Avro
> Issue Type: New Feature
> Components: java
> Reporter: Philip Zeyliger
> Assignee: Philip Zeyliger
> Fix For: 1.3.0
>
> Attachments: AVRO-272.patch.txt
>
>
> Since the RPCContext is used to send listeners/plugins handshake and call metadata, it makes sense to include the RPC method in it as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-272) Extend RPCContext to include protocol
Methods.
Posted by "Philip Zeyliger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philip Zeyliger updated AVRO-272:
---------------------------------
Status: Patch Available (was: Open)
> Extend RPCContext to include protocol Methods.
> ----------------------------------------------
>
> Key: AVRO-272
> URL: https://issues.apache.org/jira/browse/AVRO-272
> Project: Avro
> Issue Type: New Feature
> Components: java
> Reporter: Philip Zeyliger
> Assignee: Philip Zeyliger
> Attachments: AVRO-272.patch.txt
>
>
> Since the RPCContext is used to send listeners/plugins handshake and call metadata, it makes sense to include the RPC method in it as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-272) Extend RPCContext to include protocol
Methods.
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795638#action_12795638 ]
Doug Cutting commented on AVRO-272:
-----------------------------------
I just committed this.
I think it might make sense to add a method like:
public static RPCContext Responder#getContext()
that can be called within a protocol implementation and retrieves the context from a ThreadLocal.
> Extend RPCContext to include protocol Methods.
> ----------------------------------------------
>
> Key: AVRO-272
> URL: https://issues.apache.org/jira/browse/AVRO-272
> Project: Avro
> Issue Type: New Feature
> Components: java
> Reporter: Philip Zeyliger
> Assignee: Philip Zeyliger
> Fix For: 1.3.0
>
> Attachments: AVRO-272.patch.txt
>
>
> Since the RPCContext is used to send listeners/plugins handshake and call metadata, it makes sense to include the RPC method in it as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.