You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2023/01/19 20:26:25 UTC

[GitHub] [netbeans] tbw777 commented on pull request #5309: Replaced all [equals() -> "==", HashSet -> EnumSet, HashMap -> EnumMap] calls for enum types

tbw777 commented on PR #5309:
URL: https://github.com/apache/netbeans/pull/5309#issuecomment-1397554774

   I think == is more preffered becouse of no methods used
   
   I was scan project and no enums with equals exist. Actual regexp:
   ^[^\"')(;,\;,\\s*{}/]*(\s*)enum\s+[^{}/\[\]%&?@!#$\^\*<>]+\s*((implements)\s*[^{}/\[\]%&?@!#$\^\*]+\s*,*\s*)*\{(.|\n)*public\s+boolean\s+equals
   
   Exclusions:
   1. enterprise/payara.tooling/src/org/netbeans/modules/payara/tooling/data/PayaraVersion.java
   
   `    @Override
       public boolean equals(PayaraPlatformVersionAPI version) {
           throw new UnsupportedOperationException("Not supported yet."); //To change body of generated methods, choose Tools | Templates.
       }`
   
   3. enterprise/glassfish.tooling/src/org/netbeans/modules/glassfish/tooling/data/GlassFishVersion.java


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists