You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Clint Morgan (JIRA)" <ji...@apache.org> on 2008/04/19 01:26:21 UTC
[jira] Created: (HBASE-595) RowFilterInterface.rowProcessed() is
called *before* fhe final filtering decision is made
RowFilterInterface.rowProcessed() is called *before* fhe final filtering decision is made
-----------------------------------------------------------------------------------------
Key: HBASE-595
URL: https://issues.apache.org/jira/browse/HBASE-595
Project: Hadoop HBase
Issue Type: Bug
Components: filters
Affects Versions: 0.1.1, 0.2.0
Reporter: Clint Morgan
rowProcessed is called in HStoreScanner, however, the final filtering decision is not made until the full row has been assembled in HRegion
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-595) RowFilterInterface.rowProcessed() is
called *before* fhe final filtering decision is made
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590779#action_12590779 ]
stack commented on HBASE-595:
-----------------------------
Clint: The way things are now, we may make decision prematurely after looking at just one store? Should I apply patch to branch too?
> RowFilterInterface.rowProcessed() is called *before* fhe final filtering decision is made
> -----------------------------------------------------------------------------------------
>
> Key: HBASE-595
> URL: https://issues.apache.org/jira/browse/HBASE-595
> Project: Hadoop HBase
> Issue Type: Bug
> Components: filters
> Affects Versions: 0.2.0, 0.1.1
> Reporter: Clint Morgan
> Attachments: hbase-595.patch
>
>
> rowProcessed is called in HStoreScanner, however, the final filtering decision is not made until the full row has been assembled in HRegion
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-595) RowFilterInterface.rowProcessed() is
called *before* fhe final filtering decision is made
Posted by "Clint Morgan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Clint Morgan updated HBASE-595:
-------------------------------
Attachment: hbase-595.patch
patch to fix
> RowFilterInterface.rowProcessed() is called *before* fhe final filtering decision is made
> -----------------------------------------------------------------------------------------
>
> Key: HBASE-595
> URL: https://issues.apache.org/jira/browse/HBASE-595
> Project: Hadoop HBase
> Issue Type: Bug
> Components: filters
> Affects Versions: 0.2.0, 0.1.1
> Reporter: Clint Morgan
> Attachments: hbase-595.patch
>
>
> rowProcessed is called in HStoreScanner, however, the final filtering decision is not made until the full row has been assembled in HRegion
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-595) RowFilterInterface.rowProcessed() is
called *before* fhe final filtering decision is made
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-595.
-------------------------
Resolution: Fixed
Fix Version/s: 0.1.2
0.2.0
Committed. Thanks for the patch Clint.
> RowFilterInterface.rowProcessed() is called *before* fhe final filtering decision is made
> -----------------------------------------------------------------------------------------
>
> Key: HBASE-595
> URL: https://issues.apache.org/jira/browse/HBASE-595
> Project: Hadoop HBase
> Issue Type: Bug
> Components: filters
> Affects Versions: 0.2.0, 0.1.1
> Reporter: Clint Morgan
> Fix For: 0.2.0, 0.1.2
>
> Attachments: hbase-595.patch
>
>
> rowProcessed is called in HStoreScanner, however, the final filtering decision is not made until the full row has been assembled in HRegion
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-595) RowFilterInterface.rowProcessed() is
called *before* fhe final filtering decision is made
Posted by "Clint Morgan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590950#action_12590950 ]
Clint Morgan commented on HBASE-595:
------------------------------------
The problem is that we are notifying the filters of the filtering
decision prematurely. Hstores use the filters on row key and
individual columns, but the final filtering decision does not come
until all of the stores' columns are assembled in the hregion. So only
after this decision has been made can we notify rowProcessed() to filters (in the hregion).
I say we should patch branches.
But its probably not a big deal. Looking over existing filter impls, only
PageRowFilter would be affected by the bug. (And this filter offerers little utility
because it only skips the rows after the page. Instead you could save
the trouble and just stop the advancing the scanner in the first
place.)
> RowFilterInterface.rowProcessed() is called *before* fhe final filtering decision is made
> -----------------------------------------------------------------------------------------
>
> Key: HBASE-595
> URL: https://issues.apache.org/jira/browse/HBASE-595
> Project: Hadoop HBase
> Issue Type: Bug
> Components: filters
> Affects Versions: 0.2.0, 0.1.1
> Reporter: Clint Morgan
> Attachments: hbase-595.patch
>
>
> rowProcessed is called in HStoreScanner, however, the final filtering decision is not made until the full row has been assembled in HRegion
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.