You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ramesh Mani <rm...@hortonworks.com> on 2020/04/03 06:58:37 UTC
Review Request 72312: RANGER-2777:Ranger Knox Plugin failed to
download Roles
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72312/
-----------------------------------------------------------
Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-2777
https://issues.apache.org/jira/browse/RANGER-2777
Repository: ranger
Description
-------
RANGER-2777:Ranger Knox Plugin failed to download Roles
Diffs
-----
knox-agent/src/main/java/org/apache/ranger/admin/client/RangerAdminJersey2RESTClient.java b2184b6
Diff: https://reviews.apache.org/r/72312/diff/1/
Testing
-------
Tested in local vm for Roles Donwload in Knox plugin
Thanks,
Ramesh Mani
Re: Review Request 72312: RANGER-2777:Ranger Knox Plugin failed to
download Roles
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72312/#review220210
-----------------------------------------------------------
Fix it, then Ship it!
knox-agent/src/main/java/org/apache/ranger/admin/client/RangerAdminJersey2RESTClient.java
Line 237 (original), 237 (patched)
<https://reviews.apache.org/r/72312/#comment308515>
- RangerAdminRESTClient uses REST_URL_SERVICE_SERCURE_GET_USER_GROUP_ROLES; here REST_URL_ROLE_GET_FOR_SECURE_SERVICE_IF_UPDATED is used. They both are assigned the same value. Please review and remove duplicate.
- Also, _baseUrl, and _utils are no more needed outside the constructor. Please review and remove.
- Madhan Neethiraj
On April 3, 2020, 6:58 a.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72312/
> -----------------------------------------------------------
>
> (Updated April 3, 2020, 6:58 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2777
> https://issues.apache.org/jira/browse/RANGER-2777
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-2777:Ranger Knox Plugin failed to download Roles
>
>
> Diffs
> -----
>
> knox-agent/src/main/java/org/apache/ranger/admin/client/RangerAdminJersey2RESTClient.java b2184b6
>
>
> Diff: https://reviews.apache.org/r/72312/diff/1/
>
>
> Testing
> -------
>
> Tested in local vm for Roles Donwload in Knox plugin
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 72312: RANGER-2777:Ranger Knox Plugin failed to
download Roles
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72312/#review220222
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On April 4, 2020, 12:15 a.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72312/
> -----------------------------------------------------------
>
> (Updated April 4, 2020, 12:15 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2777
> https://issues.apache.org/jira/browse/RANGER-2777
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-2777:Ranger Knox Plugin failed to download Roles
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTUtils.java 3e402aa
> knox-agent/src/main/java/org/apache/ranger/admin/client/RangerAdminJersey2RESTClient.java b2184b6
>
>
> Diff: https://reviews.apache.org/r/72312/diff/2/
>
>
> Testing
> -------
>
> Tested in local vm for Roles Donwload in Knox plugin
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 72312: RANGER-2777:Ranger Knox Plugin failed to
download Roles
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72312/
-----------------------------------------------------------
(Updated April 4, 2020, 12:15 a.m.)
Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Changes
-------
Fixed review comments
Bugs: RANGER-2777
https://issues.apache.org/jira/browse/RANGER-2777
Repository: ranger
Description
-------
RANGER-2777:Ranger Knox Plugin failed to download Roles
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTUtils.java 3e402aa
knox-agent/src/main/java/org/apache/ranger/admin/client/RangerAdminJersey2RESTClient.java b2184b6
Diff: https://reviews.apache.org/r/72312/diff/2/
Changes: https://reviews.apache.org/r/72312/diff/1-2/
Testing
-------
Tested in local vm for Roles Donwload in Knox plugin
Thanks,
Ramesh Mani