You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/07/28 00:46:47 UTC
[GitHub] [rocketmq-connect] zxhjames opened a new issue, #216: Documentation for rocketmq-connector-jdbc should be updated
zxhjames opened a new issue, #216:
URL: https://github.com/apache/rocketmq-connect/issues/216
hi, I found that the source-record-converter field in the rocketmq-connect-jdbc documentation should be consistent with the latest implementation class name in rocketmq-connect-runtime
For example, the source-record-converter class in the document cannot be parsed by the following method in the rocketmq-connect-runtime project, because this class is not a subclass of io.openmessaging.connector.api.data.RecordConverter in the method, and cannot be parsed convert,otherwise there will be a java.lang.ClassCastException problem
<img width="1209" alt="image" src="https://user-images.githubusercontent.com/41276134/181396262-ec442280-b027-4127-aa4f-a915e97564eb.png">
The source-record-converter field in the documentation should be updated to the latest **org.apache.rocketmq.connect.runtime.converter.record.json.JsonConverter** class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-connect] zxhjames commented on issue #216: Documentation for rocketmq-connector-jdbc should be updated
Posted by GitBox <gi...@apache.org>.
zxhjames commented on issue #216:
URL: https://github.com/apache/rocketmq-connect/issues/216#issuecomment-1203434424
Added some data writing test cases about clickhouse database on the sink side
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Documentation for rocketmq-connector-jdbc should be updated [rocketmq-connect]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #216:
URL: https://github.com/apache/rocketmq-connect/issues/216#issuecomment-5310383039
**Issue Evaluation**
Category: `documentation` | Status: **Valid (Stale)**
The JDBC connector documentation references an outdated `source-record-converter` class name that doesn't match the current implementation. This is a documentation-only fix.
Open since July 2022. If the documentation is still inaccurate, a PR updating the class references to match the current `io.openmessaging.connector` subclass hierarchy would be welcome.
---
*Automated evaluation by RockteMQ-AI*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org