You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by dan-blanchard <gi...@git.apache.org> on 2015/07/07 16:31:36 UTC
[GitHub] storm pull request: [STORM-928] Add source->stream->fields mapping...
GitHub user dan-blanchard opened a pull request:
https://github.com/apache/storm/pull/624
[STORM-928] Add source->stream->fields mapping to multi-lang context
This pull request adds a `source->stream->fields` mapping to the topology context sent to multi-lang components as part of the handshake.
It also clears up a few minor type issues in TopologyContext.java, and fixes the Multi-Lang protocol doc to note that the additions I made in #525 are in 0.10.0 and not 0.11.0.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dan-blanchard/incubator-storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/624.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #624
----
commit a1912eafab7f4313c7f45f27748fff28cb37d8f0
Author: Dan Blanchard <da...@parsely.com>
Date: 2015-07-06T20:45:29Z
Minor type cleanup things in storm.task.TopologyContext.java
commit 427cef54c74204a257bc97a3e8fb793854603aaf
Author: Dan Blanchard <da...@parsely.com>
Date: 2015-07-07T14:25:58Z
Add source->stream->fields mapping to multi-lang handshake.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-928] Add source->stream->fields mapping...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/624
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-928] Add source->stream->fields mapping...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/624#issuecomment-119529281
LGTM, +1.
Btw, I don't quite know why builds are failed from messaging-test for now. Needs investigation.
But changeset is not related to this, so we can just ignore them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-928] Add source->stream->fields mapping...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/624#issuecomment-120958702
Thanks @dan-blanchard , I merged into master and 0.10.x-branch at ASF git repos, but seems like Github mirror is out of sync.
I'll resolve issue when mirror keeps up ASF repo.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---