You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/26 11:19:47 UTC

[GitHub] [pulsar] tisonkun commented on a diff in pull request #15142: Pulsar with Bk 4.15.0

tisonkun commented on code in PR #15142:
URL: https://github.com/apache/pulsar/pull/15142#discussion_r1005550088


##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/bookkeeper/AbstractMetadataDriver.java:
##########
@@ -67,6 +67,13 @@ protected void initialize(AbstractConfiguration conf) throws MetadataException {
         }
     }
 
+    public RegistrationManager createRegistrationManager() {
+        if (registrationManager == null) {
+            registrationManager = new PulsarRegistrationManager(store, ledgersRootPath, conf);
+        }
+        return registrationManager;
+    }
+

Review Comment:
   Why do we make this change? It seems we generate an unreleased resource here.
   
   cc @dlg99 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org