You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Shingo Omura <ev...@gmail.com> on 2013/10/26 00:09:46 UTC

Review Request 14951: mesos-cat and mesos-tail

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14951/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Niklas Nielsen.


Repository: mesos-git


Description
-------

These are actually slightly improved version of the original shared by Ben.H at mesos hackathon on Oct.25th 2013.

Modifications I did:
- add python version check
- add quote for query contents


Diffs
-----

  src/cli/mesos-cat PRE-CREATION 
  src/cli/mesos-tail PRE-CREATION 

Diff: https://reviews.apache.org/r/14951/diff/


Testing
-------

I tested these manually on my laptop.


Thanks,

Shingo Omura


Re: Review Request 14951: mesos-cat and mesos-tail

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14951/#review28315
-----------------------------------------------------------

Ship it!


I'm going to get this committed so people can help out using the new Python CLI stuff.

- Benjamin Hindman


On Nov. 2, 2013, 2:25 a.m., Shingo Omura wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14951/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2013, 2:25 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Du Li, and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> These are actually slightly improved version of the original shared by Ben.H at mesos hackathon on Oct.25th 2013.
> 
> Modifications I did:
> - add python version check
> - add quote for query contents
> - support to inspect files on completed frameworks/tasks
> 
> 
> Diffs
> -----
> 
>   src/cli/mesos-cat PRE-CREATION 
>   src/cli/mesos-tail PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/14951/diff/
> 
> 
> Testing
> -------
> 
> I tested these manually on my laptop.
> 
> 
> Thanks,
> 
> Shingo Omura
> 
>


Re: Review Request 14951: mesos-cat and mesos-tail

Posted by Shingo Omura <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14951/
-----------------------------------------------------------

(Updated Nov. 2, 2013, 2:25 a.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, Du Li, and Niklas Nielsen.


Repository: mesos-git


Description
-------

These are actually slightly improved version of the original shared by Ben.H at mesos hackathon on Oct.25th 2013.

Modifications I did:
- add python version check
- add quote for query contents
- support to inspect files on completed frameworks/tasks


Diffs
-----

  src/cli/mesos-cat PRE-CREATION 
  src/cli/mesos-tail PRE-CREATION 

Diff: https://reviews.apache.org/r/14951/diff/


Testing
-------

I tested these manually on my laptop.


Thanks,

Shingo Omura


Re: Review Request 14951: mesos-cat and mesos-tail

Posted by Shingo Omura <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14951/
-----------------------------------------------------------

(Updated Nov. 1, 2013, 10:06 p.m.)


Review request for mesos, Benjamin Hindman and Niklas Nielsen.


Changes
-------

Uploaded patch is now git formatted.
So, if this got 'Ship It!', some committer can directly apply this patch to his local repo with 'git am'.


Repository: mesos-git


Description
-------

These are actually slightly improved version of the original shared by Ben.H at mesos hackathon on Oct.25th 2013.

Modifications I did:
- add python version check
- add quote for query contents
- support to inspect files on completed frameworks/tasks


Diffs (updated)
-----

  src/cli/mesos-cat PRE-CREATION 
  src/cli/mesos-tail PRE-CREATION 

Diff: https://reviews.apache.org/r/14951/diff/


Testing
-------

I tested these manually on my laptop.


Thanks,

Shingo Omura


Re: Review Request 14951: mesos-cat and mesos-tail

Posted by Shingo Omura <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14951/
-----------------------------------------------------------

(Updated Oct. 28, 2013, 8:21 p.m.)


Review request for mesos, Benjamin Hindman and Niklas Nielsen.


Changes
-------

Thank you for your comment, Jason.
I reflected review comments by Jason and updated diff.


Repository: mesos-git


Description
-------

These are actually slightly improved version of the original shared by Ben.H at mesos hackathon on Oct.25th 2013.

Modifications I did:
- add python version check
- add quote for query contents
- support to inspect files on completed frameworks/tasks


Diffs (updated)
-----

  src/cli/mesos-cat PRE-CREATION 
  src/cli/mesos-tail PRE-CREATION 

Diff: https://reviews.apache.org/r/14951/diff/


Testing
-------

I tested these manually on my laptop.


Thanks,

Shingo Omura


Re: Review Request 14951: mesos-cat and mesos-tail

Posted by "OMURA, Shingo" <ev...@gmail.com>.
sorry, Ben.

I marked all issues as fixed.
Thanks.


--
Shingo Omura
everpeace@gmail.com
http://everpeace.github.io/


2013/11/4 Ben Mahler <be...@gmail.com>

>    This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14951/
>
> Hey Shingo, can you mark these open issues as resolved or dropped?
>
>
> - Ben
>
> On November 2nd, 2013, 2:25 a.m. UTC, Shingo Omura wrote:
>   Review request for mesos, Benjamin Hindman, Ben Mahler, Du Li, and
> Niklas Nielsen.
> By Shingo Omura.
>
> *Updated Nov. 2, 2013, 2:25 a.m.*
>  *Repository: * mesos-git
> Description
>
> These are actually slightly improved version of the original shared by Ben.H at mesos hackathon on Oct.25th 2013.
>
> Modifications I did:
> - add python version check
> - add quote for query contents
> - support to inspect files on completed frameworks/tasks
>
>   Testing
>
> I tested these manually on my laptop.
>
>   Diffs
>
>    - src/cli/mesos-cat (PRE-CREATION)
>    - src/cli/mesos-tail (PRE-CREATION)
>
> View Diff <https://reviews.apache.org/r/14951/diff/>
>

Re: Review Request 14951: mesos-cat and mesos-tail

Posted by Ben Mahler <be...@gmail.com>.

> On Oct. 26, 2013, 9:01 p.m., Jason Dusek wrote:
> >

Hey Shingo, can you mark these open issues as resolved or dropped?


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14951/#review27576
-----------------------------------------------------------


On Nov. 2, 2013, 2:25 a.m., Shingo Omura wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14951/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2013, 2:25 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Du Li, and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> These are actually slightly improved version of the original shared by Ben.H at mesos hackathon on Oct.25th 2013.
> 
> Modifications I did:
> - add python version check
> - add quote for query contents
> - support to inspect files on completed frameworks/tasks
> 
> 
> Diffs
> -----
> 
>   src/cli/mesos-cat PRE-CREATION 
>   src/cli/mesos-tail PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/14951/diff/
> 
> 
> Testing
> -------
> 
> I tested these manually on my laptop.
> 
> 
> Thanks,
> 
> Shingo Omura
> 
>


Re: Review Request 14951: mesos-cat and mesos-tail

Posted by Jason Dusek <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14951/#review27576
-----------------------------------------------------------



src/cli/mesos-cat
<https://reviews.apache.org/r/14951/#comment53512>

    This might read better as:
    
    "Failed to resolve 'mesos-resolve %s'\n" % master 



src/cli/mesos-cat
<https://reviews.apache.org/r/14951/#comment53511>

    Might want to use `-sSfL` for the `curl` options. With `-f`, `curl` translates HTTP failures (400s, 500s) to non-zero exit codes. With `-L` it follows redirects. With `-S` it is silent except when there are errors; then it prints a helpful message to `stderr`.  



src/cli/mesos-tail
<https://reviews.apache.org/r/14951/#comment53513>

    Same as line 30 in mesos-cat.



src/cli/mesos-tail
<https://reviews.apache.org/r/14951/#comment53514>

    Same as line 52 in mesos-cat.


- Jason Dusek


On Oct. 26, 2013, 2:01 a.m., Shingo Omura wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14951/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2013, 2:01 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> These are actually slightly improved version of the original shared by Ben.H at mesos hackathon on Oct.25th 2013.
> 
> Modifications I did:
> - add python version check
> - add quote for query contents
> - support to inspect files on completed frameworks/tasks
> 
> 
> Diffs
> -----
> 
>   src/cli/mesos-cat PRE-CREATION 
>   src/cli/mesos-tail PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/14951/diff/
> 
> 
> Testing
> -------
> 
> I tested these manually on my laptop.
> 
> 
> Thanks,
> 
> Shingo Omura
> 
>


Re: Review Request 14951: mesos-cat and mesos-tail

Posted by Shingo Omura <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14951/
-----------------------------------------------------------

(Updated Oct. 26, 2013, 2:01 a.m.)


Review request for mesos, Benjamin Hindman and Niklas Nielsen.


Changes
-------

support to inspect files on completed frameworks/tasks.


Repository: mesos-git


Description (updated)
-------

These are actually slightly improved version of the original shared by Ben.H at mesos hackathon on Oct.25th 2013.

Modifications I did:
- add python version check
- add quote for query contents
- support to inspect files on completed frameworks/tasks


Diffs (updated)
-----

  src/cli/mesos-cat PRE-CREATION 
  src/cli/mesos-tail PRE-CREATION 

Diff: https://reviews.apache.org/r/14951/diff/


Testing
-------

I tested these manually on my laptop.


Thanks,

Shingo Omura