[GitHub] [maven-dependency-plugin] slawekjaranowski commented on a change in pull request #188: adding sort option for build-classpath

[GitBox <gi...@apache.org>]

slawekjaranowski commented on a change in pull request #188:
URL: https://github.com/apache/maven-dependency-plugin/pull/188#discussion_r803024505



##########
File path: src/main/java/org/apache/maven/plugins/dependency/fromDependencies/BuildClasspathMojo.java
##########
@@ -68,6 +68,12 @@
     @Parameter( property = "outputEncoding", defaultValue = "${project.reporting.outputEncoding}" )
     private String outputEncoding;
     
+    /**
+     * Should the classpath be lexicographically sorted.
+     */
+    @Parameter( property = "mdep.sortClasspath", defaultValue = "false" )

Review comment:
       `@since` tag is missing

##########
File path: src/main/java/org/apache/maven/plugins/dependency/fromDependencies/BuildClasspathMojo.java
##########
@@ -68,6 +68,12 @@
     @Parameter( property = "outputEncoding", defaultValue = "${project.reporting.outputEncoding}" )
     private String outputEncoding;
     
+    /**
+     * Should the classpath be lexicographically sorted.
+     */
+    @Parameter( property = "mdep.sortClasspath", defaultValue = "false" )
+    private boolean sortClasspath = false;

Review comment:
       false is default value, initialization is redundant




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org