You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by "Zhe (Joe) Wang" <jw...@hortonworks.com> on 2016/03/30 02:02:43 UTC
Review Request 45462: AMBARI-15604 Alert Definitions Repeat Tolerance
Values Exposed In Web Client
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45462/
-----------------------------------------------------------
Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Jonathan Hurley, Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-15604
https://issues.apache.org/jira/browse/AMBARI-15604
Repository: ambari
Description
-------
Alert definitions will now expose two properties to control repeat tolerance values on an individual based (overriding those from cluster-env/alerts_repeat_tolerance)
Diffs
-----
ambari-web/app/controllers/global/update_controller.js dcef1a2
ambari-web/app/controllers/main/alerts/definition_details_controller.js fe17732
ambari-web/app/mappers/alert_definitions_mapper.js 7aae518
ambari-web/app/messages.js 5343bf1
ambari-web/app/models/alerts/alert_definition.js 0acfc33
ambari-web/app/styles/alerts.less 50246e6
ambari-web/app/templates/main/alerts/definition_details.hbs 14b749d
Diff: https://reviews.apache.org/r/45462/diff/
Testing
-------
Local ambari-web test passed.
25642 tests complete (22 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
Re: Review Request 45462: AMBARI-15604 Alert Definitions Repeat
Tolerance Values Exposed In Web Client
Posted by Richard Zang <rz...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45462/#review126964
-----------------------------------------------------------
Ship it!
Ship It!
- Richard Zang
On April 4, 2016, 10:44 p.m., Zhe (Joe) Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45462/
> -----------------------------------------------------------
>
> (Updated April 4, 2016, 10:44 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Jonathan Hurley, Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-15604
> https://issues.apache.org/jira/browse/AMBARI-15604
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Alert definitions will now expose two properties to control repeat tolerance values on an individual based (overriding those from cluster-env/alerts_repeat_tolerance)
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/global/update_controller.js dcef1a2
> ambari-web/app/controllers/main/alerts/definition_details_controller.js fe17732
> ambari-web/app/mappers/alert_definitions_mapper.js 0bf534e
> ambari-web/app/messages.js 1653eeb
> ambari-web/app/models/alerts/alert_definition.js a730572
> ambari-web/app/styles/alerts.less 50246e6
> ambari-web/app/templates/main/alerts/definition_details.hbs 14b749d
> ambari-web/app/views/main/alerts/definition_details_view.js 2fc75c1
> ambari-web/test/views/main/alerts/definition_details_view_test.js a98b66b
>
> Diff: https://reviews.apache.org/r/45462/diff/
>
>
> Testing
> -------
>
> Local ambari-web test passed.
> 25642 tests complete (22 seconds)
> 154 tests pending
> Manual testing done.
>
>
> Thanks,
>
> Zhe (Joe) Wang
>
>
Re: Review Request 45462: AMBARI-15604 Alert Definitions Repeat
Tolerance Values Exposed In Web Client
Posted by "Zhe (Joe) Wang" <jw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45462/
-----------------------------------------------------------
(Updated April 5, 2016, 6:45 p.m.)
Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Jonathan Hurley, Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-15604
https://issues.apache.org/jira/browse/AMBARI-15604
Repository: ambari
Description
-------
Alert definitions will now expose two properties to control repeat tolerance values on an individual based (overriding those from cluster-env/alerts_repeat_tolerance)
Diffs (updated)
-----
ambari-web/app/controllers/global/update_controller.js dc0f7cf
ambari-web/app/controllers/main/alerts/definition_details_controller.js fe17732
ambari-web/app/mappers/alert_definitions_mapper.js 20b6613
ambari-web/app/messages.js 8e32c84
ambari-web/app/models/alerts/alert_definition.js dac26ce
ambari-web/app/styles/alerts.less 50246e6
ambari-web/app/templates/main/alerts/definition_details.hbs 0048226
ambari-web/app/views/main/alerts/definition_configs_view.js f3c77df
ambari-web/app/views/main/alerts/definition_details_view.js 656021c
ambari-web/test/views/main/alerts/definition_details_view_test.js a98b66b
Diff: https://reviews.apache.org/r/45462/diff/
Testing
-------
Local ambari-web test passed.
25642 tests complete (22 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
Re: Review Request 45462: AMBARI-15604 Alert Definitions Repeat
Tolerance Values Exposed In Web Client
Posted by "Zhe (Joe) Wang" <jw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45462/
-----------------------------------------------------------
(Updated April 5, 2016, 5:59 p.m.)
Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Jonathan Hurley, Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-15604
https://issues.apache.org/jira/browse/AMBARI-15604
Repository: ambari
Description
-------
Alert definitions will now expose two properties to control repeat tolerance values on an individual based (overriding those from cluster-env/alerts_repeat_tolerance)
Diffs (updated)
-----
ambari-web/app/controllers/global/update_controller.js dc0f7cf
ambari-web/app/controllers/main/alerts/definition_details_controller.js fe17732
ambari-web/app/mappers/alert_definitions_mapper.js 0bf534e
ambari-web/app/messages.js f68d97a
ambari-web/app/models/alerts/alert_definition.js a730572
ambari-web/app/styles/alerts.less 50246e6
ambari-web/app/templates/main/alerts/definition_details.hbs 0048226
ambari-web/app/views/main/alerts/definition_details_view.js 656021c
ambari-web/test/views/main/alerts/definition_details_view_test.js a98b66b
Diff: https://reviews.apache.org/r/45462/diff/
Testing
-------
Local ambari-web test passed.
25642 tests complete (22 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
Re: Review Request 45462: AMBARI-15604 Alert Definitions Repeat
Tolerance Values Exposed In Web Client
Posted by "Zhe (Joe) Wang" <jw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45462/
-----------------------------------------------------------
(Updated April 4, 2016, 10:44 p.m.)
Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Jonathan Hurley, Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-15604
https://issues.apache.org/jira/browse/AMBARI-15604
Repository: ambari
Description
-------
Alert definitions will now expose two properties to control repeat tolerance values on an individual based (overriding those from cluster-env/alerts_repeat_tolerance)
Diffs (updated)
-----
ambari-web/app/controllers/global/update_controller.js dcef1a2
ambari-web/app/controllers/main/alerts/definition_details_controller.js fe17732
ambari-web/app/mappers/alert_definitions_mapper.js 0bf534e
ambari-web/app/messages.js 1653eeb
ambari-web/app/models/alerts/alert_definition.js a730572
ambari-web/app/styles/alerts.less 50246e6
ambari-web/app/templates/main/alerts/definition_details.hbs 14b749d
ambari-web/app/views/main/alerts/definition_details_view.js 2fc75c1
ambari-web/test/views/main/alerts/definition_details_view_test.js a98b66b
Diff: https://reviews.apache.org/r/45462/diff/
Testing
-------
Local ambari-web test passed.
25642 tests complete (22 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
Re: Review Request 45462: AMBARI-15604 Alert Definitions Repeat
Tolerance Values Exposed In Web Client
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45462/#review126432
-----------------------------------------------------------
Ship it!
I'm normally not a web reviewer since I have limited work with ambari-web. I've looked this over for grammar and the proper backend properties and those look fine. So, from a backend standpoint, I can +1 this.
ambari-web/app/messages.js (line 1002)
<https://reviews.apache.org/r/45462/#comment189417>
Run-on sentence ... maybe revist to:
```
Setting repeat tolerance to a larger value means that it will take longer for alert notifications to be sent. This is because Ambari will wait until the repeat tolerance is reached. The time (in minutes) before notifications are sent is the interval multiplied by the tolerance.
```
- Jonathan Hurley
On March 29, 2016, 8:02 p.m., Zhe (Joe) Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45462/
> -----------------------------------------------------------
>
> (Updated March 29, 2016, 8:02 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Jonathan Hurley, Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-15604
> https://issues.apache.org/jira/browse/AMBARI-15604
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Alert definitions will now expose two properties to control repeat tolerance values on an individual based (overriding those from cluster-env/alerts_repeat_tolerance)
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/global/update_controller.js dcef1a2
> ambari-web/app/controllers/main/alerts/definition_details_controller.js fe17732
> ambari-web/app/mappers/alert_definitions_mapper.js 7aae518
> ambari-web/app/messages.js 5343bf1
> ambari-web/app/models/alerts/alert_definition.js 0acfc33
> ambari-web/app/styles/alerts.less 50246e6
> ambari-web/app/templates/main/alerts/definition_details.hbs 14b749d
>
> Diff: https://reviews.apache.org/r/45462/diff/
>
>
> Testing
> -------
>
> Local ambari-web test passed.
> 25642 tests complete (22 seconds)
> 154 tests pending
> Manual testing done.
>
>
> Thanks,
>
> Zhe (Joe) Wang
>
>