You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2025/02/11 15:22:00 UTC
[jira] [Commented] (ARTEMIS-5232) Cleanup the test suite for speed
[ https://issues.apache.org/jira/browse/ARTEMIS-5232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17926035#comment-17926035 ]
ASF subversion and git services commented on ARTEMIS-5232:
----------------------------------------------------------
Commit d4004eb2c6d60f34a7957375e6ea7c5ed1d18643 in activemq-artemis's branch refs/heads/main from Clebert Suconic
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=d4004eb2c6 ]
ARTEMIS-5232 Removing dodgy test
this test was failing here:
https://github.com/apache/activemq-artemis/blob/362dbd11ac132e66f7bce99eb0fb4aa020346210/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/SlowLargeMessageConsumerTest.java#L81
Any sort of GC / compilation / hickup.. anything will make this test fail.
I don't see much value on the test. Anyone who disagrees with me, please send a PR / commit fixing the test instead of removing it. :)
> Cleanup the test suite for speed
> --------------------------------
>
> Key: ARTEMIS-5232
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5232
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.39.0
> Reporter: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.40.0
>
> Time Spent: 5h
> Remaining Estimate: 0h
>
> In this task I will:
> - remove non sense tests. (there are a few tests that do not make sense)
> - remove duplicate tests.
> e.g. FailoverTests were written to validate the client retry.. and now you have ReplicatedFailoverTests, JDBCFailoverTests.. etc).
> I will keep one election to do replication, and a smaller set to be replicated in cases like this.
> - review some of the configurations in tests (like creating big journals).
> - extensive repetitions.
> - perhaps random select some of the parameters
> so far at the time I opened this JIRA I was able to shove down 1 hour of test suite run from integration-tests.. (from 2.5 hours to 1.5 hours).. still long but it's more manageable now. and we should keep pursuing it down.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@activemq.apache.org
For additional commands, e-mail: issues-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact