[GitHub] [druid] jihoonson commented on a change in pull request #8272: Support incremental load in Druid lookups

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #8272: Support incremental load in Druid lookups
URL: https://github.com/apache/druid/pull/8272#discussion_r399419234
 
 

 ##########
 File path: extensions-core/lookups-cached-global/src/main/java/org/apache/druid/server/lookup/namespace/cache/CacheScheduler.java
 ##########
 @@ -460,16 +539,22 @@ public void run()
 
   /**
    * This method should be used from {@link CacheGenerator#generateCache} implementations, to obtain a {@link
-   * VersionedCache} to be returned.
+   * VersionedCacheBuilder} to be returned.
    *
    * @param entryId an object uniquely corresponding to the {@link CacheScheduler.Entry}, for which VersionedCache is
    *                created
    * @param version version, associated with the cache
+   * @param cacheHandler, {@link CacheHandler} object to create {@link VersionedCache} from,
+   *                used for incremental load.
 
 Review comment:
   This seems like two sentences? Then, the first sentence should end with `.`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org