You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2023/12/17 09:15:32 UTC

[PR] [SPARK-46433][PS][TESTS] Reorganize `OpsOnDiffFramesGroupByTests`: Factor out `test_aggregate/apply/cum*` [spark]

zhengruifeng opened a new pull request, #44385:
URL: https://github.com/apache/spark/pull/44385

   ### What changes were proposed in this pull request?
   Factor out `test_aggregate/apply/cum*` 
   
   
   ### Why are the changes needed?
   they are slow tests
   
   
   ### Does this PR introduce _any_ user-facing change?
   no
   
   
   ### How was this patch tested?
   ci
   
   ### Was this patch authored or co-authored using generative AI tooling?
   no


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-46433][PS][TESTS] Reorganize `OpsOnDiffFramesGroupByTests`: Factor out `test_aggregate/apply/cum*` [spark]

Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #44385:
URL: https://github.com/apache/spark/pull/44385#issuecomment-1859450371

   thanks @itholic , merged to master
   
   there are still some slow tests in it, I will fix them in follow ups


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-46433][PS][TESTS] Reorganize `OpsOnDiffFramesGroupByTests`: Factor out `test_aggregate/apply/cum*` [spark]

Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #44385: [SPARK-46433][PS][TESTS] Reorganize `OpsOnDiffFramesGroupByTests`: Factor out `test_aggregate/apply/cum*` 
URL: https://github.com/apache/spark/pull/44385


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-46433][PS][TESTS] Reorganize `OpsOnDiffFramesGroupByTests`: Factor out `test_aggregate/apply/cum*` [spark]

Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #44385:
URL: https://github.com/apache/spark/pull/44385#issuecomment-1859684681

   Thanks for driving this!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-46433][PS][TESTS] Reorganize `OpsOnDiffFramesGroupByTests`: Factor out `test_aggregate/apply/cum*` [spark]

Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #44385:
URL: https://github.com/apache/spark/pull/44385#issuecomment-1859376310

   cc @HyukjinKwon @itholic 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org