You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by ko...@apache.org on 2026/10/21 06:32:34 UTC

(arrow) branch main updated: GH-54645: [C++][FlightRPC][ODBC] Fix descriptor test query (#54695)

This is an automated email from the ASF dual-hosted git repository.

kou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/main by this push:
     new a4b74e560c7 GH-54645: [C++][FlightRPC][ODBC] Fix descriptor test query (#54695)
a4b74e560c7 is described below

commit a4b74e560c7c409acd94fcd0ed9393c04942bb0a
Author: Vikrant Puppala <vi...@databricks.com>
AuthorDate: Wed Oct 21 12:02:27 2026 +0530

    GH-54645: [C++][FlightRPC][ODBC] Fix descriptor test query (#54695)
    
    ### Rationale for this change
    
    The Dremio-backed ODBC test suite fails in StatementTest/1.TestChangingAppRowDescriptorRebindsColumns because Dremio treats VALUE as a reserved keyword. The same query succeeds against the SQLite mock, so the failure was only exposed by the remote suite.
    
    ### What changes are included in this PR?
    
    Rename the test query alias from value to val, which is accepted by both SQLite and Dremio.
    
    ### Are these changes tested?
    
    Yes. Ran the Ubuntu 24.04 CI-equivalent ODBC job locally:
    
        UBUNTU=24.04 docker compose run --rm ubuntu-cpp-odbc
    
    All 61 C++ test executables passed, including the Dremio-backed arrow-flight-sql-odbc-test.
    
    Maintainer note: please apply the CI: Extra: C++ label so the ODBC CI job runs.
    
    ### Are there any user-facing changes?
    
    No. This is a test-only compatibility fix.
    
    ### Was AI used for this PR?
    
    In accordance to the AI generation guidelines, AI was used to investigate the failure, prepare the one-line test fix, run validation, and draft this description.
    
    **PR code and description written by:**
    
    - [ ] Human
    - [x] AI
    
    **Reviewed before submission by:**
    
    - [x] Human
    - [x] AI
    - [ ] Not reviewed
    
    Closes #54645.
    * GitHub Issue: #54645
    
    Authored-by: Vikrant Puppala <vi...@databricks.com>
    Signed-off-by: Sutou Kouhei <ko...@clear-code.com>
---
 cpp/src/arrow/flight/sql/odbc/tests/statement_test.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cpp/src/arrow/flight/sql/odbc/tests/statement_test.cc b/cpp/src/arrow/flight/sql/odbc/tests/statement_test.cc
index 6ae2cdbbbc3..ae9e37239fb 100644
--- a/cpp/src/arrow/flight/sql/odbc/tests/statement_test.cc
+++ b/cpp/src/arrow/flight/sql/odbc/tests/statement_test.cc
@@ -1789,7 +1789,7 @@ TYPED_TEST(StatementTest, TestChangingAppRowDescriptorRebindsColumns) {
 
   ASSIGN_SQLWCHAR_ARR_AND_LEN(wsql,
                               LR"(
-   SELECT 1 AS value
+   SELECT 1 AS val
    UNION ALL SELECT 2
    UNION ALL SELECT 3;
  )");