You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/08/06 02:36:35 UTC
[GitHub] [spark] itholic commented on a change in pull request #33646: [SPARK-36388][SPARK-36386][PYTHON] Fix DataFrame groupby-rolling and groupby-expanding to follow pandas 1.3
itholic commented on a change in pull request #33646:
URL: https://github.com/apache/spark/pull/33646#discussion_r683905345
##########
File path: python/pyspark/pandas/window.py
##########
@@ -706,11 +706,16 @@ def _apply_as_series_or_frame(self, func: Callable[[Column], Column]) -> FrameLi
if groupby._agg_columns_selected:
agg_columns = groupby._agg_columns
else:
- agg_columns = [
- psdf._psser_for(label)
+ agg_column_labels = [
+ label
for label in psdf._internal.column_labels
if label not in groupby._column_labels_to_exlcude
Review comment:
Got it, and seems like we should also rename `exlcude` to `exclude` ??
It's typo 😮
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org