You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2007/05/14 19:36:56 UTC
[Bug 5462] New: spamc -H randomization is broken
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5462
Summary: spamc -H randomization is broken
Product: Spamassassin
Version: 3.2.0
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P5
Component: spamc/spamd
AssignedTo: dev@spamassassin.apache.org
ReportedBy: rosenbaumlm@ornl.gov
Randomization (for load balancing) hosts when using
spamc -H -d name
where name resolves to multiple IP addresses no longer works in v3.2.0 on some
systems, including Solaris 9. If SPAMC_HAS_ADDRINFO is defined, then the list
of IP addresses is kept as a single array element pointing to an addrinfo
linked list, and therefore the IP addresses are not randomized by the
_randomize_hosts() function.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5462] spamc -H randomization is broken
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5462
cheese@nosuchhost.net changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |cheese@nosuchhost.net
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5462] spamc -H randomization is broken
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5462
sidney@sidney.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|3.2.1 |3.2.2
------- Additional Comments From sidney@sidney.com 2007-06-04 21:59 -------
Moving items off the 3.2.1 queue to 3.2.2 to facilitate a quick release.
If you can get this in Review status right away feel free to move it back
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5462] spamc -H randomization is broken
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5462
------- Additional Comments From cheese@nosuchhost.net 2007-06-14 06:02 -------
starting with 3.2.0 (3.2.1 has the same problem) i have a problem.
3.1.9:
spamc -d spam -> spamc connects to all hosts whose ips get listed via
dns-roundrobin
3.2.0 and 3.2.1 -> spamc connects to only one host, and if that host is not
reachable gets onto the next one.
would be great to get the old behaviour back.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5462] spamc -H randomization is broken
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5462
------- Additional Comments From jm@jmason.org 2007-06-20 06:26 -------
Created an attachment (id=4003)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=4003&action=view)
fix
it turned out that the getaddrinfo() code just copied the first addr entry,
instead of all of them; this implements that. (it also adds a test and
fixes up some braces so that %-bouncing works in that method.)
note however that it exposed another issue; bug 5531. that's a separate bug
though, and is not as important (just a tiny memory leak ;)
added to trunk:
: jm 70...; svn commit -m "bug 5462: spamc -H randomization was broken; fix"
Sending MANIFEST
Sending spamc/libspamc.c
Adding t/spamc_H.t
Transmitting file data ...
Committed revision 549103.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5462] spamc -H randomization is broken
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5462
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Undefined |3.2.1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5462] [review] spamc -H randomization is broken
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5462
------- Additional Comments From duncf@debian.org 2007-06-30 22:52 -------
Whoops... maybe I misread the previous comments. Feel free to ignore me. :-)
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5462] [review] spamc -H randomization is broken
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5462
sidney@sidney.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
Status Whiteboard|go |
------- Additional Comments From sidney@sidney.com 2007-07-04 12:50 -------
Committed to branch 3.2 revision 553314.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5462] [review] spamc -H randomization is broken
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5462
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 1 vote |go
------- Additional Comments From spamassassin@dostech.ca 2007-07-04 11:56 -------
+1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5462] spamc -H randomization is broken
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5462
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |major
Priority|P5 |P1
------- Additional Comments From jm@jmason.org 2007-06-15 05:59 -------
top priority
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5462] [review] spamc -H randomization is broken
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5462
------- Additional Comments From duncf@debian.org 2007-06-30 22:51 -------
Could we add a test to test for MANIFEST issues? :-)
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5462] [review] spamc -H randomization is broken
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5462
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|spamc -H randomization is |[review] spamc -H
|broken |randomization is broken
Status Whiteboard| |needs 2 votes
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5462] [review] spamc -H randomization is broken
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5462
------- Additional Comments From jm@jmason.org 2007-06-21 08:27 -------
oops. yep, ignore MANIFEST problems; adding tests seems to do that :(
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5462] [review] spamc -H randomization is broken
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5462
sidney@sidney.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 2 votes |needs 1 vote
------- Additional Comments From sidney@sidney.com 2007-06-20 22:24 -------
+1 for the patch (but get MANIFEST right before committing)
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5462] [review] spamc -H randomization is broken
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5462
------- Additional Comments From sidney@sidney.com 2007-07-04 12:59 -------
$ svn ci -m "bug5462: add file that I forgot to svn add before checkin of rev
553314"
Adding t/spamc_H.t
Transmitting file data .
Committed revision 553316.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5462] [review] spamc -H randomization is broken
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5462
------- Additional Comments From sidney@sidney.com 2007-06-20 22:02 -------
The patch doesn't apply cleanly to MANIFEST because t/root_spamd_virtual.t is
not in the 3.2 branch at the moment. That's more of an FYI ... I'll vote when my
testing finishes
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5462] spamc -H randomization is broken
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5462
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO| |5531
nThis| |
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.