You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-commits@lucene.apache.org by no...@apache.org on 2009/12/11 10:24:14 UTC
svn commit: r889541 - in /lucene/solr/trunk/contrib/dataimporthandler:
CHANGES.txt
src/main/java/org/apache/solr/handler/dataimport/PlainTextEntityProcessor.java
Author: noble
Date: Fri Dec 11 09:24:14 2009
New Revision: 889541
URL: http://svn.apache.org/viewvc?rev=889541&view=rev
Log:
SOLR-1598 Reader used in PlainTextEntityProcessor.nextRow() is not explicitly closed
Modified:
lucene/solr/trunk/contrib/dataimporthandler/CHANGES.txt
lucene/solr/trunk/contrib/dataimporthandler/src/main/java/org/apache/solr/handler/dataimport/PlainTextEntityProcessor.java
Modified: lucene/solr/trunk/contrib/dataimporthandler/CHANGES.txt
URL: http://svn.apache.org/viewvc/lucene/solr/trunk/contrib/dataimporthandler/CHANGES.txt?rev=889541&r1=889540&r2=889541&view=diff
==============================================================================
--- lucene/solr/trunk/contrib/dataimporthandler/CHANGES.txt (original)
+++ lucene/solr/trunk/contrib/dataimporthandler/CHANGES.txt Fri Dec 11 09:24:14 2009
@@ -22,9 +22,13 @@
----------------------
* SOLR-1525 allow DIH to refer to core properties (noble)
+
* SOLR-1547 TemplateTransformer copy objects more intelligently when there when the template is a single variable (noble)
+
* SOLR-1627 VariableResolver should be fetched just in time (noble)
-* SOLR-1583 Create DataSources that return InputStream (noble)
+
+* SOLR-1583 Create DataSources that return InputStream (noble)
+
Optimizations
----------------------
@@ -36,6 +40,8 @@
* SOLR-1639: Fixed misleading error message when dataimport.properties is not writable (shalin)
+* SOLR-1598: Reader used in PlainTextEntityProcessor is not explicitly closed (Sascha Szott via noble)
+
Other Changes
----------------------
Modified: lucene/solr/trunk/contrib/dataimporthandler/src/main/java/org/apache/solr/handler/dataimport/PlainTextEntityProcessor.java
URL: http://svn.apache.org/viewvc/lucene/solr/trunk/contrib/dataimporthandler/src/main/java/org/apache/solr/handler/dataimport/PlainTextEntityProcessor.java?rev=889541&r1=889540&r2=889541&view=diff
==============================================================================
--- lucene/solr/trunk/contrib/dataimporthandler/src/main/java/org/apache/solr/handler/dataimport/PlainTextEntityProcessor.java (original)
+++ lucene/solr/trunk/contrib/dataimporthandler/src/main/java/org/apache/solr/handler/dataimport/PlainTextEntityProcessor.java Fri Dec 11 09:24:14 2009
@@ -19,6 +19,7 @@
import static org.apache.solr.handler.dataimport.DataImportHandlerException.SEVERE;
import static org.apache.solr.handler.dataimport.DataImportHandlerException.wrapAndThrow;
import static org.apache.solr.handler.dataimport.XPathEntityProcessor.URL;
+import org.apache.commons.io.IOUtils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@@ -77,6 +78,7 @@
Map<String, Object> row = new HashMap<String, Object>();
row.put(PLAIN_TEXT, sw.toString());
ended = true;
+ IOUtils.closeQuietly(r);
return row;
}