You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/04/11 20:53:14 UTC

[GitHub] [airflow] potiuk commented on a diff in pull request #30569: Use template comments for the chart license header

potiuk commented on code in PR #30569:
URL: https://github.com/apache/airflow/pull/30569#discussion_r1163319998


##########
.pre-commit-config.yaml:
##########
@@ -115,8 +115,18 @@ repos:
           - license-templates/LICENSE.txt
           - --fuzzy-match-generates-todo
       - id: insert-license
-        name: Add license for all YAML files
+        name: Add license for all Helm template files
         exclude: ^\.github/.*$|^.*/.*_vendor/

Review Comment:
   You should likely remove the `exclude` (not needed any more)  and have those:
   ```
           types: [yaml]
           files: ^chart/templates/.*\.ya?ml$
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org