You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/10/21 13:40:41 UTC

[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1272: [KYUUBI #1267] Modify comments for the golden file test suite and fix it

ulysses-you commented on a change in pull request #1272:
URL: https://github.com/apache/incubator-kyuubi/pull/1272#discussion_r733688214



##########
File path: externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/udf/KDFRegistry.scala
##########
@@ -31,7 +31,10 @@ object KDFRegistry {
   @transient
   val registeredFunctions = new ArrayBuffer[KyuubiDefinedFunction]()
 
-  val appName = SparkEnv.get.conf.get("spark.app.name")
+  val appName = SparkEnv.get match {

Review comment:
       how about make them lazy?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org