Change in asterixdb[stabilization-f69489]: [NO ISSUE][RT] Fix Secondary Indexes Bulkload/Upsert

["Luo Chen (Code Review)" <do...@asterixdb.incubator.apache.org>]

Luo Chen has posted comments on this change.

Change subject: [NO ISSUE][RT] Fix Secondary Indexes Bulkload/Upsert
......................................................................


Patch Set 3:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/3304/3/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMSecondaryUpsertOperatorNodePushable.java
File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMSecondaryUpsertOperatorNodePushable.java:

PS3, Line 143:  private boolean isMissing(PermutingFrameTupleReference tuple, int fieldIdx) {
             :         return TypeTagUtil.isType(tuple, fieldIdx, ATypeTag.SERIALIZED_MISSING_TYPE_TAG);
             :     }
It's better to extend this method to isMissingOrNull so that we can minimize the changes to the upsert logic?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3304
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b847aece06a4387cc41389b0566d0c0dc98487d
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Luo Chen <cl...@uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: Yes