You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ode.apache.org by mi...@apache.org on 2009/11/19 22:57:18 UTC

svn commit: r882314 - /ode/branches/APACHE_ODE_1.X/scheduler-simple/src/main/java/org/apache/ode/scheduler/simple/SimpleScheduler.java

Author: midon
Date: Thu Nov 19 21:57:18 2009
New Revision: 882314

URL: http://svn.apache.org/viewvc?rev=882314&view=rev
Log:
better logging

Modified:
    ode/branches/APACHE_ODE_1.X/scheduler-simple/src/main/java/org/apache/ode/scheduler/simple/SimpleScheduler.java

Modified: ode/branches/APACHE_ODE_1.X/scheduler-simple/src/main/java/org/apache/ode/scheduler/simple/SimpleScheduler.java
URL: http://svn.apache.org/viewvc/ode/branches/APACHE_ODE_1.X/scheduler-simple/src/main/java/org/apache/ode/scheduler/simple/SimpleScheduler.java?rev=882314&r1=882313&r2=882314&view=diff
==============================================================================
--- ode/branches/APACHE_ODE_1.X/scheduler-simple/src/main/java/org/apache/ode/scheduler/simple/SimpleScheduler.java (original)
+++ ode/branches/APACHE_ODE_1.X/scheduler-simple/src/main/java/org/apache/ode/scheduler/simple/SimpleScheduler.java Thu Nov 19 21:57:18 2009
@@ -508,7 +508,6 @@
                                 } catch (JobProcessorException jpe) {
                                     if (!jpe.retry) {
                                         needRetry[0] = false;
-                                        __log.error("Error while processing job, no retry: "+job, jpe);
                                     }
                                     // Let execTransaction know that shit happened.
                                     throw jpe;
@@ -519,9 +518,9 @@
                     } catch (JobNoLongerInDbException jde) {
                         // This may happen if two node try to do the same job... we try to avoid
                         // it the synchronization is a best-effort but not perfect.
-                        __log.debug("job no longer in db forced rollback.");
+                        __log.debug("job no longer in db forced rollback: "+job);
                     } catch (final Exception ex) {
-                        __log.error("Error while executing job: "+job, ex);
+                        __log.error("Error while processing a "+(job.persisted?"":"non-")+"persisted job"+(needRetry[0] && job.persisted?": ":", no retry: ")+job, ex);
 
                         // We only get here if the above execTransaction fails, so that transaction got
                         // rollbacked already