You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "mridulm (via GitHub)" <gi...@apache.org> on 2023/10/22 10:17:35 UTC
[PR] CELEBORN-1069: Avoid double brace initialization [incubator-celeborn]
mridulm opened a new pull request, #2020:
URL: https://github.com/apache/incubator-celeborn/pull/2020
### What changes were proposed in this pull request?
Avoid double brace initialization. See more [here](https://errorprone.info/bugpattern/DoubleBraceInitialization)
Note that in this case, there is no actual functional or performance issue - since it is happening in test cases.
### Why are the changes needed?
Once fixed, error-prone can catch future violations as part of build as Celeborn evolves.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CELEBORN-1069: Avoid double brace initialization [incubator-celeborn]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2020:
URL: https://github.com/apache/incubator-celeborn/pull/2020#issuecomment-1774056619
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2020?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#2020](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2020?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (4bea606) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/f93be45506d3ec4a0aa2b4cfb9327a05926071cd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f93be45) will **increase** coverage by `0.12%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #2020 +/- ##
==========================================
+ Coverage 46.64% 46.75% +0.12%
==========================================
Files 165 165
Lines 10531 10531
Branches 959 959
==========================================
+ Hits 4911 4923 +12
+ Misses 5295 5284 -11
+ Partials 325 324 -1
```
[see 2 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2020/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CELEBORN-1069: Avoid double brace initialization [incubator-celeborn]
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture closed pull request #2020: CELEBORN-1069: Avoid double brace initialization
URL: https://github.com/apache/incubator-celeborn/pull/2020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org