You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/12/06 19:31:59 UTC
[GitHub] [shardingsphere] Franco-H opened a new pull request #13959: Issue#10964
Franco-H opened a new pull request #13959:
URL: https://github.com/apache/shardingsphere/pull/13959
Fixes #ISSUSE_10964.
Issue was assigned to another contributor on Jul 15, 2021, but it is still in progress as of today. Since I have already completed the issue for the school project, I still want to make a PR. The code maintainers could reject my PR if the PR has to be made by the assigned contributor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Franco-H commented on pull request #13959: Add unit test for shardingsphere-encrypt (Issue#10964)
Posted by GitBox <gi...@apache.org>.
Franco-H commented on pull request #13959:
URL: https://github.com/apache/shardingsphere/pull/13959#issuecomment-989192752
Strange. It says "NewlineAtEndOfFile: File does not end with a newline". Is that an issue with the checkstyle configuration? Or is it the problem of my code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss commented on pull request #13959: Add unit test for shardingsphere-encrypt (Issue#10964)
Posted by GitBox <gi...@apache.org>.
menghaoranss commented on pull request #13959:
URL: https://github.com/apache/shardingsphere/pull/13959#issuecomment-992273010
> @menghaoranss Looks like there are more issues found now but I did not touch my code at all except adding a new empty line to pass the checkstyle violation. Does this have something to do with new merge in the last couple days?
@Franco-H Ci must be triggered manually when you commit a PR for the first time, this PR build failed now, please check again, and you modified 19 files altogether, I suggest you split these files into multiple PRs to help them be reviewed more easily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang closed pull request #13959: Add unit test for shardingsphere-encrypt (Issue#10964)
Posted by GitBox <gi...@apache.org>.
RaigorJiang closed pull request #13959:
URL: https://github.com/apache/shardingsphere/pull/13959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss commented on pull request #13959: Issue#10964
Posted by GitBox <gi...@apache.org>.
menghaoranss commented on pull request #13959:
URL: https://github.com/apache/shardingsphere/pull/13959#issuecomment-987590100
@Franco-H ci build failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Franco-H commented on pull request #13959: Issue#10964
Posted by GitBox <gi...@apache.org>.
Franco-H commented on pull request #13959:
URL: https://github.com/apache/shardingsphere/pull/13959#issuecomment-987600755
>
Im fixing it. will update soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Franco-H closed pull request #13959: Add unit test for shardingsphere-encrypt (Issue#10964)
Posted by GitBox <gi...@apache.org>.
Franco-H closed pull request #13959:
URL: https://github.com/apache/shardingsphere/pull/13959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Franco-H commented on pull request #13959: Add unit test for shardingsphere-encrypt (Issue#10964)
Posted by GitBox <gi...@apache.org>.
Franco-H commented on pull request #13959:
URL: https://github.com/apache/shardingsphere/pull/13959#issuecomment-989193134
Strange. It says "NewlineAtEndOfFile: File does not end with a newline". Is that an issue with the checkstyle configuration? Or is it the problem of my code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on pull request #13959: Add unit test for shardingsphere-encrypt (Issue#10964)
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on pull request #13959:
URL: https://github.com/apache/shardingsphere/pull/13959#issuecomment-1020717628
Since this PR has been inactive for more than 30 days, I just close it.
If you wish to continue contributing, please fix the conflicting files and reopen it, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang closed pull request #13959: Add unit test for shardingsphere-encrypt (Issue#10964)
Posted by GitBox <gi...@apache.org>.
RaigorJiang closed pull request #13959:
URL: https://github.com/apache/shardingsphere/pull/13959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Franco-H commented on pull request #13959: Add unit test for shardingsphere-encrypt (Issue#10964)
Posted by GitBox <gi...@apache.org>.
Franco-H commented on pull request #13959:
URL: https://github.com/apache/shardingsphere/pull/13959#issuecomment-989514874
@menghaoranss Looks like there are more issues found now but I did not touch my code at all except adding a new empty line to pass the checkstyle violation. Does this have something to do with new merge in the last couple days?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Franco-H commented on pull request #13959: Add unit test for shardingsphere-encrypt (Issue#10964)
Posted by GitBox <gi...@apache.org>.
Franco-H commented on pull request #13959:
URL: https://github.com/apache/shardingsphere/pull/13959#issuecomment-989501201
Need to re-run it again. The build before the last build only had a checkstyle error (add line). I fixed it and the project built successfully at my end. However, there were two new issues in the last built from the VM and these issues never happen at my end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Franco-H commented on pull request #13959: Add unit test for shardingsphere-encrypt (Issue#10964)
Posted by GitBox <gi...@apache.org>.
Franco-H commented on pull request #13959:
URL: https://github.com/apache/shardingsphere/pull/13959#issuecomment-988493528
Accidentally closed the branch. Just reopened it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Franco-H removed a comment on pull request #13959: Add unit test for shardingsphere-encrypt (Issue#10964)
Posted by GitBox <gi...@apache.org>.
Franco-H removed a comment on pull request #13959:
URL: https://github.com/apache/shardingsphere/pull/13959#issuecomment-989192752
Strange. It says "NewlineAtEndOfFile: File does not end with a newline". Is that an issue with the checkstyle configuration? Or is it the problem of my code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on pull request #13959: Add unit test for shardingsphere-encrypt (Issue#10964)
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on pull request #13959:
URL: https://github.com/apache/shardingsphere/pull/13959#issuecomment-1020717628
Since this PR has been inactive for more than 30 days, I just close it.
If you wish to continue contributing, please fix the conflicting files and reopen it, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on pull request #13959: Add unit test for shardingsphere-encrypt (Issue#10964)
Posted by GitBox <gi...@apache.org>.
terrymanu commented on pull request #13959:
URL: https://github.com/apache/shardingsphere/pull/13959#issuecomment-1012744749
Hello, any update?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org