[GitHub] [hadoop] virajjasani commented on a diff in pull request #5621: HADOOP-18688. S3A audit info to include num of items in delete ops

["virajjasani (via GitHub)" <gi...@apache.org>]

virajjasani commented on code in PR #5621:
URL: https://github.com/apache/hadoop/pull/5621#discussion_r1188897114


##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/performance/ITestS3ADeleteCost.java:
##########
@@ -181,6 +184,8 @@ public void testDeleteFileInDir() throws Throwable {
 
   @Test
   public void testDirMarkersSubdir() throws Throwable {
+    LogCapturer logCapturer =

Review Comment:
   i wanted to add test in `TestHttpReferrerAuditHeader` initially but since i thought it would be better to capture headers with an already written tests that perform delete/rename with bulk deletes, and log capturer is the only utility we have to target a specific log name. 
   It might look ugly in the sense that we will have to capture a particular line of the logs so if source code changes log lines, then test would fail. but otherwise, it adds stdout as log4j appender, hence logs are always captured, no matter how many tests we run in parallel.
   
   However, i see your point that it's still ugly and not well managed. let me check if there are any other ways to test the same.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org