You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "brianmmaina (via GitHub)" <gi...@apache.org> on 2026/06/30 17:23:45 UTC
[PR] fix(i18n): update German security menu translations [superset]
brianmmaina opened a new pull request, #41587:
URL: https://github.com/apache/superset/pull/41587
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
Fixes incorrect German translations for security menu items.
Updates:
- `List Groups` → `Gruppen auflisten`
- `List Roles` → `Rollen auflisten`
- `List Users` → `Benutzer*innen auflisten`
Note: `Themes` is already translated correctly as `Designs` on current `master`, so this PR only updates the remaining list labels.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Not included. This is a translation-only change.
### TESTING INSTRUCTIONS
Verified the updated entries in `superset/translations/de/LC_MESSAGES/messages.po`.
### ADDITIONAL INFORMATION
- [x] Has associated issue: Closes #41335
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(i18n): update German security menu translations [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #41587:
URL: https://github.com/apache/superset/pull/41587#issuecomment-4847217927
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 5a53a1f4a70e9ada4dd7646d619024dc89937eef |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a44186b87aaf800088508da |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-41587--superset-docs-preview.netlify.app](https://deploy-preview-41587--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcvJCYAwEEDRXuZsMILLYAeWMVnUgFmYJKCIvZvbP_z3QuLoU4EVoAPFFPTZend3f1j2FES2urIrj_A2VFHakS8qLobcgLHpis9mGplpHAecFS5EO0opESeJhuD7AQ) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-41587--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(i18n): update German security menu translations [superset]
Posted by "brianmmaina (via GitHub)" <gi...@apache.org>.
brianmmaina commented on code in PR #41587:
URL: https://github.com/apache/superset/pull/41587#discussion_r3501327952
##########
superset/translations/de/LC_MESSAGES/messages.po:
##########
@@ -7870,16 +7870,16 @@ msgid "List"
msgstr "Auflisten"
msgid "List Groups"
-msgstr "Gruppen"
+msgstr "Gruppen auflisten"
msgid "List Roles"
-msgstr "Rollen"
+msgstr "Rollen auflisten"
msgid "List Unique Values"
msgstr "Eindeutige Werte auflisten"
msgid "List Users"
-msgstr "Benutzer*innen"
+msgstr "Benutzer*innen auflisten"
Review Comment:
Updated this to `Benutzer auflisten`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(i18n): update German security menu translations [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #41587:
URL: https://github.com/apache/superset/pull/41587#issuecomment-4846177384
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(i18n): update German security menu translations [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41587:
URL: https://github.com/apache/superset/pull/41587#issuecomment-4856309558
<!-- translation-regression-bot -->
## ⚠️ Translation Regression Detected
A source change in this PR renamed or reworded strings, invalidating existing translations (they are now `#, fuzzy`) in `fi`, `th`. Please resolve the affected `.po` files before merging.
_Note: intentionally **deleting** a translatable string is not a regression and is not flagged here — only translations invalidated by a renamed/reworded source string are._
| Language | Fuzzy before | Fuzzy after | New |
|----------|-------------:|------------:|----:|
| `fi` | 4808 | 4809 | +1 |
| `th` | 4808 | 4809 | +1 |
### How to fix
**1. Install dependencies** (if not already set up):
```bash
pip install -r superset/translations/requirements.txt
sudo apt-get install gettext # or: brew install gettext
```
**2. Re-extract strings and sync `.po` files:**
```bash
./scripts/translations/babel_update.sh
```
This rewrites `superset/translations/messages.pot` from the current source files and merges the changes into every `.po` file. Strings whose `msgid` changed will be marked `#, fuzzy`.
**3. Resolve the fuzzy entries** in the affected language files (`fi`, `th`):
```bash
grep -n '#, fuzzy' superset/translations/<lang>/LC_MESSAGES/messages.po
```
For each fuzzy entry, either rewrite the `msgstr` to match the new string and remove the `#, fuzzy` line, or clear the `msgstr` to `""` if you cannot provide a translation.
**4. Commit your changes to the `.po` files.**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(i18n): update German security menu translations [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on code in PR #41587:
URL: https://github.com/apache/superset/pull/41587#discussion_r3500727291
##########
superset/translations/de/LC_MESSAGES/messages.po:
##########
@@ -7870,16 +7870,16 @@ msgid "List"
msgstr "Auflisten"
msgid "List Groups"
-msgstr "Gruppen"
+msgstr "Gruppen auflisten"
msgid "List Roles"
-msgstr "Rollen"
+msgstr "Rollen auflisten"
msgid "List Unique Values"
msgstr "Eindeutige Werte auflisten"
msgid "List Users"
-msgstr "Benutzer*innen"
+msgstr "Benutzer*innen auflisten"
Review Comment:
I recall German only has umlaut, not asterisk 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(i18n): update German security menu translations [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #41587:
URL: https://github.com/apache/superset/pull/41587#issuecomment-4846310623
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/41587?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 55.87%. Comparing base ([`92f48b0`](https://app.codecov.io/gh/apache/superset/commit/92f48b072579e49a09620d1625280af0e44fcb5c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9f4fc64`](https://app.codecov.io/gh/apache/superset/commit/9f4fc642ffd94a22f2afee364dd24935440ad71e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 11 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (92f48b0) and HEAD (9f4fc64). Click for more details.
>
> <details><summary>HEAD has 30 uploads less than BASE</summary>
>
>| Flag | BASE (92f48b0) | HEAD (9f4fc64) |
>|------|------|------|
>|python|26|2|
>|presto|4|1|
>|hive|4|1|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #41587 +/- ##
==========================================
- Coverage 64.60% 55.87% -8.74%
==========================================
Files 2664 2664
Lines 146433 146433
Branches 33859 33859
==========================================
- Hits 94607 81823 -12784
- Misses 50110 63870 +13760
+ Partials 1716 740 -976
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/41587/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/41587/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.21% <ø> (ø)` | |
| [mysql](https://app.codecov.io/gh/apache/superset/pull/41587/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/41587/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/41587/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.78% <ø> (ø)` | |
| [python](https://app.codecov.io/gh/apache/superset/pull/41587/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.84% <ø> (-18.62%)` | :arrow_down: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/41587/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unit](https://app.codecov.io/gh/apache/superset/pull/41587/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/41587?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(i18n): update German security menu translations [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #41587:
URL: https://github.com/apache/superset/pull/41587#issuecomment-4846322385
<!-- Bito Reply -->
You are correct. In German, the umlaut (ä, ö, ü) is used to modify vowels, whereas the asterisk (*) is not a standard character in German orthography. If the asterisk was used in the translation file, it is likely a placeholder or a formatting error that should be corrected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(i18n): update German security menu translations [superset]
Posted by "brianmmaina (via GitHub)" <gi...@apache.org>.
brianmmaina commented on code in PR #41587:
URL: https://github.com/apache/superset/pull/41587#discussion_r3500982380
##########
superset/translations/de/LC_MESSAGES/messages.po:
##########
@@ -7870,16 +7870,16 @@ msgid "List"
msgstr "Auflisten"
msgid "List Groups"
-msgstr "Gruppen"
+msgstr "Gruppen auflisten"
msgid "List Roles"
-msgstr "Rollen"
+msgstr "Rollen auflisten"
msgid "List Unique Values"
msgstr "Eindeutige Werte auflisten"
msgid "List Users"
-msgstr "Benutzer*innen"
+msgstr "Benutzer*innen auflisten"
Review Comment:
Good catch. Totally my bad, I had kept the inclusive form from the current file and only added auflisten, but I’ll change this with the translation and update it to Benutzer auflisten if that's all good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(i18n): update German security menu translations [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #41587:
URL: https://github.com/apache/superset/pull/41587#issuecomment-4848424686
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org